VirtualBox

source: vbox/trunk/doc/VBox-MakefileGuidelines.cpp@ 23192

Last change on this file since 23192 was 19033, checked in by vboxsync, 16 years ago

VBox-MakefileGuidelines: two more rules.

  • Property svn:eol-style set to native
  • Property svn:keywords set to Author Date Id Revision
File size: 7.8 KB
Line 
1/* $Id: VBox-MakefileGuidelines.cpp 19033 2009-04-20 15:39:13Z vboxsync $ */
2/** @file
3 * VBox - Makefile Guidelines.
4 */
5
6/*
7 * Copyright (C) 2009 Sun Microsystems, Inc.
8 *
9 * This file is part of VirtualBox Open Source Edition (OSE), as
10 * available from http://www.virtualbox.org. This file is free software;
11 * you can redistribute it and/or modify it under the terms of the GNU
12 * General Public License (GPL) as published by the Free Software
13 * Foundation, in version 2 as it comes in the "COPYING" file of the
14 * VirtualBox OSE distribution. VirtualBox OSE is distributed in the
15 * hope that it will be useful, but WITHOUT ANY WARRANTY of any kind.
16 *
17 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa
18 * Clara, CA 95054 USA or visit http://www.sun.com if you need
19 * additional information or have any questions.
20 */
21
22/** @page pg_vbox_makefile_guidelines VBox Makefile Guidelines
23 *
24 * These guidelines apply to all the Makefile.kmk files in the tree.
25 * No exceptions.
26 *
27 * All these makefiles are ultimately the responsiblity of bird. Since there are
28 * currently more than two hundred files and the number is growing, they have to
29 * be very kept uniform or it will become very difficult to maintain them and
30 * impossible do bulk refactoring. Thus these guidelines have no bits that are
31 * optional unlike the coding guidelines, and should be thought of as rules
32 * rather than guidelines.
33 *
34 * Note! The guidelines do not apply to the other makefiles found in the source
35 * tree, like the ones shipped in the SDK and the ones for the linux kernel
36 * modules.
37 *
38 *
39 * @section sec_vbox_makefile_guidelines_kbuild kBuild
40 *
41 * kBuild is way older than VirtualBox, at least as a concept, but the
42 * VirtualBox project was a push to get something done about it again. It's
43 * maintained by bird in his spare time because: "We don't make buildsystems, we
44 * make virtual machines". So, kBuild makes progress when there is spare time or
45 * when there is an urgent need for something.
46 *
47 * The kBuild docs are in the process of being written. The current items and
48 * their status per 2009-04-19:
49 * - kmk Quick Reference [completed]:
50 * http://svn.netlabs.org/kbuild/wiki/kmk%20Quick%20Reference
51 * - kBuild Quick Reference [just started]:
52 * http://svn.netlabs.org/kbuild/wiki/kBuild%20Quick%20Reference
53 *
54 * Local copies of the docs can be found in kBuild/docs, just keep in mind that
55 * they might be slightly behind the online version.
56 *
57 *
58 * @section sec_vbox_makefile_guidelines_example Example Makefiles
59 *
60 * Let me point to some good sample makefiles:
61 * - src/VBox/Additions/common/VBoxService/Makefile.kmk
62 * - src/VBox/Debugger/Makefile.kmk
63 * - src/VBox/Disassembler/Makefile.kmk
64 *
65 * And some bad ones:
66 * - src/lib/xpcom18a4/Makefile.kmk
67 * - src/recompiler/Makefile.kmk
68 * - src/VBox/Devices/Makefile.kmk
69 * - src/VBox/Main/Makefile.kmk
70 * - src/VBox/Runtime/Makefile.kmk
71 *
72 *
73 * @section sec_vbox_makefile_guidelines Guidelines
74 *
75 * First one really important fact:
76 *
77 * Everything is global because all makefiles
78 * are virtually one single makefile.
79 *
80 * The rules:
81 *
82 * - Using bits defined by a sub-makefile is fine, using anything defined
83 * by a parent, sibling, uncle, cousine, or remoter relatives is not
84 * Okay. It may break sub-tree building and possibly also
85 * VBOX_SINGLE_MAKEFILE, both things that has to work all the time.
86 *
87 * - The traditional recursive build must always work, i.e. undefine
88 * VBOX_SINGLE_MAKEFILE.
89 *
90 * - Template names starts with VBOX and are all upper cased, no
91 * underscores or other separators. (TODO: Change this to camel case.)
92 *
93 * - Makefile variables shall be prefixed with VBOX or VB to avoid clashes
94 * with environment and kBuild variables.
95 *
96 * - Makefile variables are all upper cased and uses underscores to
97 * separate the words.
98 *
99 * - All variables are global. Make sure they are globally unique, but try
100 * not make them incredible long.
101 *
102 * - Makefile variables goes after the inclusion of the header and
103 * usually after including sub-makefiles.
104 *
105 * - Variables that are used by more than one makefile usually belongs
106 * in the monster file, Config.kmk.
107 *
108 * - Targets are lower or camel cased and as a rule the same as the
109 * resulting binary.
110 *
111 * - Install targets frequently have a -inst in their name, and a name that
112 * gives some idea what they install
113 *
114 * - Always use templates (mytarget_TEMPLATE = VBOXSOMETHING).
115 *
116 * - Comment each target with a 3+ line block as seen in
117 * src/VBox/Debugger/Makefile.kmk.
118 *
119 * - No space between the comment block and the target definition.
120 *
121 * - Try fit all the custom recipes after the target they apply to.
122 *
123 * - Custom recipes that apply to more than one target should be placed at
124 * the bottom of the makefile, before the footer inclusion when possible.
125 *
126 * - Do NOT use custom recipes to install stuff, use install targets.
127 * Generate files to inst-target_0_OUTDIR. (Yes, there are a lot places
128 * where we don't do this yet.)
129 *
130 * - Always break SOURCES, LIBS, long target list and other lists the
131 * manner Debugger_SOURCES is broeken into multiple lines in
132 * src/VBox/Debugger/Makefile.kmk. I.e. exactly one tab, the file name /
133 * list item, another space, the slash and then the newline.
134 *
135 * - The last element of an broken list should not have a slash-newline,
136 * otherwise we risk getting the next variable into the list.
137 *
138 * - Indentation of if'ed blocks is done in 1 space increments, this also
139 * applies to broken lists. It does not apply to the commands in a
140 * recipes of course, because that would make kmk choke. (Yes, there are
141 * plenty examples of doing this differently, but these will be weeded
142 * out over time.)
143 *
144 * - \$(NO_SUCH_VARIABLE) should be when you need to put nothing somewhere,
145 * for instance to prevent inherting an attribute.
146 *
147 * - Always put the defines in the DEFS properties, never use the FLAGS
148 * properties for this. Doing so may screw up depenencies and object
149 * caches.
150 *
151 * - Mark each section and target of the file with a 3+ lines comment
152 * block.
153 *
154 * - Document variables that are not obvious using double hash comments.
155 *
156 * - Each an every Makefile.kmk shall have a file header with Id, file
157 * description and copyright/license exactly like in the examples.
158 *
159 * - Multiple blank lines in a makefile is very seldom there without a
160 * reason and shall be preserved.
161 *
162 * - Inserting blank lines between target properties is all right if the
163 * target definition is long and/or crooked.
164 *
165 * - if1of and ifn1of shall always have a space after the comma, while ifeq
166 * and ifneq shall not. That way they are easier to tell apart.
167 *
168 * - Do a svn diff before committing makefile changes.
169 *
170 *
171 * @section sec_vbox_makefile_guidelines_reminders Helpful reminders
172 *
173 * - Do not be afraid to ask for help on IRC or in the defect you're
174 * working on. There are usually somebody around that know how to best do
175 * something.
176 *
177 * - Watch out for "Heads Up!" bugtracker messages concerning the build
178 * system.
179 *
180 * - To remove bits from a template you're using you have to create a new
181 * template that extends the existing one and creatively use
182 * \$(filter-out) or \$(patsubst).
183 *
184 * - You can build sub-trees.
185 *
186 * - You don't have to cd into sub-trees: kmk -C src/recompiler
187 *
188 * - You can build individual targets: kmk VBoxRT
189 *
190 * - Even install targets: kmk nobin
191 *
192 * - You can compile individual source files: kmk ConsoleImpl.o
193 *
194 */
195
Note: See TracBrowser for help on using the repository browser.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette