Changeset 100108 in vbox for trunk/src/VBox/Devices

Timestamp:

Jun 7, 2023 8:05:13 PM (22 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157801

Message:

*: Fix build issues when setting VBOX_WITH_WARNINGS_AS_ERRORS=1 on darwin.arm64 and make it a default, bugref:10469

Location:

trunk/src/VBox/Devices

Files:

• Audio/DrvHostAudioCoreAudio.cpp (modified) (2 diffs)
• EFI/DevSmc.cpp (modified) (1 diff)
• EFI/FirmwareBin/VBoxEFIAArch64.fd (modified) ( previous)
• EFI/VBoxSmcUtil-darwin.cpp (modified) (1 diff)
• Gpio/DevPL061.cpp (modified) (1 diff)
• Graphics/DevVGA.cpp (modified) (2 diffs)
• Misc/DevPL031.cpp (modified) (3 diffs)
• Serial/DevPL011.cpp (modified) (4 diffs)
• Storage/DrvHostBase-darwin.cpp (modified) (1 diff)
• USB/darwin/USBProxyDevice-darwin.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DrvHostAudioCoreAudio.cpp

@@ -62 +62 @@
 #include <AudioToolbox/AudioQueue.h>
 #include <AudioUnit/AudioUnit.h>
+
+
+RT_GCC_NO_WARN_DEPRECATED_BEGIN /* Much here is deprecated since 12.0 */
 
 #if MAC_OS_X_VERSION_MIN_REQUIRED < 1090 /* possibly 1080 */
@@ -2924 +2927 @@
     PDM_DRVREG_VERSION
 };
+
+RT_GCC_NO_WARN_DEPRECATED_END

trunk/src/VBox/Devices/EFI/DevSmc.cpp

@@ -543 +543 @@
     AssertReturn(cbKey >= 65, VERR_INTERNAL_ERROR);
 
+    RT_GCC_NO_WARN_DEPRECATED_BEGIN /* kIOMasterPortDefault: Deprecated since 12.0. */
     io_service_t service = IOServiceGetMatchingService(kIOMasterPortDefault,
                                                        IOServiceMatching("AppleSMC"));
+    RT_GCC_NO_WARN_DEPRECATED_END
     if (!service)
         return VERR_NOT_FOUND;

trunk/src/VBox/Devices/EFI/VBoxSmcUtil-darwin.cpp

@@ -124 +124 @@
 static int ConnectToSmc(void)
 {
-    g_hSmcService = IOServiceGetMatchingService(kIOMasterPortDefault, IOServiceMatching("AppleSMC"));
+    RT_GCC_NO_WARN_DEPRECATED_BEGIN
+    g_hSmcService = IOServiceGetMatchingService(kIOMasterPortDefault, IOServiceMatching("AppleSMC")); /* kIOMasterPortDefault: Deprecated since 12.0. */
+    RT_GCC_NO_WARN_DEPRECATED_END
     if (g_hSmcService == IO_OBJECT_NULL)
         return VERR_NOT_FOUND;

trunk/src/VBox/Devices/Gpio/DevPL061.cpp

@@ -184 +184 @@
     RT_NOREF(pvUser);
     Assert(cb == 4);
-    Assert(!(off & (cb - 1)));
+    Assert(!(off & (cb - 1))); RT_NOREF(cb);
 
     LogFlowFunc(("%RGp cb=%u\n", off, cb));

trunk/src/VBox/Devices/Graphics/DevVGA.cpp

@@ -2370 +2370 @@
          * anything wider than 2050 pixels @32bpp. Need to check all pages
          * between the first and last one. */
-        bool     fUpdate    = fFullUpdate | vgaR3IsDirty(pThis, offPage0) | vgaR3IsDirty(pThis, offPage1);
+        bool     fUpdate    = fFullUpdate || vgaR3IsDirty(pThis, offPage0) || vgaR3IsDirty(pThis, offPage1);
         if (offPage1 - offPage0 > GUEST_PAGE_SIZE)
             /* if wide line, can use another page */
@@ -2569 +2569 @@
          * anything wider than 2050 pixels @32bpp. Need to check all pages
          * between the first and last one. */
-        bool update = full_update | vgaR3IsDirty(pThis, page0) | vgaR3IsDirty(pThis, page1);
+        bool update = full_update || vgaR3IsDirty(pThis, page0) || vgaR3IsDirty(pThis, page1);
         if (page1 - page0 > GUEST_PAGE_SIZE) {
             /* if wide line, can use another page */

trunk/src/VBox/Devices/Misc/DevPL031.cpp

@@ -243 +243 @@
     NOREF(pvUser);
     Assert(cb == 4 || cb == 8);
-    Assert(!(off & (cb - 1)));
+    Assert(!(off & (cb - 1))); RT_NOREF(cb);
 
     LogFlowFunc(("%RGp cb=%u\n", off, cb));
@@ -317 +317 @@
     RT_NOREF(pvUser);
     Assert(cb == 4 || cb == 8);
-    Assert(!(off & (cb - 1)));
+    Assert(!(off & (cb - 1))); RT_NOREF(cb);
 
     VBOXSTRICTRC rcStrict = VINF_SUCCESS;
@@ -493 +493 @@
 
     Assert(iInstance < 4);
+    RT_NOREF(iInstance);
 
     /*

trunk/src/VBox/Devices/Serial/DevPL011.cpp

@@ -615 +615 @@
     NOREF(pvUser);
     Assert(cb == 4 || cb == 8);
-    Assert(!(off & (cb - 1)));
+    Assert(!(off & (cb - 1))); RT_NOREF(cb);
 
     LogFlowFunc(("%RGp cb=%u\n", off, cb));
@@ -674 +674 @@
     RT_NOREF(pvUser);
     Assert(cb == 4 || cb == 8);
-    Assert(!(off & (cb - 1)));
+    Assert(!(off & (cb - 1))); RT_NOREF(cb);
 
     VBOXSTRICTRC rcStrict = VINF_SUCCESS;
@@ -714 +714 @@
 
     /** @todo */
-    RT_NOREF(pThis);
+    RT_NOREF(pThis, cbAvail);
 
     PDMDevHlpCritSectLeave(pDevIns, pDevIns->pCritSectRoR3);
@@ -780 +780 @@
 
     /** @todo */
-    RT_NOREF(pThis);
+    RT_NOREF(pThis, fNewStatusLines);
 
     PDMDevHlpCritSectLeave(pDevIns, pDevIns->pCritSectRoR3);

trunk/src/VBox/Devices/Storage/DrvHostBase-darwin.cpp

@@ -524 +524 @@
      * Open the master port on the first invocation.
      */
-    kern_return_t krc = IOMasterPort(MACH_PORT_NULL, &pThis->Os.MasterPort);
+    RT_GCC_NO_WARN_DEPRECATED_BEGIN
+    kern_return_t krc = IOMasterPort(MACH_PORT_NULL, &pThis->Os.MasterPort); /* Deprecated since 12.0. */
+    RT_GCC_NO_WARN_DEPRECATED_END
     AssertReturn(krc == KERN_SUCCESS, VERR_GENERAL_FAILURE);
 

trunk/src/VBox/Devices/USB/darwin/USBProxyDevice-darwin.cpp

@@ -293 +293 @@
 
     int rc;
-    kern_return_t krc = IOMasterPort(MACH_PORT_NULL, &g_MasterPort);
+    RT_GCC_NO_WARN_DEPRECATED_BEGIN
+    kern_return_t krc = IOMasterPort(MACH_PORT_NULL, &g_MasterPort);  /* Deprecated since 12.0. */
+    RT_GCC_NO_WARN_DEPRECATED_END
     if (krc == KERN_SUCCESS)
     {