Changeset 100108 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Jun 7, 2023 8:05:13 PM (20 months ago)

Author:

vboxsync

Message:

*: Fix build issues when setting VBOX_WITH_WARNINGS_AS_ERRORS=1 on darwin.arm64 and make it a default, bugref:10469

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• helpbrowser/UIHelpViewer.cpp (modified) (1 diff)
• logviewer/UIVMLogViewerFilterPanel.cpp (modified) (2 diffs)
• platform/darwin/DarwinKeyboard.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/helpbrowser/UIHelpViewer.cpp

@@ -826 +826 @@
     QTextCursor cursor(pDocument);
     QTextDocument::FindFlags flags;
-    int iMatchCount = 0;
     while (!cursor.isNull() && !cursor.atEnd())
     {
         cursor = pDocument->find(searchString, cursor, flags);
         if (!cursor.isNull())
-        {
             m_matchedCursorPosition << cursor.position() - searchString.length();
-            ++iMatchCount;
-        }
     }
 }

trunk/src/VBox/Frontends/VirtualBox/src/logviewer/UIVMLogViewerFilterPanel.cpp

@@ -319 +319 @@
     /* Prepare filter-data: */
     QString strFilteredText;
-    int count = 0;
     for (int lineIdx = 0; lineIdx < stringLines.size(); ++lineIdx)
     {
@@ -326 +325 @@
             continue;
         if (applyFilterTermsToString(currentLineString))
-        {
             strFilteredText.append(currentLineString).append("\n");
-            ++count;
-        }
     }
 

trunk/src/VBox/Frontends/VirtualBox/src/platform/darwin/DarwinKeyboard.cpp

@@ -1724 +1724 @@
             rc = (*ppUsbDeviceInterface)->GetDeviceClass   (ppUsbDeviceInterface,  &idDeviceClass);    AssertMsg(rc == 0, ("Failed to get Device Class"));
             rc = (*ppUsbDeviceInterface)->GetDeviceSubClass(ppUsbDeviceInterface,  &idDeviceSubClass); AssertMsg(rc == 0, ("Failed to get Device Subclass"));
+            RT_NOREF(rc);
 
             if (idDeviceClass == kUSBHIDInterfaceClass && idDeviceSubClass == kUSBHIDBootInterfaceSubClass)
@@ -1758 +1759 @@
     if (pDictionary)
     {
-        pHidState->pNotificationPrortRef = IONotificationPortCreate(kIOMasterPortDefault);
+        RT_GCC_NO_WARN_DEPRECATED_BEGIN
+        pHidState->pNotificationPrortRef = IONotificationPortCreate(kIOMasterPortDefault); /* kIOMasterPortDefault: Deprecated since 12.0. */
+        RT_GCC_NO_WARN_DEPRECATED_END
         if (pHidState->pNotificationPrortRef)
         {