Changeset 100108 in vbox for trunk/src/VBox/Main/src-server

Timestamp:

Jun 7, 2023 8:05:13 PM (20 months ago)

Author:

vboxsync

Message:

*: Fix build issues when setting VBOX_WITH_WARNINGS_AS_ERRORS=1 on darwin.arm64 and make it a default, bugref:10469

Location:

trunk/src/VBox/Main/src-server

Files:

• HostImpl.cpp (modified) (1 diff)
• PerformanceImpl.cpp (modified) (2 diffs)
• UnattendedImpl.cpp (modified) (1 diff)
• darwin/iokit.cpp (modified) (5 diffs)

trunk/src/VBox/Main/src-server/HostImpl.cpp

@@ -1347 +1347 @@
     *aValEDX = uEDX;
 #else
+    RT_NOREF(aLeaf, aSubLeaf);
     *aValEAX = 0;
     *aValEBX = 0;

trunk/src/VBox/Main/src-server/PerformanceImpl.cpp

@@ -564 +564 @@
 
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+#ifdef LOG_ENABLED
     int n = 0;
+#endif
     BaseMetricList::iterator it;
     for (it = m.baseMetrics.begin(); it != m.baseMetrics.end(); ++it)
@@ -570 +572 @@
         {
             (*it)->unregister();
+#ifdef LOG_ENABLED
             ++n;
+#endif
         }
     Log7Func(("{%p}: obj=%p, name=%s, marked %d metrics\n", this, (void *)aObject, name.c_str(), n));

trunk/src/VBox/Main/src-server/UnattendedImpl.cpp

@@ -1763 +1763 @@
         const char *pszArch     = NULL;
         char       *psz         = pBuf->sz;
-        for (unsigned i = 0; *psz != '\0'; i++)
+        while (*psz != '\0')
         {
             while (RT_C_IS_BLANK(*psz))

trunk/src/VBox/Main/src-server/darwin/iokit.cpp

@@ -121 +121 @@
     if (!g_MasterPort)
     {
-        kern_return_t krc = IOMasterPort(MACH_PORT_NULL, &g_MasterPort);
+        RT_GCC_NO_WARN_DEPRECATED_BEGIN
+        kern_return_t krc = IOMasterPort(MACH_PORT_NULL, &g_MasterPort); /* Deprecated since 12.0. */
+        RT_GCC_NO_WARN_DEPRECATED_END
         AssertReturn(krc == KERN_SUCCESS, false);
 
@@ -1095 +1097 @@
     PUSBDEVICE pHead = NULL;
     PUSBDEVICE pTail = NULL;
-    unsigned i = 0;
     io_object_t USBDevice;
     while ((USBDevice = IOIteratorNext(USBDevices)) != IO_OBJECT_NULL)
@@ -1233 +1234 @@
 
         IOObjectRelease(USBDevice);
-        i++;
     }
 
@@ -1456 +1456 @@
     PDARWINFIXEDDRIVE pHead = NULL;
     PDARWINFIXEDDRIVE pTail = NULL;
-    unsigned i = 0;
     io_object_t MediaService;
     while ((MediaService = IOIteratorNext(MediaServices)) != IO_OBJECT_NULL)
@@ -1577 +1576 @@
         }
         IOObjectRelease(MediaService);
-        i++;
     }
     IOObjectRelease(MediaServices);