Changeset 100230 in vbox for trunk

Timestamp:

Jun 20, 2023 11:09:44 PM (22 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157940

Message:

VBox/vmm/vm.h: Corrected VMCPU_FF_HIGH_PRIORITY_POST_REPSTR_MASK to not include VMCPU_FF_PGM_SYNC_CR3 and VMCPU_FF_PGM_SYNC_CR3_NON_GLOBAL as these aren't relevant to IEM and not handled by the innermost loops, so we'd end up spinning in string instructions till something got us out to the main EM loop. bugref:10369

File:

• trunk/include/VBox/vmm/vm.h (modified) (2 diffs)

trunk/include/VBox/vmm/vm.h

@@ -669 +669 @@
 /** VMCPU flags that cause the REP[|NE|E] STRINS loops to yield immediately. */
 #ifdef IN_RING3
-# define VMCPU_FF_HIGH_PRIORITY_POST_REPSTR_MASK (  VMCPU_FF_PGM_SYNC_CR3 | VMCPU_FF_PGM_SYNC_CR3_NON_GLOBAL | VMCPU_FF_DBGF \
-                                                  | VMCPU_FF_VMX_MTF )
-#else
-# define VMCPU_FF_HIGH_PRIORITY_POST_REPSTR_MASK (  VMCPU_FF_TO_R3 | VMCPU_FF_IEM | VMCPU_FF_IOM | VMCPU_FF_PGM_SYNC_CR3 \
-                                                  | VMCPU_FF_PGM_SYNC_CR3_NON_GLOBAL | VMCPU_FF_DBGF | VMCPU_FF_VMX_MTF )
+# define VMCPU_FF_HIGH_PRIORITY_POST_REPSTR_MASK (VMCPU_FF_DBGF | VMCPU_FF_VMX_MTF)
+#else
+# define VMCPU_FF_HIGH_PRIORITY_POST_REPSTR_MASK (VMCPU_FF_TO_R3 | VMCPU_FF_IEM | VMCPU_FF_IOM | VMCPU_FF_DBGF | VMCPU_FF_VMX_MTF)
 #endif
 
@@ -727 +725 @@
  * assisted execution. */
 #define VMCPU_FF_ALL_REM_MASK                   (~(VMCPU_FF_HIGH_PRIORITY_PRE_RAW_MASK | VMCPU_FF_PDM_CRITSECT | VMCPU_FF_TLB_FLUSH))
+
+#ifndef VBOX_FOR_DTRACE_LIB
+AssertCompile(  ((VM_FF_HIGH_PRIORITY_POST_REPSTR_MASK | VM_FF_YIELD_REPSTR_MASK)
+               & (VM_FF_HIGH_PRIORITY_PRE_RAW_MASK & ~VM_FF_ALL_REM_MASK)) == 0);
+AssertCompile((VMCPU_FF_HIGH_PRIORITY_POST_REPSTR_MASK & (VMCPU_FF_HIGH_PRIORITY_PRE_RAW_MASK & ~VMCPU_FF_ALL_REM_MASK)) == 0);
+#endif
+
 /** @} */