Changeset 100238 in vbox for trunk

Timestamp:

Jun 21, 2023 1:05:35 PM (18 months ago)

Author:

vboxsync

Message:

Shared Clipboard: ShClTransferHttpServerStart() now complies to RFC 6335 (IANA) wrt dynamic port ranges. bugref:9437

File:

• trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers-http.cpp (modified) (3 diffs)

trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers-http.cpp

@@ -601 +601 @@
 
 /**
- * Starts the Shared Clipboard HTTP server instance using a random port (>= 1024).
+ * Starts the Shared Clipboard HTTP server instance using a random port (>= 49152).
  *
  * This does automatic probing of TCP ports if a port already is being used.
@@ -609 +609 @@
  * @param   cMaxAttempts        Maximum number of attempts to create a HTTP server.
  * @param   puPort              Where to return the TCP port number being used on success. Optional.
+ *
+ * @note    Complies with RFC 6335 (IANA).
  */
 int ShClTransferHttpServerStart(PSHCLHTTPSERVER pSrv, unsigned cMaxAttempts, uint16_t *puPort)
@@ -624 +626 @@
         for (i; i < cMaxAttempts; i++)
         {
-            /* Try some random ports above 1024 (i.e. "unprivileged ports") -- required, as VBoxClient runs as a user process
-             * on the guest. */
-            uPort = RTRandAdvU32Ex(hRand, 1024, UINT16_MAX);
+            /* Try some random ports >= 49152 (i.e. "dynamic ports", see RFC 6335)
+             * -- required, as VBoxClient runs as a user process on the guest. */
+            uPort = RTRandAdvU32Ex(hRand, 49152, UINT16_MAX);
 
             /* If the port selected turns is known to be buggy for whatever reason, skip it and try another one. */