Changeset 100305 in vbox

Timestamp:

Jun 27, 2023 10:25:44 PM (22 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

158020

Message:

VMM/IEM: Added missing VM_FF checks and timer polling (TMTimerPollBool) to the IEMExecRecompilerThreaded loop. This fixes slow interrupt deliver and whatnot. bugref:10369

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllThreadedRecompiler.cpp (modified) (6 diffs)
• VMMR3/IEMR3.cpp (modified) (1 diff)
• include/IEMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllThreadedRecompiler.cpp

@@ -169 +169 @@
         struct
         {
+            /** The call sequence table. */
+            PIEMTHRDEDCALLENTRY paCalls;
             /** Number of calls in paCalls. */
             uint16_t            cCalls;
             /** Number of calls allocated. */
             uint16_t            cAllocated;
-            /** The call sequence table. */
-            PIEMTHRDEDCALLENTRY paCalls;
         } Thrd;
     };
@@ -1047 +1047 @@
             pTb->cbOpcodes += pVCpu->iem.s.offOpcode;
             Assert(pTb->cbOpcodes <= pTb->cbOpcodesAllocated);
+            pVCpu->iem.s.cInstructions++;
         }
         else if (pTb->Thrd.cCalls > 0)
@@ -1057 +1058 @@
                 pTb->cbOpcodes += pVCpu->iem.s.offOpcode;
                 Assert(pTb->cbOpcodes <= pTb->cbOpcodesAllocated);
+                pVCpu->iem.s.cInstructions++;
             }
             break;
@@ -1117 +1119 @@
     /* Set the current TB so CIMPL function may get at it. */
     pVCpu->iem.s.pCurTbR3 = pTb;
+    pVCpu->iem.s.cTbExec++;
 
     /* The execution loop. */
@@ -1258 +1261 @@
         IEM_TRY_SETJMP(pVCpu, rcStrict)
         {
-            for (;;)
+            uint32_t const cPollRate = 511; /* EM.cpp passes 4095 to IEMExecLots, so an eigth of that seems reasonable for now. */
+            for (uint32_t iIterations = 0; ; iIterations++)
             {
                 /* Translate PC to physical address, we'll need this for both lookup and compilation. */
@@ -1278 +1282 @@
                                                   | VMCPU_FF_TLB_FLUSH
                                                   | VMCPU_FF_UNHALT );
-                    if (!fCpu)
+                    if (RT_LIKELY(   (   !fCpu
+                                      || (   !(fCpu & ~(VMCPU_FF_INTERRUPT_APIC | VMCPU_FF_INTERRUPT_PIC))
+                                          && !pVCpu->cpum.GstCtx.rflags.Bits.u1IF) )
+                                  && !VM_FF_IS_ANY_SET(pVM, VM_FF_ALL_MASK) ))
                     {
-                        /* likely */
+                        if (RT_LIKELY(   (iIterations & cPollRate) != 0
+                                      || !TMTimerPollBool(pVM, pVCpu)))
+                        {
+
+                        }
+                        else
+                            return VINF_SUCCESS;
                     }
                     else

trunk/src/VBox/VMM/VMMR3/IEMR3.cpp

@@ -169 +169 @@
 
 #ifdef VBOX_WITH_IEM_RECOMPILER
+        STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.cTbExec,             STAMTYPE_U64_RESET, STAMVISIBILITY_ALWAYS, STAMUNIT_NONE,
+                        "Executed translation block",               "/IEM/CPU%u/cTbExec", idCpu);
         STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.cTbAllocs,           STAMTYPE_U64,       STAMVISIBILITY_ALWAYS, STAMUNIT_NONE,
                         "Translation block allocations",            "/IEM/CPU%u/cTbAllocs", idCpu);
         STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.cTbFrees,            STAMTYPE_U64,       STAMVISIBILITY_ALWAYS, STAMUNIT_NONE,
                         "Translation block frees",                  "/IEM/CPU%u/cTbFrees", idCpu);
-        STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.cTbLookupHits,       STAMTYPE_U64,       STAMVISIBILITY_ALWAYS, STAMUNIT_NONE,
+        STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.cTbLookupHits,       STAMTYPE_U64_RESET, STAMVISIBILITY_ALWAYS, STAMUNIT_NONE,
                         "Translation block lookup hits",            "/IEM/CPU%u/cTbLookupHits", idCpu);
-        STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.cTbLookupMisses, STAMTYPE_U64,       STAMVISIBILITY_ALWAYS, STAMUNIT_NONE,
+        STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.cTbLookupMisses,     STAMTYPE_U64_RESET, STAMVISIBILITY_ALWAYS, STAMUNIT_NONE,
                         "Translation block lookup misses",          "/IEM/CPU%u/cTbLookupMisses", idCpu);
 #endif

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -1012 +1012 @@
     /** Statistics: Number of TB lookup hits (debug only). */
     uint64_t                cTbLookupHits;
+    /** Number of TBs executed. */
+    uint64_t                cTbExec;
     /** Whether to end the current TB. */
     bool                    fEndTb;
     /** Spaced reserved for recompiler data / alignment. */
     bool                    afRecompilerStuff1[7];
-    /** Spaced reserved for recompiler data / alignment. */
-    uint64_t                auRecompilerStuff2[1];
     /** @} */