Changeset 100327 in vbox

Timestamp:

Jun 29, 2023 12:11:46 AM (17 months ago)

Author:

vboxsync

Message:

VMM/IEM: Corrected missing rcPassUp checks and iemExecStatusCodeFiddling. bugref:10369

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllThreadedRecompiler.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllThreadedRecompiler.cpp

@@ -1039 +1039 @@
         rcStrict = FNIEMOP_CALL(g_apfnIemThreadedRecompilerOneByteMap[b]);
         if (   rcStrict == VINF_SUCCESS
+            && pVCpu->iem.s.rcPassUp == VINF_SUCCESS
             && !pVCpu->iem.s.fEndTb)
         {
@@ -1067 +1068 @@
             pVCpu->iem.s.pCurTbR3 = NULL;
             iemThreadedTbFree(pVM, pVCpu, pTb);
-            return rcStrict;
+            return iemExecStatusCodeFiddling(pVCpu, rcStrict);
         }
 
@@ -1093 +1094 @@
 #endif
 
-    return rcStrict;
+    return iemExecStatusCodeFiddling(pVCpu, rcStrict);
 }
 
@@ -1135 +1136 @@
                                                                                           pCallEntry->auParams[1],
                                                                                           pCallEntry->auParams[2]);
-        if (RT_LIKELY(rcStrict == VINF_SUCCESS))
+
+        if (RT_LIKELY(   rcStrict == VINF_SUCCESS
+                      && pVCpu->iem.s.rcPassUp == VINF_SUCCESS /** @todo this isn't great. */))
             pCallEntry++;
         else
@@ -1144 +1147 @@
                continue in a different translation block. */
             if (rcStrict == VINF_IEM_REEXEC_MODE_CHANGED)
-                return VINF_SUCCESS;
-            return rcStrict;
+                return iemExecStatusCodeFiddling(pVCpu, VINF_SUCCESS);
+            return iemExecStatusCodeFiddling(pVCpu, rcStrict);
         }
     }