Changeset 100447 in vbox

Timestamp:

Jul 8, 2023 6:50:27 PM (17 months ago)

Author:

vboxsync

Message:

IPRT,OpenSSL: Support ECDSA for verficiation purposes when IPRT links with OpenSSL. This required quite a bit of cleanups, so not entirely no-risk. [build fix for older OpenSSL] bugref:10479 ticketref:21621

Location:

trunk

Files:

• include/iprt/err.h (modified) (1 diff)
• src/VBox/Runtime/common/crypto/key-openssl.cpp (modified) (1 diff)
• src/VBox/Runtime/common/crypto/pkix-signature-ossl.cpp (modified) (2 diffs)

trunk/include/iprt/err.h

@@ -2270 +2270 @@
 /** @name RTCr misc status codes.
  * @{ */
+/** The OpenSSL version is too old for the attempted operation. */
+#define VERR_CR_OPENSSL_VERSION_TOO_OLD             (-24395)
 /** Failed to derivate key from password. */
 #define VERR_CR_PASSWORD_2_KEY_DERIVIATION_FAILED   (-24396)

trunk/src/VBox/Runtime/common/crypto/key-openssl.cpp

@@ -95 +95 @@
          *        with older openssl versions atm.  Fortunately we only really needs
          *        it on Windows atm., so no problem. */
-        rc = RTERRINFO_LOG_SET_F(pErrInfo, VERR_NOT_SUPPORTED,
+        rc = RTERRINFO_LOG_SET_F(pErrInfo, VERR_CR_OPENSSL_VERSION_TOO_OLD,
                                  "OpenSSL version %#x is too old for IPRTs ECDSA code", OPENSSL_VERSION_NUMBER);
+        RT_NOREF(idKeyType, ppEvpNewKey);
 #endif
     }

trunk/src/VBox/Runtime/common/crypto/pkix-signature-ossl.cpp

@@ -151 +151 @@
     RT_NOREF_PV(pThis);
 
-#if 1
+#if OPENSSL_VERSION_NUMBER >= 0x30000000 && !defined(LIBRESSL_VERSION_NUMBER)
     PRTERRINFO const pErrInfo = NULL;
 
@@ -220 +220 @@
 #else
     RT_NOREF(pDesc, pvState, hKey, hDigest, pvSignature, cbSignature);
-    return VERR_NOT_IMPLEMENTED;
+    return VERR_CR_OPENSSL_VERSION_TOO_OLD;
 #endif
 }