Changeset 100459 in vbox

Timestamp:

Jul 10, 2023 1:54:55 PM (17 months ago)

Author:

vboxsync

Message:

Installer/darwin, Additions/darwin/Installer: Make sure the KEXT bundle signature is readable, even if code signing creates it as non-world readable (which before meant that pkgbuild silently left it out, because user vbox can't read such files owned by root:wheel).

Location:

trunk/src/VBox

Files:

• Additions/darwin/Installer/Makefile.kmk (modified) (1 diff)
• Installer/darwin/Makefile.kmk (modified) (1 diff)

trunk/src/VBox/Additions/darwin/Installer/Makefile.kmk

@@ -269 +269 @@
                 $(NLTAB)$(INSTALL) -m 0755 $(VBOX_PATH_DIST)/additions/$(kext).kext/Contents/MacOS/$(kext) $(VBOX_PATH_PACK_TMP)/VBoxGuestAdditionsKEXTs.pkg.root/Library/Extensions/$(kext).kext/Contents/MacOS/)
 endif
-        @# Signed the kext bundles.
+        @# Sign the kext bundles.
 ifdef VBOX_SIGNING_MODE
         $(foreach kext,$(VBOX_ADD_DI_KEXTS), \
-                $(NLTAB)$(call VBOX_SIGN_BUNDLE_FN,$(VBOX_PATH_PACK_TMP)/VBoxGuestAdditionsKEXTs.pkg.root/Library/Extensions/$(kext).kext,) )
+                $(NLTAB)$(call VBOX_SIGN_BUNDLE_FN,$(VBOX_PATH_PACK_TMP)/VBoxGuestAdditionsKEXTs.pkg.root/Library/Extensions/$(kext).kext,) \
+                $(NLTAB)chmod a+r $(VBOX_PATH_PACK_TMP)/VBoxGuestAdditionsKEXTs.pkg.root/Library/Extensions/$(kext).kext/Contents/_CodeSignature/* )
 endif
         @# Set the correct owners.

trunk/src/VBox/Installer/darwin/Makefile.kmk

@@ -339 +339 @@
                 ,$(NLTAB)$(call VBOX_SIGN_MACHO_FN,$(VBOX_PATH_PACK_TMP)/VBoxKEXTs.pkg.root/$(kext).kext/Contents/MacOS/$(kext),org.virtualbox.app.kext.$(kext)) )
         $(foreach kext,$(VBOX_DI_KEXTS) \
-                ,$(NLTAB)$(call VBOX_SIGN_BUNDLE_FN,$(VBOX_PATH_PACK_TMP)/VBoxKEXTs.pkg.root/$(kext).kext,org.virtualbox.app.kext.$(kext)) )
+                ,$(NLTAB)$(call VBOX_SIGN_BUNDLE_FN,$(VBOX_PATH_PACK_TMP)/VBoxKEXTs.pkg.root/$(kext).kext,org.virtualbox.app.kext.$(kext)) \
+                $(NLTAB)chmod a+r $(VBOX_PATH_PACK_TMP)/VBoxKEXTs.pkg.root/$(kext).kext/Contents/_CodeSignature/* )
   ## @TODO check why this fails on the build box:       $(foreach kext,$(VBOX_DI_KEXTS), $(NLTAB)codesign --verify --verbose=1 $(VBOX_PATH_PACK_TMP)/VBoxKEXTs.pkg.root/$(kext).kext )
  endif