Changeset 100470 in vbox for trunk/src/VBox

Timestamp:

Jul 10, 2023 3:18:12 PM (17 months ago)

Author:

vboxsync

Message:

Shared Clipboard: Fixed returning list handle for VBOX_SHCL_GUEST_FN_LIST_OPEN, plus added more checks. bugref:9437

File:

• trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc-transfers.cpp (modified) (2 diffs)

trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc-transfers.cpp

@@ -1776 +1776 @@
         case VBOX_SHCL_GUEST_FN_LIST_OPEN:
         {
+            if (cParms != VBOX_SHCL_CPARMS_LIST_OPEN)
+                break;
+
+            ASSERT_GUEST_RETURN(aParms[1].type == VBOX_HGCM_SVC_PARM_32BIT, VERR_WRONG_PARAMETER_TYPE); /* List flags */
+            ASSERT_GUEST_RETURN(aParms[2].type == VBOX_HGCM_SVC_PARM_PTR,   VERR_WRONG_PARAMETER_TYPE); /* Filter string */
+            ASSERT_GUEST_RETURN(aParms[3].type == VBOX_HGCM_SVC_PARM_PTR,   VERR_WRONG_PARAMETER_TYPE); /* Path */
+            ASSERT_GUEST_RETURN(aParms[4].type == VBOX_HGCM_SVC_PARM_64BIT, VERR_WRONG_PARAMETER_TYPE); /* List handle (output) */
+
             SHCLLISTOPENPARMS listOpenParms;
             rc = shClSvcTransferGetListOpen(cParms, aParms, &listOpenParms);
@@ -1785 +1793 @@
                 {
                     /* Return list handle. */
-                    HGCMSvcSetU64(&aParms[6], hList);
+                    HGCMSvcSetU64(&aParms[4], hList);
                 }
             }