Changeset 100481 in vbox

Timestamp:

Jul 10, 2023 4:56:48 PM (17 months ago)

Author:

vboxsync

Message:

Shared Clipboard: Some more (optional / verbose release) logging. bugref:9437

File:

• trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers.cpp (modified) (10 diffs)

trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers.cpp

@@ -680 +680 @@
     AssertPtrReturn(pListEntry, false);
 
-    if (!shclTransferListEntryNameIsValid(pListEntry->pszName, pListEntry->cbName))
-        return false;
-
-    if (pListEntry->cbInfo) /* cbInfo / pvInfo is optional. */
-    {
-        if (!pListEntry->pvInfo)
-            return false;
-    }
-
-    return true;
+    bool fValid = false;
+
+    if (shclTransferListEntryNameIsValid(pListEntry->pszName, pListEntry->cbName))
+    {
+        fValid =    pListEntry->cbInfo == 0 /* cbInfo / pvInfo is optional. */
+                 || pListEntry->pvInfo != NULL;
+    }
+
+    if (!fValid)
+        LogRel2(("Shared Clipboard: List entry '%s' is invalid\n", pListEntry->pszName));
+
+    return fValid;
 }
 
@@ -897 +899 @@
         rc = VERR_NOT_SUPPORTED;
 
+    if (RT_FAILURE(rc))
+         LogRel(("Shared Clipboard: Opening object '%s' (flags %#x) failed with %Rrc\n",
+                 pOpenCreateParms->pszPath, pOpenCreateParms->fCreate, rc));
+
     LogFlowFuncLeaveRC(rc);
     return rc;
@@ -917 +923 @@
     else
         rc = VERR_NOT_SUPPORTED;
+
+    if (RT_FAILURE(rc))
+        LogRel(("Shared Clipboard: Reading object 0x%x failed with %Rrc\n", hObj, rc));
 
     LogFlowFuncLeaveRC(rc);
@@ -948 +957 @@
         rc = VERR_NOT_SUPPORTED;
 
+    if (RT_FAILURE(rc))
+        LogRel(("Shared Clipboard: Reading object 0x%x failed with %Rrc\n", hObj, rc));
+
     LogFlowFuncLeaveRC(rc);
     return rc;
@@ -976 +988 @@
     else
         rc = VERR_NOT_SUPPORTED;
+
+    if (RT_FAILURE(rc))
+        LogRel(("Shared Clipboard: Writing object 0x%x failed with %Rrc\n", hObj, rc));
 
     LogFlowFuncLeaveRC(rc);
@@ -1303 +1318 @@
         rc = VERR_NOT_SUPPORTED;
 
+    if (RT_FAILURE(rc))
+         LogRel(("Shared Clipboard: Opening list '%s' (fiter '%s', flags %#x) failed with %Rrc\n",
+                 pOpenParms->pszPath, pOpenParms->pszFilter, pOpenParms->fList, rc));
+
     LogFlowFuncLeaveRC(rc);
     return rc;
@@ -1327 +1346 @@
         rc = VERR_NOT_SUPPORTED;
 
+    if (RT_FAILURE(rc))
+        LogRel(("Shared Clipboard: Closing list 0x%x entry failed with %Rrc\n", hList, rc));
+
     LogFlowFuncLeaveRC(rc);
     return rc;
@@ -1353 +1375 @@
         rc = VERR_NOT_SUPPORTED;
 
+    if (RT_FAILURE(rc))
+        LogRel(("Shared Clipboard: Reading list header list 0x%x entry failed with %Rrc\n", hList, rc));
+
     LogFlowFuncLeaveRC(rc);
     return rc;
@@ -1420 +1445 @@
         rc = VERR_NOT_SUPPORTED;
 
+    if (RT_FAILURE(rc))
+        LogRel(("Shared Clipboard: Reading list for list 0x%x entry failed with %Rrc\n", hList, rc));
+
     LogFlowFuncLeaveRC(rc);
     return rc;
@@ -1443 +1471 @@
         rc = pTransfer->ProviderIface.pfnListEntryWrite(&pTransfer->ProviderCtx, hList, pEntry);
 #endif
+
+    if (RT_FAILURE(rc))
+        LogRel(("Shared Clipboard: Writing list entry to list 0x%x failed with %Rrc\n", hList, rc));
 
     LogFlowFuncLeaveRC(rc);