Changeset 100671 in vbox

Timestamp:

Jul 21, 2023 12:28:24 AM (20 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

158511

Message:

VMM/IEM: Fix TB revalidation prior to execution. The code is still incomplete, though. bugref:10369

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllThreadedRecompiler.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllThreadedRecompiler.cpp

@@ -1108 +1108 @@
 static VBOXSTRICTRC iemThreadedTbExec(PVMCPUCC pVCpu, PIEMTB pTb)
 {
-    if (memcmp(pTb->pabOpcodes, &pVCpu->iem.s.pbInstrBuf[pVCpu->iem.s.offInstrNextByte],
-               RT_MIN(pTb->cbOpcodes, pVCpu->iem.s.cbInstrBuf - pVCpu->iem.s.offInstrNextByte)) == 0)
-    { /* likely */ }
+    /* Check the opcodes in the first page before starting execution. */
+    uint32_t const cbLeadOpcodes = RT_MIN(pTb->cbOpcodes, pVCpu->iem.s.cbInstrBufTotal - pVCpu->iem.s.offInstrNextByte);
+    if (memcmp(pTb->pabOpcodes, &pVCpu->iem.s.pbInstrBuf[pVCpu->iem.s.offInstrNextByte], cbLeadOpcodes) == 0)
+        Assert(   pTb->cbOpcodes == cbLeadOpcodes
+               || cbLeadOpcodes == (GUEST_PAGE_SIZE - (pTb->GCPhysPc & GUEST_PAGE_OFFSET_MASK)));
     else
     {