Changeset 100734 in vbox for trunk/src/VBox/VMM/include

Timestamp:

Jul 29, 2023 2:04:22 AM (20 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

158604

Message:

VMM/IEM: Generate TBs for invalid instruction encodings as well. This involved special casing recompiler call generation for C instruction implementation function that doesn't take any extra arguments, so that we can catch all the deeply hidden IEMOP_RAISE_INVALID_OPCODE_RET invocations and similar. Also had to clean up hacky decoding of effective address related opcode bytes for undefined opcodes, introducing IEM_OPCODE_SKIP_RM_EFF_ADDR_BYTES(a_bRm) to hide the uglyness. bugref:10369

Location:

trunk/src/VBox/VMM/include

Files:

• IEMInline.h (modified) (1 diff)
• IEMInternal.h (modified) (4 diffs)

trunk/src/VBox/VMM/include/IEMInline.h

@@ -1456 +1456 @@
 # endif
 
+/**
+ * For fetching the opcode bytes for an ModR/M effective address, but throw
+ * away the result.
+ *
+ * This is used when decoding undefined opcodes and such where we want to avoid
+ * unnecessary MC blocks.
+ *
+ * @note The recompiler code overrides this one so iemOpHlpCalcRmEffAddrJmpEx is
+ *       used instead.  At least for now...
+ */
+# ifndef IEM_WITH_SETJMP
+#  define IEM_OPCODE_SKIP_RM_EFF_ADDR_BYTES(a_bRm) do { \
+        RTGCPTR      GCPtrEff; \
+        VBOXSTRICTRC rcStrict = iemOpHlpCalcRmEffAddr(pVCpu, bRm, 0, &GCPtrEff); \
+        if (rcStrict != VINF_SUCCESS) \
+            return rcStrict; \
+    } while (0)
+# else
+#  define IEM_OPCODE_SKIP_RM_EFF_ADDR_BYTES(a_bRm) do { \
+        (void)iemOpHlpCalcRmEffAddrJmp(pVCpu, bRm, 0); \
+    } while (0)
+# endif
+
 #endif /* !IEM_WITH_OPAQUE_DECODER_STATE */
 

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -3492 +3492 @@
 # define IEM_CIMPL_CALL_0(a_fn)            a_fn(pVCpu, cbInstr)
 
+/** Type for a C instruction implementation function taking no extra
+ *  arguments. */
+typedef IEM_CIMPL_DECL_TYPE_0(FNIEMCIMPL0);
+/** Function pointer type for a C instruction implementation function taking
+ *  no extra arguments. */
+typedef FNIEMCIMPL0 *PFNIEMCIMPL0;
+
 /**
  * For typedef'ing or declaring a C instruction implementation function taking
@@ -4399 +4406 @@
  * Macro for calling iemCImplRaiseDivideError().
  *
- * This enables us to add/remove arguments and force different levels of
- * inlining as we wish.
+ * This is for things that will _always_ decode to an \#DE, taking the
+ * recompiler into consideration and everything.
  *
  * @return  Strict VBox status code.
@@ -4409 +4416 @@
  * Macro for calling iemCImplRaiseInvalidLockPrefix().
  *
- * This enables us to add/remove arguments and force different levels of
- * inlining as we wish.
+ * This is for things that will _always_ decode to an \#UD, taking the
+ * recompiler into consideration and everything.
  *
  * @return  Strict VBox status code.
@@ -4943 +4950 @@
 void            iemThreadedTbObsolete(PVMCPUCC pVCpu, PIEMTB pTb);
 
+IEM_DECL_IMPL_PROTO(VBOXSTRICTRC, iemThreadedFunc_BltIn_DeferToCImpl0,
+                    (PVMCPU pVCpu, uint64_t uParam0, uint64_t uParam1, uint64_t uParam2));
+
 IEM_DECL_IMPL_PROTO(VBOXSTRICTRC, iemThreadedFunc_BltIn_CheckMode,
                     (PVMCPU pVCpu, uint64_t uParam0, uint64_t uParam1, uint64_t uParam2));