Changeset 100772 in vbox for trunk/include

Timestamp:

Aug 1, 2023 5:34:48 PM (17 months ago)

Author:

vboxsync

Message:

include/VBox/usbfilter.h,HostDrivers/VBoxUSB/USBFilter: IUSBDeviceFilter:
USB device interval filters don't work. bugref:10452

Main/Host,Main/USBDeviceFilter: Adding or removing global USB device
filters causes memory corruption wihch can lead to a deadlock or a SEGV
as the list of global USB device filters (llChildren) changes while
the list is being walked.

Frontends/VBoxManage: 'VBoxManage list usbfilters' doesn't display the
'Port' value of the device filter.

Frontends/VBoxManage: 'VBoxManage add usbfilter' and 'VBoxManage modify
usbfilter' both ignore the --product="Value" option.

Main/VirtualBox.xidl: Improve the IUSBDeviceFilter wording to make
things clearer in the 'VirtualBox Programming Guide and Reference Guide'
aka SDKRef.pdf.

HostDrivers/VBoxUSB/testcase/tstUSBFilter: Include a variety of USB
device filter entries which include the 'int:' prefix to fully exercise
the interval filter parsing code.

Location:

trunk/include

Files:

• VBox/usbfilter.h (modified) (2 diffs)
• iprt/err.h (modified) (1 diff)

trunk/include/VBox/usbfilter.h

@@ -73 +73 @@
     /** Numeric Field: Exact match or not present. */
     USBFILTERMATCH_NUM_EXACT_NP,
-    /** Numeric Field: Expression match, required to be present.
-     * The expression is represented as a string. */
-    USBFILTERMATCH_NUM_EXPRESSION,
-    /** Numeric Field: Expression match or not present.
-     * The expression is represented as a string. */
-    USBFILTERMATCH_NUM_EXPRESSION_NP,
     /** Numeric Field: The last numeric field matching method (inclusive). */
-    USBFILTERMATCH_NUM_LAST = USBFILTERMATCH_NUM_EXPRESSION_NP,
+    USBFILTERMATCH_NUM_LAST = USBFILTERMATCH_NUM_EXACT_NP,
 
     /** String Field: The first string field matching method. */
@@ -92 +86 @@
     /** String Field: Pattern match or not present.*/
     USBFILTERMATCH_STR_PATTERN_NP,
+    /** String Field: Numerical expression match, required to be present. */
+    USBFILTERMATCH_NUM_EXPRESSION,
+    /** String Field: Numerical expression match or not present. */
+    USBFILTERMATCH_NUM_EXPRESSION_NP,
     /** String Field: The last string field matching method (inclusive). */
-    USBFILTERMATCH_STR_LAST = USBFILTERMATCH_STR_PATTERN_NP,
+    USBFILTERMATCH_STR_LAST = USBFILTERMATCH_NUM_EXPRESSION_NP,
 
     /** The end of valid matching methods (exclusive). */

trunk/include/iprt/err.h

@@ -211 +211 @@
 /** A numeric conversion encountered a value which was too big for the target. */
 #define VWRN_NUMBER_TOO_BIG                 55
-/** The number begin converted (string) contained no digits. */
+/** The number being converted (string) contained no digits. */
 #define VERR_NO_DIGITS                      (-56)
-/** The number begin converted (string) contained no digits. */
+/** The number being converted (string) contained no digits. */
 #define VWRN_NO_DIGITS                      56
 /** Encountered a '-' during conversion to an unsigned value. */