Changeset 100772 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Aug 1, 2023 5:34:48 PM (19 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

158650

Message:

include/VBox/usbfilter.h,HostDrivers/VBoxUSB/USBFilter: IUSBDeviceFilter:
USB device interval filters don't work. bugref:10452

Main/Host,Main/USBDeviceFilter: Adding or removing global USB device
filters causes memory corruption wihch can lead to a deadlock or a SEGV
as the list of global USB device filters (llChildren) changes while
the list is being walked.

Frontends/VBoxManage: 'VBoxManage list usbfilters' doesn't display the
'Port' value of the device filter.

Frontends/VBoxManage: 'VBoxManage add usbfilter' and 'VBoxManage modify
usbfilter' both ignore the --product="Value" option.

Main/VirtualBox.xidl: Improve the IUSBDeviceFilter wording to make
things clearer in the 'VirtualBox Programming Guide and Reference Guide'
aka SDKRef.pdf.

HostDrivers/VBoxUSB/testcase/tstUSBFilter: Include a variety of USB
device filter entries which include the 'int:' prefix to fully exercise
the interval filter parsing code.

Location:

trunk/src/VBox/Frontends/VBoxManage

Files:

• VBoxManageList.cpp (modified) (1 diff)
• VBoxManageUSB.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageList.cpp

@@ -712 +712 @@
             RTPrintf(List::tr("Product:          %ls\n"), bstr.raw());
             CHECK_ERROR_RET(flt, COMGETTER(SerialNumber)(bstr.asOutParam()), 1);
-            RTPrintf(List::tr("Serial Number:    %ls\n\n"), bstr.raw());
+            RTPrintf(List::tr("Serial Number:    %ls\n"), bstr.raw());
+            CHECK_ERROR_RET(flt, COMGETTER(Port)(bstr.asOutParam()), 1);
+            RTPrintf(List::tr("Port:             %ls\n\n"), bstr.raw());
         }
     }

trunk/src/VBox/Frontends/VBoxManage/VBoxManageUSB.cpp

@@ -455 +455 @@
                 if (!f.mManufacturer.isEmpty())
                     CHECK_ERROR_BREAK(flt, COMSETTER(Manufacturer)(f.mManufacturer.raw()));
+                if (!f.mProduct.isEmpty())
+                    CHECK_ERROR_BREAK(flt, COMSETTER(Product)(f.mProduct.raw()));
                 if (!f.mPort.isEmpty())
                     CHECK_ERROR_BREAK(flt, COMSETTER(Port)(f.mPort.raw()));
@@ -483 +485 @@
                 if (!f.mManufacturer.isEmpty())
                     CHECK_ERROR_BREAK(flt, COMSETTER(Manufacturer)(f.mManufacturer.raw()));
+                if (!f.mProduct.isEmpty())
+                    CHECK_ERROR_BREAK(flt, COMSETTER(Product)(f.mProduct.raw()));
                 if (!f.mPort.isEmpty())
                     CHECK_ERROR_BREAK(flt, COMSETTER(Port)(f.mPort.raw()));
@@ -517 +521 @@
                 if (!f.mManufacturer.isEmpty())
                     CHECK_ERROR_BREAK(flt, COMSETTER(Manufacturer)(f.mManufacturer.raw()));
+                if (!f.mProduct.isEmpty())
+                    CHECK_ERROR_BREAK(flt, COMSETTER(Product)(f.mProduct.raw()));
                 if (!f.mPort.isEmpty())
                     CHECK_ERROR_BREAK(flt, COMSETTER(Port)(f.mPort.raw()));
@@ -546 +552 @@
                 if (!f.mManufacturer.isEmpty())
                     CHECK_ERROR_BREAK(flt, COMSETTER(Manufacturer)(f.mManufacturer.raw()));
+                if (!f.mProduct.isEmpty())
+                    CHECK_ERROR_BREAK(flt, COMSETTER(Product)(f.mProduct.raw()));
                 if (!f.mPort.isEmpty())
                     CHECK_ERROR_BREAK(flt, COMSETTER(Port)(f.mPort.raw()));