Changeset 100861 in vbox for trunk/src

Timestamp:

Aug 11, 2023 3:38:01 PM (18 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10500: Initial implementation for cloud VM clone functionality; This isn't working for now since ICloudMachine has only id, but not ocid property accessible.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UICloudNetworkingStuff.cpp (modified) (1 diff)
• globals/UICloudNetworkingStuff.h (modified) (1 diff)
• manager/UIVirtualBoxManager.cpp (modified) (6 diffs)
• manager/chooser/UIChooserModel.cpp (modified) (1 diff)
• notificationcenter/UINotificationObjects.cpp (modified) (1 diff)
• notificationcenter/UINotificationObjects.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICloudNetworkingStuff.cpp

@@ -603 +603 @@
     return pParent->handleNow(pNotification);
 }
+
+void UICloudNetworkingStuff::createCloudMachineClone(const QString &strProviderShortName,
+                                                     const QString &strProfileName,
+                                                     const CCloudMachine &comCloudMachine,
+                                                     const QString &strCloneName,
+                                                     UINotificationCenter *pParent)
+{
+    /* Create cloud client: */
+    CCloudClient comCloudClient = cloudClientByName(strProviderShortName,
+                                                    strProfileName,
+                                                    pParent);
+    if (comCloudClient.isNotNull())
+    {
+        /* Clone specified cloud machine asynchronously: */
+        UINotificationProgressCloudMachineClone *pNotification =
+            new UINotificationProgressCloudMachineClone(comCloudClient, comCloudMachine, strCloneName);
+        pParent->append(pNotification);
+    }
+}

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICloudNetworkingStuff.h

@@ -184 +184 @@
                                                             const CForm &comForm,
                                                             UINotificationCenter *pParent);
+
+    /** Creates cloud machine clone.
+      * @param  strProviderShortName  Brings short provider name.
+      * @param  strProfileName        Brings profile name.
+      * @param  comCloudMachine       Brings cloud machine instance of which being cloned.
+      * @param  strCloneName          Brings clone name.
+      * @param  pParent               Brings notification-center reference. */
+    SHARED_LIBRARY_STUFF void createCloudMachineClone(const QString &strProviderShortName,
+                                                      const QString &strProfileName,
+                                                      const CCloudMachine &comCloudMachine,
+                                                      const QString &strCloneName,
+                                                      UINotificationCenter *pParent);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManager.cpp

@@ -50 +50 @@
 #include "QIDialogButtonBox.h"
 #include "QIFileDialog.h"
+#include "QILineEdit.h"
 #include "QIRichTextLabel.h"
 #include "UIActionPoolManager.h"
@@ -169 +170 @@
 };
 
+/** QDialog extension used to ask for a cloud machine clone name. */
+class UIAcquireCloudMachineCloneNameDialog : public QIWithRetranslateUI<QDialog>
+{
+    Q_OBJECT;
+
+public:
+
+    /** Constructs dialog passing @a pParent to the base-class.
+      * @param  strName  Brings the clone name by default. */
+    UIAcquireCloudMachineCloneNameDialog(QWidget *pParent, const QString &strName);
+
+    /** Returns value. */
+    QString value() const;
+
+protected:
+
+    /** Handles translation event. */
+    virtual void retranslateUi() RT_OVERRIDE;
+
+private slots:
+
+    /** Performs revalidation. */
+    void sltRevalidate();
+
+private:
+
+    /** Prepares all. */
+    void prepare();
+    /** Prepares widgets. */
+    void prepareWidgets();
+
+    /** Holds the clone name by default. */
+    QString  m_strName;
+
+    /** Holds the text-editor instance. */
+    QILineEdit        *m_pEditor;
+    /** Holds the button-box instance. */
+    QIDialogButtonBox *m_pButtonBox;
+};
+
 
 /*********************************************************************************************************************************
@@ -433 +474 @@
     m_pTextEditor->setPlainText(file.readAll());
     return true;
+}
+
+
+/*********************************************************************************************************************************
+*   Class UIAcquireCloudMachineCloneNameDialog implementation.                                                                   *
+*********************************************************************************************************************************/
+
+UIAcquireCloudMachineCloneNameDialog::UIAcquireCloudMachineCloneNameDialog(QWidget *pParent, const QString &strName)
+    : QIWithRetranslateUI<QDialog>(pParent)
+    , m_strName(strName)
+    , m_pEditor(0)
+    , m_pButtonBox(0)
+{
+    prepare();
+    sltRevalidate();
+}
+
+QString UIAcquireCloudMachineCloneNameDialog::value() const
+{
+    return m_pEditor ? m_pEditor->text() : QString();
+}
+
+void UIAcquireCloudMachineCloneNameDialog::prepare()
+{
+    /* Prepare widgets: */
+    prepareWidgets();
+    /* Apply language settings: */
+    retranslateUi();
+
+    /* Resize to suitable size: */
+    const int iMinimumHeightHint = minimumSizeHint().height();
+    resize(iMinimumHeightHint * 1.618, iMinimumHeightHint);
+}
+
+void UIAcquireCloudMachineCloneNameDialog::prepareWidgets()
+{
+    /* Prepare layout: */
+    QVBoxLayout *pLayout = new QVBoxLayout(this);
+    if (pLayout)
+    {
+        /* Prepare editor: */
+        m_pEditor = new QILineEdit(this);
+        if (m_pEditor)
+        {
+            m_pEditor->setText(m_strName);
+            m_pEditor->setMinimumWidthByText(QString().fill('0', 20));
+            connect(m_pEditor, &QILineEdit::textChanged, this, &UIAcquireCloudMachineCloneNameDialog::sltRevalidate);
+            pLayout->addWidget(m_pEditor);
+        }
+
+        /* Intermediate stretch: */
+        pLayout->addStretch();
+
+        /* Prepare button-box: */
+        m_pButtonBox = new QIDialogButtonBox(this);
+        if (m_pButtonBox)
+        {
+            m_pButtonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel);
+            connect(m_pButtonBox, &QIDialogButtonBox::accepted, this, &UIAcquireCloudMachineCloneNameDialog::accept);
+            connect(m_pButtonBox, &QIDialogButtonBox::rejected, this, &UIAcquireCloudMachineCloneNameDialog::reject);
+            pLayout->addWidget(m_pButtonBox);
+        }
+    }
+}
+
+void UIAcquireCloudMachineCloneNameDialog::retranslateUi()
+{
+    setWindowTitle(tr("Clone name"));
+    m_pEditor->setPlaceholderText(tr("Enter clone name"));
+}
+
+void UIAcquireCloudMachineCloneNameDialog::sltRevalidate()
+{
+    m_pButtonBox->button(QDialogButtonBox::Ok)->setEnabled(!m_pEditor->text().isEmpty());
 }
 
@@ -1237 +1352 @@
 void UIVirtualBoxManager::sltOpenCloneMachineWizard()
 {
-    /* Configure wizard variables: */
-    m_fSnapshotCloneByDefault = false;
-    QAction *pAction = qobject_cast<QAction*>(sender());
-    if (   pAction
-        && pAction == actionPool()->action(UIActionIndexMN_M_Snapshot_S_Clone))
-        m_fSnapshotCloneByDefault = true;
-
-    /* Open Clone VM Wizard: */
-    sltOpenWizard(WizardType_CloneVM);
+    /* Get current items: */
+    QList<UIVirtualMachineItem*> items = currentItems();
+
+    /* We are opening Clone VM wizard for local VMs only: */
+    if (isItemsLocal(items))
+    {
+        /* Configure wizard variables: */
+        m_fSnapshotCloneByDefault = false;
+        QAction *pAction = qobject_cast<QAction*>(sender());
+        if (   pAction
+            && pAction == actionPool()->action(UIActionIndexMN_M_Snapshot_S_Clone))
+            m_fSnapshotCloneByDefault = true;
+
+        /* Open Clone VM Wizard: */
+        sltOpenWizard(WizardType_CloneVM);
+    }
+    /* For cloud VMs we have no such wizard for now: */
+    else if (isItemsCloud(items))
+    {
+        /* Acquire item, propose clone name: */
+        UIVirtualMachineItem *pItem = items.first();
+        const QString strName = QString("%1_clone").arg(pItem->name());
+
+        /* Create Acquire Clone VM name dialog: */
+        QPointer<UIAcquireCloudMachineCloneNameDialog> pDialog = new UIAcquireCloudMachineCloneNameDialog(this, strName);
+        if (pDialog->exec() == QDialog::Accepted)
+        {
+            /* Parse current full group name: */
+            const QString strFullGroupName = m_pWidget->fullGroupName();
+            const QString strProviderShortName = strFullGroupName.section('/', 1, 1);
+            const QString strProfileName = strFullGroupName.section('/', 2, 2);
+
+            /* Acquire cloud machine: */
+            const CCloudMachine comMachine = pItem->toCloud()->machine();
+
+            /* Clone VM: */
+            createCloudMachineClone(strProviderShortName, strProfileName,
+                                    comMachine, pDialog->value(),
+                                    gpNotificationCenter);
+       }
+       delete pDialog;
+    }
 }
 
@@ -2998 +3146 @@
         pMenu->addSeparator();
         pMenu->addAction(actionPool()->action(UIActionIndexMN_M_Machine_S_Settings));
+        pMenu->addAction(actionPool()->action(UIActionIndexMN_M_Machine_S_Clone));
         pMenu->addAction(actionPool()->action(UIActionIndexMN_M_Machine_S_Remove));
         pMenu->addSeparator();
@@ -3544 +3693 @@
             return !isGroupSavingInProgress() &&
                    items.size() == 1 &&
-                   pItem->toLocal() &&
                    pItem->isItemEditable();
         }

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp

@@ -1564 +1564 @@
     {
         pMenuMachine->addAction(actionPool()->action(UIActionIndexMN_M_Machine_S_Settings));
+        pMenuMachine->addAction(actionPool()->action(UIActionIndexMN_M_Machine_S_Clone));
         pMenuMachine->addAction(actionPool()->action(UIActionIndexMN_M_Machine_S_Remove));
         pMenuMachine->addSeparator();

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.cpp

@@ -3184 +3184 @@
     if (error().isEmpty())
         emit sigCloudMachineRemoved(m_strProviderShortName, m_strProfileName, m_strName);
+}
+
+
+/*********************************************************************************************************************************
+*   Class UINotificationProgressCloudMachineClone implementation.                                                                *
+*********************************************************************************************************************************/
+
+UINotificationProgressCloudMachineClone::UINotificationProgressCloudMachineClone(const CCloudClient &comClient,
+                                                                                 const CCloudMachine &comMachine,
+                                                                                 const QString &strCloneName)
+    : m_comClient(comClient)
+    , m_comMachine(comMachine)
+    , m_strCloneName(strCloneName)
+{
+}
+
+QString UINotificationProgressCloudMachineClone::name() const
+{
+    return UINotificationProgress::tr("Cloning cloud VM ...");
+}
+
+QString UINotificationProgressCloudMachineClone::details() const
+{
+    return UINotificationProgress::tr("<b>VM Name:</b> %1").arg(m_strName);
+}
+
+CProgress UINotificationProgressCloudMachineClone::createProgress(COMResult &comResult)
+{
+    // This is wrong, we need to acquire ocid, we have no one for now ..
+    m_uId = m_comMachine.GetId();
+    if (!m_comMachine.isOk())
+    {
+        /* Store COM result: */
+        comResult = m_comMachine;
+        /* Return progress-wrapper: */
+        return CProgress();
+    }
+    /* Acquire cloud VM name: */
+    m_strName = m_comMachine.GetName();
+    if (!m_comMachine.isOk())
+    {
+        /* Store COM result: */
+        comResult = m_comMachine;
+        /* Return progress-wrapper: */
+        return CProgress();
+    }
+
+    /* Initialize progress-wrapper: */
+    CCloudMachine comCloneMachine;
+    // This is wrong, we need to pass ocid, we have no one for now ..
+    const QString strId = m_uId.toString();
+    CProgress comProgress = m_comClient.CloneInstance(strId, m_strCloneName, comCloneMachine);
+    /* Store COM result: */
+    comResult = m_comMachine;
+    /* Return progress-wrapper: */
+    return comProgress;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.h

@@ -1822 +1822 @@
 };
 
+/** UINotificationProgress extension for cloud machine clone functionality. */
+class SHARED_LIBRARY_STUFF UINotificationProgressCloudMachineClone : public UINotificationProgress
+{
+    Q_OBJECT;
+
+public:
+
+    /** Constructs cloud machine clone notification-progress.
+      * @param  comClient     Brings the cloud client to clone cloud machine.
+      * @param  comMachine    Brings the cloud machine to be cloned.
+      * @param  strCloneName  Brings the clone name. */
+    UINotificationProgressCloudMachineClone(const CCloudClient &comClient,
+                                            const CCloudMachine &comMachine,
+                                            const QString &strCloneName);
+
+protected:
+
+    /** Returns object name. */
+    virtual QString name() const /* override final */;
+    /** Returns object details. */
+    virtual QString details() const /* override final */;
+    /** Creates and returns started progress-wrapper. */
+    virtual CProgress createProgress(COMResult &comResult) /* override final */;
+
+private:
+
+    /** Holds the client cloning machine. */
+    CCloudClient   m_comClient;
+    /** Holds the machine being reset. */
+    CCloudMachine  m_comMachine;
+    /** Holds the clone name. */
+    QString        m_strCloneName;
+    // This is wrong, we need to store ocid, we have no one for now ..
+    QUuid          m_uId;
+    /** Holds the machine name. */
+    QString        m_strName;
+};
+
 /** UINotificationProgress extension for cloud machine reset functionality. */
 class SHARED_LIBRARY_STUFF UINotificationProgressCloudMachineReset : public UINotificationProgress