Changeset 100870 in vbox

Timestamp:

Aug 14, 2023 12:51:17 PM (16 months ago)

Author:

vboxsync

Message:

Devices/DrvIntNet,NetworkServices/VBoxIntNetSwitch: Plug a few memory leaks, ticketref:21752

Location:

trunk/src/VBox

Files:

• Devices/Network/DrvIntNet.cpp (modified) (1 diff)
• NetworkServices/IntNetSwitch/VBoxIntNetSwitch.cpp (modified) (4 diffs)
• NetworkServices/NetLib/IntNetIf.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Network/DrvIntNet.cpp

@@ -249 +249 @@
         xpc_dictionary_set_data(hObj, "req", pvArg, cbArg);
         xpc_object_t hObjReply = xpc_connection_send_message_with_reply_sync(pThis->hXpcCon, hObj);
+        xpc_release(hObj);
+
         uint64_t u64Rc = xpc_dictionary_get_uint64(hObjReply, "rc");
         if (INTNET_R3_SVC_IS_VALID_RC(u64Rc))

trunk/src/VBox/NetworkServices/IntNetSwitch/VBoxIntNetSwitch.cpp

@@ -434 +434 @@
         xpc_object_t hObjPoke = xpc_dictionary_create(NULL, NULL, 0);
         xpc_connection_send_message(pSession->hXpcCon, hObjPoke);
+        xpc_release(hObjPoke);
     }
     else
@@ -508 +509 @@
                     xpc_dictionary_set_uint64(hObjReply, "rc", INTNET_R3_SVC_SET_RC(rc));
                     xpc_connection_send_message(hCon, hObjReply);
+                    xpc_release(hObjReply);
                     return;
                 }
@@ -570 +572 @@
                         xpc_object_t hObjPoke = xpc_dictionary_create(NULL, NULL, 0);
                         xpc_connection_send_message(pSession->hXpcCon, hObjPoke);
+                        xpc_release(hObjPoke);
                     }
                     return;
@@ -587 +590 @@
                         xpc_object_t hObjPoke = xpc_dictionary_create(NULL, NULL, 0);
                         xpc_connection_send_message(pSession->hXpcCon, hObjPoke);
+                        xpc_release(hObjPoke);
                     }
                     cbReply = sizeof(INTNETIFABORTWAITREQ);

trunk/src/VBox/NetworkServices/NetLib/IntNetIf.cpp

@@ -111 +111 @@
         xpc_dictionary_set_data(hObj, "req", pReqHdr, pReqHdr->cbReq);
         xpc_object_t hObjReply = xpc_connection_send_message_with_reply_sync(pThis->hXpcCon, hObj);
+        xpc_release(hObj);
+
         int rc = (int)xpc_dictionary_get_int64(hObjReply, "rc");