Changeset 100923 in vbox for trunk/src/VBox/Frontends

Timestamp:

Aug 21, 2023 1:23:49 PM (16 months ago)

Author:

vboxsync

Message:

FE/Qt: UISettingsDialog: Large cleanup for prepare/cleanup cascade.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings

Files:

• UISettingsDialog.cpp (modified) (7 diffs)
• UISettingsDialog.h (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsDialog.cpp

@@ -67 +67 @@
     , m_strControl(strControl)
     , m_pSelector(0)
-    , m_pStack(0)
     , m_enmConfigurationAccessLevel(ConfigurationAccessLevel_Null)
     , m_pSerializeProcess(0)
@@ -79 +78 @@
     , m_fValid(true)
     , m_fSilent(true)
+    , m_pLayoutMain(0)
     , m_pLabelTitle(0)
+    , m_pStack(0)
     , m_pButtonBox(0)
-    , m_pWidgetStackHandler(0)
-{
-    /* Prepare: */
+{
     prepare();
 }
@@ -208 +207 @@
 void UISettingsDialog::retranslateUi()
 {
-    m_pLabelTitle->setText(QString());
+#ifndef VBOX_GUI_WITH_TOOLBAR_SETTINGS
+    /* Retranslate current page headline: */
+    m_pLabelTitle->setText(m_pSelector->itemText(m_pSelector->currentId()));
+#endif
 
     /* Translate warning stuff: */
@@ -214 +216 @@
     if (!m_fValid || !m_fSilent)
         m_pWarningPane->setWarningLabel(m_strWarningHint);
-
-#ifndef VBOX_GUI_WITH_TOOLBAR_SETTINGS
-    /* Retranslate current page headline: */
-    m_pLabelTitle->setText(m_pSelector->itemText(m_pSelector->currentId()));
-#endif
 
     /* Retranslate all validators: */
@@ -600 +597 @@
 void UISettingsDialog::prepare()
 {
-    prepareWidgets();
-
-    /* Configure title: */
+    /* Prepare central-widget: */
+    setCentralWidget(new QWidget);
+    if (centralWidget())
+    {
+        /* Prepare main layout: */
+        m_pLayoutMain = new QGridLayout(centralWidget());
+        if (m_pLayoutMain)
+        {
+            /* Prepare widgets: */
+            prepareSelector();
+            prepareStack();
+            prepareButtonBox();
+        }
+    }
+
+    /* Apply language settings: */
+    retranslateUi();
+}
+
+void UISettingsDialog::prepareSelector()
+{
+#ifdef VBOX_GUI_WITH_TOOLBAR_SETTINGS
+    /* Prepare modern tool-bar selector: */
+    m_pSelector = new UISettingsSelectorToolBar(this);
+    if (m_pSelector)
+    {
+        static_cast<QIToolBar*>(m_pSelector->widget())->enableMacToolbar();
+        addToolBar(qobject_cast<QToolBar*>(m_pSelector->widget()));
+    }
+
+    /* No title in this mode, we change the title of the window: */
+    m_pLayoutMain->setColumnMinimumWidth(0, 0);
+    m_pLayoutMain->setHorizontalSpacing(0);
+
+#else /* !VBOX_GUI_WITH_TOOLBAR_SETTINGS */
+
+    /* Prepare classical tree-view selector: */
+    m_pSelector = new UISettingsSelectorTreeView(centralWidget());
+    if (m_pSelector)
+    {
+        m_pLayoutMain->addWidget(m_pSelector->widget(), 0, 0, 2, 1);
+        m_pSelector->widget()->setFocus();
+    }
+
+    /* Prepare title label: */
+    m_pLabelTitle = new QLabel(centralWidget());
     if (m_pLabelTitle)
     {
-        /* Page-title font is bold and larger but derived from the system font: */
-        QFont pageTitleFont = font();
-        pageTitleFont.setBold(true);
-        pageTitleFont.setPointSize(pageTitleFont.pointSize() + 2);
-        m_pLabelTitle->setFont(pageTitleFont);
-    }
-
-    /* Prepare selector: */
-    QGridLayout *pMainLayout = static_cast<QGridLayout*>(centralWidget()->layout());
-    if (pMainLayout)
-    {
-#ifdef VBOX_GUI_WITH_TOOLBAR_SETTINGS
-
-        /* No page-title with tool-bar: */
-        m_pLabelTitle->hide();
-
-        /* Create modern tool-bar selector: */
-        m_pSelector = new UISettingsSelectorToolBar(this);
-        if (m_pSelector)
-        {
-            /* Configure tool-bar: */
-            static_cast<QIToolBar*>(m_pSelector->widget())->enableMacToolbar();
-
-            /* Add tool-bar into page: */
-            addToolBar(qobject_cast<QToolBar*>(m_pSelector->widget()));
-        }
-
-        /* No title in this mode, we change the title of the window: */
-        pMainLayout->setColumnMinimumWidth(0, 0);
-        pMainLayout->setHorizontalSpacing(0);
-
-#else /* !VBOX_GUI_WITH_TOOLBAR_SETTINGS */
-
-        /* Create classical tree-view selector: */
-        m_pSelector = new UISettingsSelectorTreeView(this);
-        if (m_pSelector)
-        {
-            /* Add into layout: */
-            pMainLayout->addWidget(m_pSelector->widget(), 0, 0, 2, 1);
-
-            /* Set focus: */
-            m_pSelector->widget()->setFocus();
-        }
-
+        m_pLabelTitle->setSizePolicy(QSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::Fixed));
+        QPalette pal = QApplication::palette();
+        pal.setColor(QPalette::Active, QPalette::Window, pal.color(QPalette::Active, QPalette::Base));
+        m_pLabelTitle->setPalette(pal);
+        QFont fnt;
+        fnt.setFamily(QStringLiteral("Sans Serif"));
+//        fnt.setPointSize(11);
+        fnt.setPointSize(fnt.pointSize() + 2);
+        fnt.setBold(true);
+        fnt.setWeight(QFont::ExtraBold);
+        m_pLabelTitle->setFont(fnt);
+        m_pLabelTitle->setAutoFillBackground(true);
+        m_pLabelTitle->setFrameShadow(QFrame::Sunken);
+        m_pLabelTitle->setMargin(9);
+
+        /* Add title-label into main layout: */
+        m_pLayoutMain->addWidget(m_pLabelTitle, 0, 1);
+    }
 #endif /* !VBOX_GUI_WITH_TOOLBAR_SETTINGS */
 
-        connect(m_pSelector, &UISettingsSelectorTreeView::sigCategoryChanged, this, &UISettingsDialog::sltCategoryChanged);
-    }
-
-    /* Prepare stack-handler: */
-    if (m_pWidgetStackHandler)
-    {
-        /* Create page-stack layout: */
-        QVBoxLayout *pStackLayout = new QVBoxLayout(m_pWidgetStackHandler);
-        if (pStackLayout)
-        {
-            /* Confugre page-stack layout: */
-            pStackLayout->setContentsMargins(0, 0, 0, 0);
-
-            /* Create page-stack: */
-            m_pStack = new QStackedWidget;
-            if (m_pStack)
-            {
-                /* Configure page-stack: */
-                popupCenter().setPopupStackOrientation(m_pStack, UIPopupStackOrientation_Bottom);
-
-                /* Add into layout: */
-                pStackLayout->addWidget(m_pStack);
-            }
-        }
-    }
-
+    /* Configure selector created above: */
+    if (m_pSelector)
+        connect(m_pSelector, &UISettingsSelectorTreeView::sigCategoryChanged,
+                this, &UISettingsDialog::sltCategoryChanged);
+}
+
+void UISettingsDialog::prepareStack()
+{
+    /* Prepare page-stack: */
+    m_pStack = new QStackedWidget(centralWidget());
+    if (m_pStack)
+    {
+        /* Configure page-stack: */
+        popupCenter().setPopupStackOrientation(m_pStack, UIPopupStackOrientation_Bottom);
+
+        /* Add page-stack into main layout: */
+        m_pLayoutMain->addWidget(m_pStack, 1, 1);
+    }
+}
+
+void UISettingsDialog::prepareButtonBox()
+{
     /* Prepare button-box: */
+    m_pButtonBox = new QIDialogButtonBox(centralWidget());
     if (m_pButtonBox)
     {
-        /* Create status-bar: */
-        m_pStatusBar = new QStackedWidget;
+#ifndef VBOX_WS_MAC
+        m_pButtonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel |
+                                         QDialogButtonBox::NoButton | QDialogButtonBox::Help);
+        m_pButtonBox->button(QDialogButtonBox::Help)->setShortcut(QKeySequence::HelpContents);
+#else
+        // WORKAROUND:
+        // No Help button on macOS for now, conflict with old Qt.
+        m_pButtonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel |
+                                         QDialogButtonBox::NoButton);
+#endif
+        m_pButtonBox->button(QDialogButtonBox::Ok)->setShortcut(Qt::Key_Return);
+        m_pButtonBox->button(QDialogButtonBox::Cancel)->setShortcut(Qt::Key_Escape);
+        connect(m_pButtonBox, &QIDialogButtonBox::rejected, this, &UISettingsDialog::close);
+        connect(m_pButtonBox, &QIDialogButtonBox::accepted, this, &UISettingsDialog::accept);
+#ifndef VBOX_WS_MAC
+        connect(m_pButtonBox->button(QDialogButtonBox::Help), &QAbstractButton::pressed,
+                m_pButtonBox, &QIDialogButtonBox::sltHandleHelpRequest);
+#endif
+
+        /* Prepare status-bar: */
+        m_pStatusBar = new QStackedWidget(m_pButtonBox);
         if (m_pStatusBar)
         {
@@ -687 +717 @@
             m_pStatusBar->addWidget(new QWidget);
 
-            /* Create process-bar: */
-            m_pProcessBar = new QProgressBar;
+            /* Prepare process-bar: */
+            m_pProcessBar = new QProgressBar(m_pStatusBar);
             if (m_pProcessBar)
             {
-                /* Configure process-bar: */
                 m_pProcessBar->setMinimum(0);
                 m_pProcessBar->setMaximum(100);
-
-                /* Add into status-bar: */
                 m_pStatusBar->addWidget(m_pProcessBar);
             }
 
-            /* Create warning-pane: */
-            m_pWarningPane = new UIWarningPane;
+            /* Prepare warning-pane: */
+            m_pWarningPane = new UIWarningPane(m_pStatusBar);
             if (m_pWarningPane)
             {
-                /* Configure warning-pane: */
                 connect(m_pWarningPane, &UIWarningPane::sigHoverEnter,
                         this, &UISettingsDialog::sltHandleWarningPaneHovered);
                 connect(m_pWarningPane, &UIWarningPane::sigHoverLeave,
                         this, &UISettingsDialog::sltHandleWarningPaneUnhovered);
-
-                /* Add into status-bar: */
                 m_pStatusBar->addWidget(m_pWarningPane);
             }
@@ -716 +740 @@
             m_pButtonBox->addExtraWidget(m_pStatusBar);
         }
-    }
-
-    /* Apply language settings: */
-    retranslateUi();
-}
-
-void UISettingsDialog::prepareWidgets()
-{
-    /* Prepare central-widget: */
-    setCentralWidget(new QWidget);
-    if (centralWidget())
-    {
-        /* Prepare main layout: */
-        QGridLayout *pLayoutMain = new QGridLayout(centralWidget());
-        if (pLayoutMain)
-        {
-            /* Prepare title label: */
-            m_pLabelTitle = new QLabel(centralWidget());
-            if (m_pLabelTitle)
-            {
-                m_pLabelTitle->setSizePolicy(QSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::Fixed));
-                QPalette pal = QApplication::palette();
-                pal.setColor(QPalette::Active, QPalette::Window, pal.color(QPalette::Active, QPalette::Base));
-                m_pLabelTitle->setPalette(pal);
-                QFont fnt;
-                fnt.setFamily(QStringLiteral("Sans Serif"));
-                fnt.setPointSize(11);
-                fnt.setBold(true);
-                fnt.setWeight(QFont::ExtraBold);
-                m_pLabelTitle->setFont(fnt);
-                m_pLabelTitle->setAutoFillBackground(true);
-                m_pLabelTitle->setFrameShadow(QFrame::Sunken);
-                m_pLabelTitle->setMargin(9);
-
-                pLayoutMain->addWidget(m_pLabelTitle, 0, 1);
-            }
-
-            /* Prepare widget stack handler: */
-            m_pWidgetStackHandler = new QWidget(centralWidget());
-            if (m_pWidgetStackHandler)
-            {
-                m_pWidgetStackHandler->setSizePolicy(QSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::MinimumExpanding));
-                pLayoutMain->addWidget(m_pWidgetStackHandler, 1, 1);
-            }
-
-            /* Prepare button-box: */
-            m_pButtonBox = new QIDialogButtonBox(centralWidget());
-            if (m_pButtonBox)
-            {
-#ifndef VBOX_WS_MAC
-                m_pButtonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel |
-                                                 QDialogButtonBox::NoButton | QDialogButtonBox::Help);
-                m_pButtonBox->button(QDialogButtonBox::Help)->setShortcut(QKeySequence::HelpContents);
-#else
-                // WORKAROUND:
-                // No Help button on macOS for now, conflict with old Qt.
-                m_pButtonBox->setStandardButtons(QDialogButtonBox::Ok | QDialogButtonBox::Cancel |
-                                                 QDialogButtonBox::NoButton);
-#endif
-                m_pButtonBox->button(QDialogButtonBox::Ok)->setShortcut(Qt::Key_Return);
-                m_pButtonBox->button(QDialogButtonBox::Cancel)->setShortcut(Qt::Key_Escape);
-                connect(m_pButtonBox, &QIDialogButtonBox::rejected, this, &UISettingsDialog::close);
-                connect(m_pButtonBox, &QIDialogButtonBox::accepted, this, &UISettingsDialog::accept);
-#ifndef VBOX_WS_MAC
-                connect(m_pButtonBox->button(QDialogButtonBox::Help), &QAbstractButton::pressed,
-                        m_pButtonBox, &QIDialogButtonBox::sltHandleHelpRequest);
-#endif
-
-                pLayoutMain->addWidget(m_pButtonBox, 2, 0, 1, 2);
-            }
-        }
+
+        /* Add button-box into main layout: */
+        m_pLayoutMain->addWidget(m_pButtonBox, 2, 0, 1, 2);
     }
 }

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsDialog.h

@@ -41 +41 @@
 /* Forward declarations: */
 class QEvent;
+class QGridLayout;
 class QObject;
 class QLabel;
@@ -174 +175 @@
     /** Holds the page selector instance. */
     UISettingsSelector *m_pSelector;
-    /** Holds the page stack instance. */
-    QStackedWidget     *m_pStack;
 
 private slots:
@@ -189 +188 @@
 private:
 
-    /** Prepares all. */
-    void prepare();
-    /** Prepares widgets. */
-    void prepareWidgets();
+    /** @name Prepare/cleanup cascade.
+     * @{ */
+        /** Prepares all. */
+        void prepare();
+        /** Prepares selector. */
+        void prepareSelector();
+        /** Prepare stack. */
+        void prepareStack();
+        /** Prepare button-box. */
+        void prepareButtonBox();
+    /** @} */
+
     /** Assigns validater for passed @a pPage. */
     void assignValidator(UISettingsPage *pPage);
@@ -239 +246 @@
     /** @name Widgets
      * @{ */
-       QLabel            *m_pLabelTitle;
-       QIDialogButtonBox *m_pButtonBox;
-       QWidget           *m_pWidgetStackHandler;
+        /** Holds the main layout instance. */
+        QGridLayout       *m_pLayoutMain;
+        /** Holds the title-label instance. */
+        QLabel            *m_pLabelTitle;
+        /** Holds the page-stack instance. */
+        QStackedWidget    *m_pStack;
+        /** Holds the button-box instance. */
+        QIDialogButtonBox *m_pButtonBox;
     /** @} */
 };