Changeset 101062 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Sep 8, 2023 8:53:04 AM (18 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

159021

Message:

VMM/GICAll: Properly fix assertion, uIntId == 0 is of course allowed (r158982 regression)

File:

• trunk/src/VBox/VMM/VMMAll/GICAll.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/GICAll.cpp

@@ -1244 +1244 @@
     PDM_CRITSECT_RELEASE_ASSERT_RC_DEV(pDevIns, pDevIns->pCritSectRoR3, rcLock);
 
-    AssertReturn(uIntId > 0 && uIntId <= (GIC_INTID_RANGE_PPI_LAST - GIC_INTID_RANGE_PPI_START), VERR_INVALID_PARAMETER);
+    AssertReturn(uIntId <= (GIC_INTID_RANGE_PPI_LAST - GIC_INTID_RANGE_PPI_START), VERR_INVALID_PARAMETER);
     int rc = gicReDistInterruptSet(pVCpu, uIntId + GIC_INTID_RANGE_PPI_START, fAsserted);
     PDMDevHlpCritSectLeave(pDevIns, pDevIns->pCritSectRoR3);
@@ -1270 +1270 @@
     PDM_CRITSECT_RELEASE_ASSERT_RC_DEV(pDevIns, pDevIns->pCritSectRoR3, rcLock);
 
-    AssertReturn(uIntId > 0 && uIntId <= (GIC_INTID_RANGE_SGI_LAST - GIC_INTID_RANGE_SGI_START), VERR_INVALID_PARAMETER);
+    AssertReturn(uIntId <= (GIC_INTID_RANGE_SGI_LAST - GIC_INTID_RANGE_SGI_START), VERR_INVALID_PARAMETER);
     int rc = gicReDistInterruptSet(pVCpu, uIntId + GIC_INTID_RANGE_SGI_START, fAsserted);
     PDMDevHlpCritSectLeave(pDevIns, pDevIns->pCritSectRoR3);