Changeset 101097 in vbox

Timestamp:

Sep 12, 2023 11:20:03 PM (20 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

159066

Message:

VBoxDbg: Moved the dInt column next to the main value column it relates to. This reduces the rectangle that needs to be invalidated on updates of non-profile type nodes. Added a '+' to positive dInt values to emphasize that it's a delta.

File:

• trunk/src/VBox/Debugger/VBoxDbgStatsQt.cpp (modified) (6 diffs)

trunk/src/VBox/Debugger/VBoxDbgStatsQt.cpp

@@ -659 +659 @@
  * (18 446 744 073 709 551 615)
  */
-static char *formatNumberSigned(char *psz, int64_t i64)
+static char *formatNumberSigned(char *psz, int64_t i64, bool fPositivePlus = false)
 {
     static const char s_szDigits[] = "0123456789";
@@ -680 +680 @@
     if (fNegative)
         *--psz = '-';
+    else if (fPositivePlus)
+        *--psz = '+';
     return psz;
 }
@@ -1950 +1952 @@
                     if (iChild >= pNode->cChildren)
                         break;
-                    QModelIndex const TopLeft = createIndex(iChild, 2, pNode->papChildren[iChild]);
-                    pNode->papChildren[iChild]->enmState = kDbgGuiStatsNodeState_kVisible;
+                    PDBGGUISTATSNODE  pChild    = pNode->papChildren[iChild];
+                    QModelIndex const TopLeft   = createIndex(iChild, 2, pChild);
+                    pChild->enmState = kDbgGuiStatsNodeState_kVisible;
 
                     /* Any subsequent nodes that also needs refreshing? */
-                    while (   iChild + 1 < pNode->cChildren
-                           && pNode->papChildren[iChild + 1]->enmState == kDbgGuiStatsNodeState_kRefresh)
-                        iChild++;
+                    int const iRightCol = pChild->enmType != STAMTYPE_PROFILE && pChild->enmType != STAMTYPE_PROFILE_ADV ? 4 : 7;
+                    if (iRightCol == 4)
+                        while (   iChild + 1 < pNode->cChildren
+                               && (pChild = pNode->papChildren[iChild + 1])->enmState == kDbgGuiStatsNodeState_kRefresh
+                               && pChild->enmType != STAMTYPE_PROFILE
+                               && pChild->enmType != STAMTYPE_PROFILE_ADV)
+                            iChild++;
+                    else
+                        while (   iChild + 1 < pNode->cChildren
+                               && (pChild = pNode->papChildren[iChild + 1])->enmState == kDbgGuiStatsNodeState_kRefresh
+                               && (   pChild->enmType == STAMTYPE_PROFILE
+                                   || pChild->enmType == STAMTYPE_PROFILE_ADV))
+                            iChild++;
 
                     /* emit the refresh signal */
-                    QModelIndex const BottomRight = createIndex(iChild, DBGGUI_STATS_COLUMNS - 2, pNode->papChildren[iChild]);
+                    QModelIndex const BottomRight = createIndex(iChild, iRightCol, pNode->papChildren[iChild]);
                     emit dataChanged(TopLeft, BottomRight);
                     iChild++;
@@ -2194 +2207 @@
             case 1: return tr("Unit");
             case 2: return tr("Value/Times");
-            case 3: return tr("Min");
-            case 4: return tr("Average");
-            case 5: return tr("Max");
-            case 6: return tr("Total");
-            case 7: return tr("dInt");
+            case 3: return tr("dInt");
+            case 4: return tr("Min");
+            case 5: return tr("Average");
+            case 6: return tr("Max");
+            case 7: return tr("Total");
             case 8: return tr("Description");
             default:
@@ -2417 +2430 @@
         case STAMTYPE_BOOL:
         case STAMTYPE_BOOL_RESET:
-            return formatNumberSigned(sz, pNode->i64Delta);
+            if (pNode->i64Delta)
+                return formatNumberSigned(sz, pNode->i64Delta, true /*fPositivePlus*/);
+            return "0";
         default:
             return "";
@@ -2445 +2460 @@
                 return strValueTimes(pNode);
             case 3:
+                return strDeltaValue(pNode);
+            case 4:
                 return strMinValue(pNode);
-            case 4:
+            case 5:
                 return strAvgValue(pNode);
-            case 5:
+            case 6:
                 return strMaxValue(pNode);
-            case 6:
+            case 7:
                 return strTotalValue(pNode);
-            case 7:
-                return strDeltaValue(pNode);
             case 8:
                 return pNode->pDescStr ? QString(*pNode->pDescStr) : QString("");