Changeset 101098 in vbox

Timestamp:

Sep 12, 2023 11:31:00 PM (19 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

159067

Message:

VBoxDbg: Some stats formatting tweaking.

File:

• trunk/src/VBox/Debugger/VBoxDbgStatsQt.cpp (modified) (9 diffs)

trunk/src/VBox/Debugger/VBoxDbgStatsQt.cpp

@@ -636 +636 @@
 static char *formatNumber(char *psz, uint64_t u64)
 {
-    static const char s_szDigits[] = "0123456789";
-    psz += 63;
-    *psz-- = '\0';
-    unsigned cDigits = 0;
-    for (;;)
-    {
-        const unsigned iDigit = u64 % 10;
-        u64 /= 10;
-        *psz = s_szDigits[iDigit];
-        if (!u64)
-            break;
-        psz--;
-        if (!(++cDigits % 3))
-            *psz-- = ',';
+    if (!u64)
+    {
+        psz[0] = '0';
+        psz[1] = '\0';
+    }
+    else
+    {
+        static const char s_szDigits[] = "0123456789";
+        psz += 63;
+        *psz-- = '\0';
+        unsigned cDigits = 0;
+        for (;;)
+        {
+            const unsigned iDigit = u64 % 10;
+            u64 /= 10;
+            *psz = s_szDigits[iDigit];
+            if (!u64)
+                break;
+            psz--;
+            if (!(++cDigits % 3))
+                *psz-- = ',';
+        }
     }
     return psz;
@@ -659 +667 @@
  * (18 446 744 073 709 551 615)
  */
-static char *formatNumberSigned(char *psz, int64_t i64, bool fPositivePlus = false)
+static char *formatNumberSigned(char *psz, int64_t i64, bool fPositivePlus)
 {
     static const char s_szDigits[] = "0123456789";
@@ -2261 +2269 @@
         case STAMTYPE_PROFILE:
         case STAMTYPE_PROFILE_ADV:
-            if (!pNode->Data.Profile.cPeriods)
-                return "0";
             return formatNumber(sz, pNode->Data.Profile.cPeriods);
 
@@ -2334 +2340 @@
         case STAMTYPE_PROFILE:
         case STAMTYPE_PROFILE_ADV:
-            if (!pNode->Data.Profile.cPeriods)
-                return "0";
-            return formatNumber(sz, pNode->Data.Profile.cTicksMin);
+            if (pNode->Data.Profile.cPeriods)
+                return formatNumber(sz, pNode->Data.Profile.cTicksMin);
+            return "0"; /* cTicksMin is set to UINT64_MAX */
         default:
             return "";
@@ -2352 +2358 @@
         case STAMTYPE_PROFILE:
         case STAMTYPE_PROFILE_ADV:
-            if (!pNode->Data.Profile.cPeriods)
-                return "0";
-            return formatNumber(sz, pNode->Data.Profile.cTicks / pNode->Data.Profile.cPeriods);
+            if (pNode->Data.Profile.cPeriods)
+                return formatNumber(sz, pNode->Data.Profile.cTicks / pNode->Data.Profile.cPeriods);
+            return "0";
         default:
             return "";
@@ -2370 +2376 @@
         case STAMTYPE_PROFILE:
         case STAMTYPE_PROFILE_ADV:
-            if (!pNode->Data.Profile.cPeriods)
-                return "0";
             return formatNumber(sz, pNode->Data.Profile.cTicksMax);
         default:
@@ -2388 +2392 @@
         case STAMTYPE_PROFILE:
         case STAMTYPE_PROFILE_ADV:
-            if (!pNode->Data.Profile.cPeriods)
-                return "0";
             return formatNumber(sz, pNode->Data.Profile.cTicks);
         default:
@@ -2400 +2402 @@
 VBoxDbgStatsModel::strDeltaValue(PCDBGGUISTATSNODE pNode)
 {
-    char sz[128];
-
     switch (pNode->enmType)
     {
         case STAMTYPE_PROFILE:
         case STAMTYPE_PROFILE_ADV:
-            if (!pNode->Data.Profile.cPeriods)
-                return "0";
-            RT_FALL_THRU();
         case STAMTYPE_COUNTER:
         case STAMTYPE_RATIO_U32:
@@ -2431 +2428 @@
         case STAMTYPE_BOOL_RESET:
             if (pNode->i64Delta)
+            {
+                char sz[128];
                 return formatNumberSigned(sz, pNode->i64Delta, true /*fPositivePlus*/);
+            }
             return "0";
-        default:
-            return "";
-    }
+        case STAMTYPE_END:
+            AssertFailed(); RT_FALL_THRU();
+        case STAMTYPE_CALLBACK:
+        case STAMTYPE_INVALID:
+            break;
+    }
+    return "";
 }