Changeset 101101 in vbox

Timestamp:

Sep 13, 2023 12:43:15 AM (19 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

159070

Message:

VBoxDbg: Crude implemenation of the 'Refresh' / Ctrl-R action.

File:

• trunk/src/VBox/Debugger/VBoxDbgStatsQt.cpp (modified) (16 diffs)

trunk/src/VBox/Debugger/VBoxDbgStatsQt.cpp

@@ -221 +221 @@
 
     /**
-     * Updates the data matching the specified pattern.
+     * Updates the data matching the specified pattern, normally for the whole tree
+     * but optionally a sub-tree if @a a_pSubTree is given.
      *
      * This will should invoke updatePrep, updateCallback and updateDone.
@@ -230 +231 @@
      *
      * @returns true if we reset the model and it's necessary to set the root index.
-     * @param   a_rPatStr       The selection pattern.
+     * @param   a_rPatStr   The selection pattern.
+     * @param   a_pSubTree  The node / sub-tree to update if this is partial update.
+     *                      This is NULL for a full tree update.
      *
      * @remarks The default implementation is an empty stub.
      */
-    virtual bool updateStatsByPattern(const QString &a_rPatStr);
+    virtual bool updateStatsByPattern(const QString &a_rPatStr, PDBGGUISTATSNODE a_pSubTree = NULL);
 
     /**
@@ -240 +243 @@
      * will not remove anything that's outside that tree.
      *
+     * The default implementation will call redirect to updateStatsByPattern().
+     *
      * @param   a_rIndex    The sub-tree root. Invalid index means root.
-     *
-     * @todo    Create a default implementation using updateStatsByPattern.
      */
     virtual void updateStatsByIndex(QModelIndex const &a_rIndex);
@@ -334 +337 @@
      *
      * @returns Success indicator.
-     */
-    bool updatePrepare(void);
+     * @param   a_pSubTree  The node / sub-tree to update if this is partial update.
+     *                      This is NULL for a full tree update.
+     */
+    bool updatePrepare(PDBGGUISTATSNODE a_pSubTree = NULL);
 
     /**
      * Called by updateStatsByPattern(), finalizes the update.
      *
-     * @return See updateStatsByPattern().
-     *
-     * @param  a_fSuccess   Whether the update was successful or not.
-     *
-     */
-    bool updateDone(bool a_fSuccess);
+     * @returns See updateStatsByPattern().
+     *
+     * @param   a_fSuccess  Whether the update was successful or not.
+     * @param   a_pSubTree  The node / sub-tree to update if this is partial update.
+     *                      This is NULL for a full tree update.
+     */
+    bool updateDone(bool a_fSuccess, PDBGGUISTATSNODE a_pSubTree = NULL);
 
     /**
@@ -398 +404 @@
      */
     static char *getNodePath2(PCDBGGUISTATSNODE pNode, char *psz, ssize_t cch);
+
+    /**
+     * Returns the pattern for the node, optionally including the entire sub-tree
+     * under it.
+     *
+     * @returns Pattern.
+     * @param   pNode       The node.
+     * @param   fSubTree    Whether to include the sub-tree in the pattern.
+     */
+    static QString getNodePattern(PCDBGGUISTATSNODE pNode, bool fSubTree = true);
 
     /**
@@ -601 +617 @@
     virtual ~VBoxDbgStatsModelVM();
 
-    virtual bool updateStatsByPattern(const QString &a_rPatStr);
+    virtual bool updateStatsByPattern(const QString &a_rPatStr, PDBGGUISTATSNODE a_pSubTree = NULL);
     virtual void resetStatsByPattern(const QString &a_rPatStr);
 
@@ -1380 +1396 @@
 }
 
+
+/*static*/ QString
+VBoxDbgStatsModel::getNodePattern(PCDBGGUISTATSNODE pNode, bool fSubTree /*= true*/)
+{
+    /* the node pattern. */
+    char szPat[1024+1024+4];
+    ssize_t cch = getNodePath(pNode, szPat, 1024);
+    AssertReturn(cch >= 0, QString("//////////////////////////////////////////////////////"));
+
+    /* the sub-tree pattern. */
+    if (fSubTree && pNode->cChildren)
+    {
+        char *psz = &szPat[cch];
+        *psz++ = '|';
+        memcpy(psz, szPat, cch);
+        psz += cch;
+        *psz++ = '/';
+        *psz++ = '*';
+        *psz++ = '\0';
+    }
+    return szPat;
+}
 
 
@@ -1842 +1880 @@
 
 bool
-VBoxDbgStatsModel::updatePrepare(void)
+VBoxDbgStatsModel::updatePrepare(PDBGGUISTATSNODE a_pSubTree /*= NULL*/)
 {
     /*
@@ -1848 +1886 @@
      * node to be updated.
      */
+    PDBGGUISTATSNODE pFirst;
     Assert(m_pRoot);
     Assert(m_pRoot->enmType == STAMTYPE_INVALID);
-    PDBGGUISTATSNODE pFirst = nextDataNode(m_pRoot);
+    if (!a_pSubTree)
+        pFirst = nextDataNode(m_pRoot);
+    else
+        pFirst = a_pSubTree->enmType != STAMTYPE_INVALID ? a_pSubTree : nextDataNode(a_pSubTree);
     if (pFirst)
     {
@@ -1878 +1920 @@
 
 bool
-VBoxDbgStatsModel::updateDone(bool a_fSuccess)
+VBoxDbgStatsModel::updateDone(bool a_fSuccess, PDBGGUISTATSNODE a_pSubTree /*= NULL*/)
 {
     /*
@@ -1884 +1926 @@
      */
     if (    a_fSuccess
-        &&  m_iUpdateChild != UINT32_MAX)
+        &&  m_iUpdateChild != UINT32_MAX
+        &&  a_pSubTree == NULL)
     {
         PDBGGUISTATSNODE const pLast = prevDataNode(m_pUpdateParent->papChildren[m_iUpdateChild]);
@@ -1928 +1971 @@
          */
         DBGGUISTATSSTACK    Stack;
-        Stack.a[0].pNode = m_pRoot;
+        Stack.a[0].pNode  = !a_pSubTree ? m_pRoot : a_pSubTree;
         Stack.a[0].iChild = -1;
         Stack.iTop = 0;
@@ -1986 +2029 @@
             }
         }
-        /* emit layoutChanged(); - hrmpf, doesn't work reliably... */
+
+        /*
+         * If a_pSubTree is not an intermediate node, invalidate it explicitly.
+         */
+        if (a_pSubTree && a_pSubTree->enmType != STAMTYPE_INVALID)
+        {
+            int         const iRightCol   = a_pSubTree->enmType != STAMTYPE_PROFILE && a_pSubTree->enmType != STAMTYPE_PROFILE_ADV
+                                          ? 4 : 7;
+            QModelIndex const BottomRight = createIndex(a_pSubTree->iSelf, iRightCol, a_pSubTree);
+            QModelIndex const TopLeft     = createIndex(a_pSubTree->iSelf, 2, a_pSubTree);
+            emit dataChanged(TopLeft, BottomRight);
+        }
     }
 
@@ -1994 +2048 @@
 
 bool
-VBoxDbgStatsModel::updateStatsByPattern(const QString &a_rPatStr)
+VBoxDbgStatsModel::updateStatsByPattern(const QString &a_rPatStr, PDBGGUISTATSNODE a_pSubTree /*= NULL*/)
+{
+    /* stub */
+    RT_NOREF(a_rPatStr, a_pSubTree);
+    return false;
+}
+
+
+void
+VBoxDbgStatsModel::updateStatsByIndex(QModelIndex const &a_rIndex)
+{
+    PDBGGUISTATSNODE pNode = nodeFromIndex(a_rIndex);
+    if (pNode == m_pRoot || !a_rIndex.isValid())
+        updateStatsByPattern(QString());
+    else if (pNode)
+        /** @todo this doesn't quite work if pNode is excluded by the m_PatStr.   */
+        updateStatsByPattern(getNodePattern(pNode, true /*fSubTree*/), pNode);
+}
+
+
+void
+VBoxDbgStatsModel::resetStatsByPattern(QString const &a_rPatStr)
 {
     /* stub */
     NOREF(a_rPatStr);
-    return false;
-}
-
-
-void
-VBoxDbgStatsModel::updateStatsByIndex(QModelIndex const &a_rIndex)
-{
-    /** @todo implement this based on updateStatsByPattern. */
-    NOREF(a_rIndex);
-}
-
-
-void
-VBoxDbgStatsModel::resetStatsByPattern(QString const &a_rPatStr)
-{
-    /* stub */
-    NOREF(a_rPatStr);
 }
 
@@ -2024 +2082 @@
     if (pNode == m_pRoot || !a_rIndex.isValid())
     {
+        /* The root can't be reset, so only take action if fSubTree is set. */
         if (fSubTree)
-        {
-            /* everything from the root down. */
             resetStatsByPattern(QString());
-        }
     }
     else if (pNode)
-    {
-        /* the node pattern. */
-        char szPat[1024+1024+4];
-        ssize_t cch = getNodePath(pNode, szPat, 1024);
-        AssertReturnVoid(cch >= 0);
-
-        /* the sub-tree pattern. */
-        if (fSubTree && pNode->cChildren)
-        {
-            char *psz = &szPat[cch];
-            *psz++ = '|';
-            memcpy(psz, szPat, cch);
-            psz += cch;
-            *psz++ = '/';
-            *psz++ = '*';
-            *psz++ = '\0';
-        }
-
-        resetStatsByPattern(szPat);
-    }
+        resetStatsByPattern(getNodePattern(pNode, fSubTree));
 }
 
@@ -2716 +2753 @@
 
 bool
-VBoxDbgStatsModelVM::updateStatsByPattern(const QString &a_rPatStr)
+VBoxDbgStatsModelVM::updateStatsByPattern(const QString &a_rPatStr, PDBGGUISTATSNODE a_pSubTree /*= NULL*/)
 {
     /** @todo the way we update this stuff is independent of the source (XML, file, STAM), our only
      * ASSUMPTION is that the input is strictly ordered by (fully slashed) name. So, all this stuff
      * should really move up into the parent class. */
-    bool fRc = updatePrepare();
+    bool fRc = updatePrepare(a_pSubTree);
     if (fRc)
     {
         int rc = stamEnum(a_rPatStr, updateCallback, this);
-        fRc = updateDone(RT_SUCCESS(rc));
+        fRc = updateDone(RT_SUCCESS(rc), a_pSubTree);
     }
     return fRc;