Changeset 101241 in vbox for trunk/src/VBox

Timestamp:

Sep 22, 2023 3:40:32 PM (16 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10513: Global Preferences: A bit of cleanup for Input and Proxy pages.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/global

Files:

• UIGlobalSettingsInput.cpp (modified) (3 diffs)
• UIGlobalSettingsInput.h (modified) (1 diff)
• UIGlobalSettingsProxy.cpp (modified) (3 diffs)
• UIGlobalSettingsProxy.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsInput.cpp

@@ -216 +216 @@
     /* Prepare everything: */
     prepareWidgets();
-    prepareConnections();
 
     /* Apply language settings: */
@@ -232 +231 @@
         if (m_pEditorShortcutConfiguration)
         {
+            connect(m_pEditorShortcutConfiguration, &UIShortcutConfigurationEditor::sigValueChanged,
+                    this, &UIGlobalSettingsInput::revalidate);
             addEditor(m_pEditorShortcutConfiguration);
             pLayout->addWidget(m_pEditorShortcutConfiguration);
@@ -244 +245 @@
         }
     }
-}
-
-void UIGlobalSettingsInput::prepareConnections()
-{
-    connect(m_pEditorShortcutConfiguration, &UIShortcutConfigurationEditor::sigValueChanged,
-            this, &UIGlobalSettingsInput::revalidate);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsInput.h

@@ -84 +84 @@
     /** Prepares widgets. */
     void prepareWidgets();
-    /** Prepares connections. */
-    void prepareConnections();
     /** Cleanups all. */
     void cleanup();

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsProxy.cpp

@@ -219 +219 @@
     /* Prepare everything: */
     prepareWidgets();
-    prepareConnections();
 
     /* Apply language settings: */
@@ -235 +234 @@
         if (m_pEditorProxyFeatures)
         {
+            connect(m_pEditorProxyFeatures, &UIProxyFeaturesEditor::sigProxyModeChanged,
+                    this, &UIGlobalSettingsProxy::revalidate);
+            connect(m_pEditorProxyFeatures, &UIProxyFeaturesEditor::sigProxyHostChanged,
+                    this, &UIGlobalSettingsProxy::revalidate);
             addEditor(m_pEditorProxyFeatures);
             pLayout->addWidget(m_pEditorProxyFeatures);
@@ -242 +245 @@
         pLayout->addStretch();
     }
-}
-
-void UIGlobalSettingsProxy::prepareConnections()
-{
-    connect(m_pEditorProxyFeatures, &UIProxyFeaturesEditor::sigProxyModeChanged,
-            this, &UIGlobalSettingsProxy::revalidate);
-    connect(m_pEditorProxyFeatures, &UIProxyFeaturesEditor::sigProxyHostChanged,
-            this, &UIGlobalSettingsProxy::revalidate);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsProxy.h

@@ -84 +84 @@
     /** Prepares wıdgets. */
     void prepareWidgets();
-    /** Prepares connections. */
-    void prepareConnections();
     /** Cleanups all. */
     void cleanup();