Changeset 101345 in vbox for trunk/include/VBox

Timestamp:

Oct 4, 2023 7:39:24 PM (16 months ago)

Author:

vboxsync

Message:

Main/Settings.cpp: Fixed incorrect and inefficient (you don't use find) endsWith() emulation in MachineConfigFile::convertGuestOSTypeSuffix (regression from r159257). Use new RTCString::endsWith methods. Untested. bugref:10384

File:

• trunk/include/VBox/settings.h (modified) (2 diffs)

trunk/include/VBox/settings.h

@@ -1562 +1562 @@
     static bool isAudioDriverAllowedOnThisHost(AudioDriverType_T enmDrvType);
     static AudioDriverType_T getHostDefaultAudioDriver();
-    static bool convertGuestOSTypeSuffix(com::Utf8Str &str, const char *pszToReplace, const char *pszReplacement);
 
 private:
@@ -1587 +1586 @@
     void readGroups(const xml::ElementNode &elmGroups, StringsList &llGroups);
     bool readSnapshot(const com::Guid &curSnapshotUuid, const xml::ElementNode &elmSnapshot, Snapshot &snap);
-    void convertGuestOSTypeFromPre1_5(com::Utf8Str &str);
-    void convertGuestOSTypeFromPre1_20(com::Utf8Str &str);
-    void convertGuestOSTypeToPre1_20(com::Utf8Str &str);
+    static void convertGuestOSTypeFromPre1_5(com::Utf8Str &str);
+    static void convertGuestOSTypeFromPre1_20(com::Utf8Str &str);
+    static void convertGuestOSTypeToPre1_20(com::Utf8Str &str);
+    static void convertGuestOSTypeSuffix(com::Utf8Str &str, const char *pszToReplace, const char *pszReplacement);
     void readMachine(const xml::ElementNode &elmMachine);
     void readMachineEncrypted(const xml::ElementNode &elmMachine, PCVBOXCRYPTOIF pCryptoIf, const char *pszPassword);