Changeset 101392 in vbox for trunk/src

Timestamp:

Oct 9, 2023 10:12:12 AM (19 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

159413

Message:

FE/Qt: bugref:10513: UISettingsSelector: Lots of cleanup for selector of tree-widget type.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsSelector.cpp (modified) (6 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsSelector.cpp ¶

@@ -321 +321 @@
 {
     QWidget *pResult = 0;
-    if (pPage != 0)
-    {
+    if (pPage)
+    {
+        /* Adjust page a bit: */
+        pPage->setContentsMargins(0, 0, 0, 0);
+        if (pPage->layout())
+            pPage->layout()->setContentsMargins(0, 0, 0, 0);
+        pResult = pPage;
+
+        /* Add selector-item object: */
         const QIcon icon = UIIconPool::iconSet(strMediumIcon);
-
         UISelectorItem *pItem = new UISelectorItem(icon, iID, strLink, pPage, iParentID);
-        m_list.append(pItem);
-
-        QTreeWidgetItem *pTwItem = new QITreeWidgetItem(m_pTreeWidget, QStringList() << QString("")
-                                                                                     << idToString(iID)
-                                                                                     << strLink);
-        pTwItem->setIcon(TreeWidgetSection_Category, pItem->icon());
-        pPage->setContentsMargins(0, 0, 0, 0);
-        pPage->layout()->setContentsMargins(0, 0, 0, 0);
-        pResult = pPage;
+        if (pItem)
+            m_list.append(pItem);
+
+        /* Add tree-widget item: */
+        QITreeWidgetItem *pTwItem = new QITreeWidgetItem(m_pTreeWidget, QStringList() << QString("")
+                                                                                      << idToString(iID)
+                                                                                      << strLink);
+        if (pTwItem)
+            pTwItem->setIcon(TreeWidgetSection_Category, pItem->icon());
     }
     return pResult;
@@ -341 +347 @@
 void UISettingsSelectorTreeWidget::setItemText(int iID, const QString &strText)
 {
+    /* Call to base-class: */
     UISettingsSelector::setItemText(iID, strText);
+
+    /* Look for the tree-widget item to assign the text: */
     QTreeWidgetItem *pItem = findItem(m_pTreeWidget, idToString(iID), TreeWidgetSection_Id);
     if (pItem)
@@ -380 +389 @@
 {
     /* Get recommended size hint: */
-    const QStyle *pStyle = QApplication::style();
-    const int iIconMetric = pStyle->pixelMetric(QStyle::PM_SmallIconSize);
-    int iItemWidth = static_cast<QAbstractItemView*>(m_pTreeWidget)->sizeHintForColumn(TreeWidgetSection_Category);
-    int iItemHeight = qMax((int)(iIconMetric * 1.5) /* icon height */,
-                           m_pTreeWidget->fontMetrics().height() /* text height */);
-    /* Add some margin to every item in the tree: */
-    iItemHeight += 4 /* margin itself */ * 2 /* margin count */;
+    const int iIconMetric = QApplication::style()->pixelMetric(QStyle::PM_SmallIconSize);
+    const int iItemWidth = static_cast<QAbstractItemView*>(m_pTreeWidget)->sizeHintForColumn(TreeWidgetSection_Category);
+    const int iItemHeight = qMax((int)(iIconMetric * 1.5) /* icon height */,
+                                 m_pTreeWidget->fontMetrics().height() /* text height */)
+                          + 4 /* margin itself */ * 2 /* margin count */;
+
     /* Set final size hint for items: */
     m_pTreeWidget->setSizeHintForItems(QSize(iItemWidth , iItemHeight));
@@ -392 +400 @@
     /* Adjust selector width/height: */
     m_pTreeWidget->setFixedWidth(iItemWidth + 2 * m_pTreeWidget->frameWidth());
-    m_pTreeWidget->setMinimumHeight(m_pTreeWidget->topLevelItemCount() * iItemHeight +
-                                    1 /* margin itself */ * 2 /* margin count */);
+    m_pTreeWidget->setMinimumHeight(  m_pTreeWidget->topLevelItemCount() * iItemHeight
+                                    + 1 /* margin itself */ * 2 /* margin count */);
 
     /* Sort selector by the id column: */
@@ -402 +410 @@
 }
 
-void UISettingsSelectorTreeWidget::sltSettingsGroupChanged(QTreeWidgetItem *pItem,
-                                                         QTreeWidgetItem * /* pPrevItem */)
+void UISettingsSelectorTreeWidget::sltSettingsGroupChanged(QTreeWidgetItem *pItem, QTreeWidgetItem * /* pPrevItem */)
 {
     if (pItem)
@@ -443 +450 @@
 QString UISettingsSelectorTreeWidget::pagePath(const QString &strMatch) const
 {
-    const QTreeWidgetItem *pTreeItem =
-        findItem(m_pTreeWidget,
-                 strMatch,
-                 TreeWidgetSection_Id);
+    const QTreeWidgetItem *pTreeItem = findItem(m_pTreeWidget, strMatch, TreeWidgetSection_Id);
     return path(pTreeItem);
 }
 
-QTreeWidgetItem *UISettingsSelectorTreeWidget::findItem(QTreeWidget *pView,
-                                                        const QString &strMatch,
-                                                        int iColumn) const
-{
-    QList<QTreeWidgetItem*> list =
-        pView->findItems(strMatch, Qt::MatchExactly, iColumn);
-
-    return list.count() ? list[0] : 0;
+QTreeWidgetItem *UISettingsSelectorTreeWidget::findItem(QTreeWidget *pView, const QString &strMatch, int iColumn) const
+{
+    const QList<QTreeWidgetItem*> list = pView->findItems(strMatch, Qt::MatchExactly, iColumn);
+    return list.count() ? list.first() : 0;
 }