Changeset 101669 in vbox

Timestamp:

Oct 31, 2023 4:47:47 AM (15 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10067: Notification-center: Do not delete notifications immediately in dismiss/close buttons handlers, perform async delete instead; This should help fixing use-after-free in QToolButton internals.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjectItem.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjectItem.cpp

@@ -104 +104 @@
                 m_pButtonForget->setIconSize(QSize(10, 10));
                 connect(m_pButtonForget, &QIToolButton::clicked,
-                        m_pObject, &UINotificationObject::dismiss);
+                        m_pObject, &UINotificationObject::dismiss,
+                        Qt::QueuedConnection);
 
                 m_pLayoutUpper->addWidget(m_pButtonForget);
@@ -116 +117 @@
                 m_pButtonClose->setIconSize(QSize(10, 10));
                 connect(m_pButtonClose, &QIToolButton::clicked,
-                        m_pObject, &UINotificationObject::close);
+                        m_pObject, &UINotificationObject::close,
+                        Qt::QueuedConnection);
 
                 m_pLayoutUpper->addWidget(m_pButtonClose);