Changeset 101720 in vbox

Timestamp:

Nov 2, 2023 3:21:13 PM (18 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

159814

Message:

Additions: Guest Library: Fix valgrind warnings about uninitialized memory usage, bugref:10194.

Location:

trunk/src/VBox/Additions/common/VBoxGuest/lib

Files:

• VBoxGuestR3Lib.cpp (modified) (1 diff)
• VBoxGuestR3LibClipboard.cpp (modified) (8 diffs)
• VBoxGuestR3LibGuestProp.cpp (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR3Lib.cpp

@@ -300 +300 @@
     {
         VBGLIOCDRIVERVERSIONINFO VerInfo;
+
+        RT_ZERO(VerInfo);
+
         VBGLREQHDR_INIT(&VerInfo.Hdr, DRIVER_VERSION_INFO);
         VerInfo.u.In.uMinVersion    = VBGL_IOC_VERSION & UINT32_C(0xffff0000);

trunk/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR3LibClipboard.cpp

@@ -159 +159 @@
                 {
                     VBoxShClParmNegotiateChunkSize MsgChunkSize;
+                    RT_ZERO(MsgChunkSize);
                     do
                     {
@@ -225 +226 @@
             HGCMFunctionParameter   f64Features1;
         } Msg;
+
+        RT_ZERO(Msg);
+
         VBGL_HGCM_HDR_INIT(&Msg.Hdr, idClient, VBOX_SHCL_GUEST_FN_REPORT_FEATURES, 2);
         VbglHGCMParmUInt64Set(&Msg.f64Features0, fGuestFeatures);
@@ -299 +303 @@
     } Msg;
 
+    RT_ZERO(Msg);
+
     VBGL_HGCM_HDR_INIT(&Msg.Hdr, pCtx->idClient, VBOX_SHCL_GUEST_FN_MSG_GET, 2);
     Msg.id64Context.SetUInt32(VBOX_SHCL_HOST_MSG_FORMATS_REPORT);
@@ -333 +339 @@
         HGCMFunctionParameter   f32Format;
     } Msg;
+
+    RT_ZERO(Msg);
 
     VBGL_HGCM_HDR_INIT(&Msg.Hdr, pCtx->idClient, VBOX_SHCL_GUEST_FN_MSG_GET, 2);
@@ -449 +457 @@
         VBoxShClParmDataRead Parms;
     } Msg;
+
+    RT_ZERO(Msg);
 
     VBGL_HGCM_HDR_INIT(&Msg.Hdr, idClient, VBOX_SHCL_GUEST_FN_DATA_READ, VBOX_SHCL_CPARMS_DATA_READ);
@@ -572 +582 @@
     } Msg;
     int rc;
+
+    RT_ZERO(Msg);
+
     if (!pCtx->fUseLegacyProtocol)
     {
@@ -2794 +2807 @@
     } Msg;
 
+    RT_ZERO(Msg);
+
     VBGL_HGCM_HDR_INIT(&Msg.Hdr, idClient, VBOX_SHCL_GUEST_FN_REPORT_FORMATS, VBOX_SHCL_CPARMS_REPORT_FORMATS);
     VbglHGCMParmUInt32Set(&Msg.Parms.f32Formats, fFormats);
@@ -2869 +2884 @@
         } Msg;
 
+        RT_ZERO(Msg);
+
         VBGL_HGCM_HDR_INIT(&Msg.Hdr, pCtx->idClient, VBOX_SHCL_GUEST_FN_DATA_WRITE, VBOX_SHCL_CPARMS_DATA_WRITE);
         Msg.Parms.id64Context.SetUInt64(pCtx->idContext);

trunk/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR3LibGuestProp.cpp

@@ -962 +962 @@
      */
     GuestPropMsgGetNotification Msg;
+    RT_ZERO(Msg);
+
     VBGL_HGCM_HDR_INIT_TIMED(&Msg.hdr, idClient, GUEST_PROP_FN_GET_NOTIFICATION, 4, cMillies);