Changeset 101915 in vbox

Timestamp:

Nov 7, 2023 9:13:04 AM (15 months ago)

Author:

vboxsync

Message:

libs/xpcom: Remove some unused code in ipcdclient.cpp, bugref:10545

File:

• trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcdclient.cpp (modified) (10 diffs)

trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcdclient.cpp

@@ -59 +59 @@
 #include "pratom.h"
 
-#ifdef VBOX
-# include <iprt/critsect.h>
-# define VBOX_WITH_IPCCLIENT_RW_CS
-#endif
+#include <iprt/critsect.h>
 
 /* ------------------------------------------------------------------------- */
@@ -152 +149 @@
   ~ipcClientState()
   {
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-    if (monitor)
-      nsAutoMonitor::DestroyMonitor(monitor);
-#else
     RTCritSectRwDelete(&critSect);
-#endif
-  }
-
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-  //
-  // the monitor protects the targetMap and the connected and shutdown flags.
-  //
-  // NOTE: we use a PRMonitor for this instead of a PRLock because we need
-  //       the lock to be re-entrant.  since we don't ever need to wait on
-  //       this monitor, it might be worth it to implement a re-entrant
-  //       wrapper for PRLock.
-  //
-  PRMonitor    *monitor;
-#else  /* VBOX_WITH_IPCCLIENT_RW_CS */
+  }
+
   RTCRITSECTRW  critSect;
-#endif /* VBOX_WITH_IPCCLIENT_RW_CS */
   ipcTargetMap  targetMap;
   PRBool        connected;
@@ -185 +165 @@
 
   ipcClientState()
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-    : monitor(nsAutoMonitor::NewMonitor("ipcClientState"))
-    , connected(PR_FALSE)
-#else
     : connected(PR_FALSE)
-#endif
     , shutdown(PR_FALSE)
     , selfID(0)
   {
-#ifdef VBOX_WITH_IPCCLIENT_RW_CS
     /* Not employing the lock validator here to keep performance up in debug builds. */
     RTCritSectRwInitEx(&critSect, RTCRITSECT_FLAGS_NO_LOCK_VAL, NIL_RTLOCKVALCLASS, RTLOCKVAL_SUB_CLASS_NONE, NULL);
-#endif
   }
 };
@@ -208 +181 @@
     return NULL;
 
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-  if (!cs->monitor || !cs->targetMap.Init())
-#else
   if (!RTCritSectRwIsInitialized(&cs->critSect) || !cs->targetMap.Init())
-#endif
   {
     delete cs;
@@ -228 +197 @@
 GetTarget(const nsID &aTarget, ipcTargetData **td)
 {
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-  nsAutoMonitor mon(gClientState->monitor);
-  return gClientState->targetMap.Get(nsIDHashKey(&aTarget).GetKey(), td);
-#else
   RTCritSectRwEnterShared(&gClientState->critSect);
   PRBool fRc = gClientState->targetMap.Get(nsIDHashKey(&aTarget).GetKey(), td);
   RTCritSectRwLeaveShared(&gClientState->critSect);
   return fRc;
-#endif
 }
 
@@ -242 +206 @@
 PutTarget(const nsID &aTarget, ipcTargetData *td)
 {
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-  nsAutoMonitor mon(gClientState->monitor);
-  return gClientState->targetMap.Put(nsIDHashKey(&aTarget).GetKey(), td);
-#else
   RTCritSectRwEnterExcl(&gClientState->critSect);
   PRBool fRc = gClientState->targetMap.Put(nsIDHashKey(&aTarget).GetKey(), td);
   RTCritSectRwLeaveExcl(&gClientState->critSect);
   return fRc;
-#endif
 }
 
@@ -256 +215 @@
 DelTarget(const nsID &aTarget)
 {
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-  nsAutoMonitor mon(gClientState->monitor);
-  gClientState->targetMap.Remove(nsIDHashKey(&aTarget).GetKey());
-#else
   RTCritSectRwEnterExcl(&gClientState->critSect);
   gClientState->targetMap.Remove(nsIDHashKey(&aTarget).GetKey());
   RTCritSectRwLeaveExcl(&gClientState->critSect);
-#endif
 }
 
@@ -857 +811 @@
       // all targets but IPCM will not be able to use WaitTarget any more.
 
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-      nsAutoMonitor mon(gClientState->monitor);
-#else
       RTCritSectRwEnterExcl(&gClientState->critSect);
-#endif
-
       gClientState->shutdown = PR_TRUE;
       gClientState->targetMap.EnumerateRead(EnumerateTargetMapAndNotify, nsnull);
-
-#ifdef VBOX_WITH_IPCCLIENT_RW_CS
       RTCritSectRwLeaveExcl(&gClientState->critSect);
-#endif
     }
 
@@ -1357 +1303 @@
   // unblock any calls to WaitTarget.
 
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-  nsAutoMonitor mon(gClientState->monitor);
-#else
   RTCritSectRwEnterExcl(&gClientState->critSect);
-#endif
-
   gClientState->connected = PR_FALSE;
   gClientState->targetMap.EnumerateRead(EnumerateTargetMapAndNotify, nsnull);
-
-#ifdef VBOX_WITH_IPCCLIENT_RW_CS
   RTCritSectRwLeaveExcl(&gClientState->critSect);
-#endif
 }
 
@@ -1469 +1407 @@
         // targets) giving them an opportuninty to finish wait cycle because of
         // the peer client death, when appropriate.
-#ifndef VBOX_WITH_IPCCLIENT_RW_CS
-        nsAutoMonitor mon(gClientState->monitor);
-#else
         RTCritSectRwEnterShared(&gClientState->critSect);
-#endif
-
         gClientState->targetMap.EnumerateRead(EnumerateTargetMapAndPlaceMsg, msg);
-
-#ifdef VBOX_WITH_IPCCLIENT_RW_CS
         RTCritSectRwLeaveShared(&gClientState->critSect);
-#endif
+
         delete msg;
-
         return;
       }