Changeset 101933 in vbox

Timestamp:

Nov 7, 2023 11:38:27 AM (15 months ago)

Author:

vboxsync

Message:

libs/xpcom: Remove support for IPC modules which we never used (ipcModuleCount is always 0 and the directory where modules are looked for doesn't exist), bugref:10545

Location:

trunk/src/libs/xpcom18a4

Files:

• Makefile.kmk (modified) (2 diffs)
• ipc/ipcd/daemon/public (deleted)
• ipc/ipcd/daemon/src/ipcClient.cpp (modified) (1 diff)
• ipc/ipcd/daemon/src/ipcCommandModule.cpp (modified) (1 diff)
• ipc/ipcd/daemon/src/ipcModuleReg.cpp (deleted)
• ipc/ipcd/daemon/src/ipcModuleReg.h (deleted)
• ipc/ipcd/daemon/src/ipcd.cpp (modified) (4 diffs)
• ipc/ipcd/daemon/src/ipcdUnix.cpp (modified) (3 diffs)

trunk/src/libs/xpcom18a4/Makefile.kmk

@@ -360 +360 @@
         ipc/ipcd/util/public/ipcMessageReader.h \
         ipc/ipcd/util/public/ipcMessageWriter.h \
-        ipc/ipcd/daemon/public/ipcModule.h \
-        ipc/ipcd/daemon/public/ipcModuleUtil.h \
         ipc/ipcd/client/public/ipcdclient.h
 
@@ -986 +984 @@
         ipc/ipcd/daemon/src/ipcd.cpp \
         ipc/ipcd/daemon/src/ipcClient.cpp \
-        ipc/ipcd/daemon/src/ipcModuleReg.cpp \
         ipc/ipcd/daemon/src/ipcCommandModule.cpp \
         ipc/ipcd/daemon/src/ipcdUnix.cpp

trunk/src/libs/xpcom18a4/ipc/ipcd/daemon/src/ipcClient.cpp

@@ -39 +39 @@
 #include "ipcClient.h"
 #include "ipcMessage.h"
-#include "ipcModuleReg.h"
 #include "ipcd.h"
 #include "ipcm.h"

trunk/src/libs/xpcom18a4/ipc/ipcd/daemon/src/ipcCommandModule.cpp

@@ -44 +44 @@
 #include "ipcMessage.h"
 #include "ipcMessageUtils.h"
-#include "ipcModuleReg.h"
 #include "ipcd.h"
 #include "ipcm.h"

trunk/src/libs/xpcom18a4/ipc/ipcd/daemon/src/ipcd.cpp

@@ -43 +43 @@
 #include "ipcMessage.h"
 #include "ipcClient.h"
-#include "ipcModuleReg.h"
-#include "ipcModule.h"
 #include "ipcCommandModule.h"
 #include "ipcdPrivate.h"
@@ -84 +82 @@
     }
 
-    return IPC_DispatchMsg(client, msg->Target(), msg->Data(), msg->DataLen());
+    return PR_SUCCESS;
 }
 
@@ -120 +118 @@
     LOG(("IPC_NotifyClientUp: clientID=%d\n", client->ID()));
 
-    // notify modules before other clients
-    IPC_NotifyModulesClientUp(client);
-
     for (int i=0; i<ipcClientCount; ++i) {
         if (&ipcClients[i] != client)
@@ -134 +129 @@
 {
     LOG(("IPC_NotifyClientDown: clientID=%d\n", client->ID()));
-
-    // notify modules before other clients
-    IPC_NotifyModulesClientDown(client);
 
     for (int i=0; i<ipcClientCount; ++i) {

trunk/src/libs/xpcom18a4/ipc/ipcd/daemon/src/ipcdUnix.cpp

@@ -65 +65 @@
 #include "ipcMessage.h"
 #include "ipcClient.h"
-#include "ipcModuleReg.h"
 #include "ipcdPrivate.h"
 #include "ipcd.h"
@@ -532 +531 @@
     }
     else {
-        IPC_InitModuleReg(argv[0]);
-
 #ifdef VBOX
         // Use large backlog, as otherwise local sockets can reject connection
@@ -578 +575 @@
             PollLoop(listenFD);
         }
-
-        IPC_ShutdownModuleReg();
     }