Changeset 101953 in vbox for trunk/src/VBox

Timestamp:

Nov 8, 2023 2:18:15 AM (13 months ago)

Author:

vboxsync

Message:

VMM/IEM: Removed IEM_MC_ASSIGN as it's not unused. bugref:10371

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllInstPython.py (modified) (1 diff)
• VMMAll/IEMAllInstVexMap1.cpp.h (modified) (1 diff)
• include/IEMMc.h (modified) (1 diff)
• testcase/tstIEMCheckMc.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllInstPython.py

@@ -2746 +2746 @@
     'IEM_MC_ARG_LOCAL_EFLAGS':                                   (McBlock.parseMcArgLocalEFlags,    False, True,  ),
     'IEM_MC_ARG_LOCAL_REF':                                      (McBlock.parseMcArgLocalRef,       False, True,  ),
-    'IEM_MC_ASSIGN':                                             (McBlock.parseMcGeneric,           False, False, ),
     'IEM_MC_ASSIGN_TO_SMALLER':                                  (McBlock.parseMcGeneric,           False, False, ),
     'IEM_MC_ASSIGN_U8_SX_U64':                                   (McBlock.parseMcGeneric,           False, False, ),

trunk/src/VBox/VMM/VMMAll/IEMAllInstVexMap1.cpp.h

@@ -4235 +4235 @@
 //    IEMOP_MNEMONIC1(M_MEM, VLDMXCSR, vldmxcsr, MdRO, DISOPTYPE_HARMLESS, IEMOPHINT_IGNORES_OP_SIZES);
 //    IEM_MC_BEGIN(2, 0, IEM_MC_F_NOT_286_OR_OLDER, 0);
-//    IEM_MC_ARG(uint8_t,         iEffSeg,                                 0);
 //    IEM_MC_ARG(RTGCPTR,         GCPtrEff,                                1);
 //    IEM_MC_CALC_RM_EFF_ADDR(GCPtrEff, bRm, 0);
 //    IEMOP_HLP_DONE_VEX_DECODING_L0_AND_NO_VVVV_EX(fAvx);
 //    IEM_MC_ACTUALIZE_SSE_STATE_FOR_READ();
-//    IEM_MC_ASSIGN(iEffSeg, pVCpu->iem.s.iEffSeg);
+//    IEM_MC_ARG_CONST(uint8_t,   iEffSeg, /*=*/ pVCpu->iem.s.iEffSeg,     0);
 //    IEM_MC_CALL_CIMPL_2(iemCImpl_ldmxcsr, iEffSeg, GCPtrEff);
 //    IEM_MC_END();

trunk/src/VBox/VMM/include/IEMMc.h

@@ -207 +207 @@
    do { pVCpu->cpum.GstCtx.eflags.u = (a_EFlags); Assert(pVCpu->cpum.GstCtx.eflags.u & X86_EFL_1); } while (0)
 
-#define IEM_MC_ASSIGN(a_VarOrArg, a_CVariableOrConst)   (a_VarOrArg) = (a_CVariableOrConst)
-#define IEM_MC_ASSIGN_TO_SMALLER                        IEM_MC_ASSIGN
+#define IEM_MC_ASSIGN_TO_SMALLER(a_VarOrArg, a_CVariableOrConst) (a_VarOrArg) = (a_CVariableOrConst)
 #define IEM_MC_ASSIGN_U8_SX_U64(a_u64VarOrArg, a_u8CVariableOrConst) \
    (a_u64VarOrArg) = (int8_t)(a_u8CVariableOrConst)

trunk/src/VBox/VMM/testcase/tstIEMCheckMc.cpp

@@ -632 +632 @@
 
 #define IEM_MC_COMMIT_EFLAGS(a_EFlags)                  do { CHK_TYPE(uint32_t, a_EFlags); (void)fMcBegin; } while (0)
-#define IEM_MC_ASSIGN(a_VarOrArg, a_CVariableOrConst)   do { (a_VarOrArg) = (0); (void)fMcBegin; } while (0)
-#define IEM_MC_ASSIGN_TO_SMALLER                        IEM_MC_ASSIGN
-#define IEM_MC_ASSIGN_U8_SX_U64                         IEM_MC_ASSIGN
-#define IEM_MC_ASSIGN_U32_SX_U64                        IEM_MC_ASSIGN
+#define IEM_MC_ASSIGN_TO_SMALLER(a_VarOrArg, a_CVariableOrConst)    do { (a_VarOrArg) = (0); (void)fMcBegin; } while (0)
+#define IEM_MC_ASSIGN_U8_SX_U64(a_VarOrArg, a_CVariableOrConst)     do { (a_VarOrArg) = (0); (void)fMcBegin; } while (0)
+#define IEM_MC_ASSIGN_U32_SX_U64(a_VarOrArg, a_CVariableOrConst)    do { (a_VarOrArg) = (0); (void)fMcBegin; } while (0)
 
 #define IEM_MC_FETCH_GREG_U8(a_u8Dst, a_iGReg)          do { (a_u8Dst)  = 0; CHK_TYPE(uint8_t,  a_u8Dst);  CHK_GREG_IDX(a_iGReg); (void)fMcBegin; } while (0)