Changeset 102059 in vbox for trunk/src/VBox/VMM

Timestamp:

Nov 10, 2023 8:26:16 AM (15 months ago)

Author:

vboxsync

Message:

VMM/PGM: Nested VMX: bugref:10318 Disabled overly strict assertion for Windows 10 Hyper-V.

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllBth.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -3008 +3008 @@
         PGMPOOLACCESS enmAccess;
         {
-            Assert(!(pGstWalkAll->u.Ept.Pde.u & EPT_E_USER_EXECUTE));  /* Mode-based execute control for EPT not supported. */
+            /*
+             * Mode-based execute control for EPT not supported. 
+             *  
+             * However, Windows 10 with Hyper-V enabled sets the EPT_E_USER_EXECUTE bit but does 
+             * not enable "mode-based execute control for EPT" in the VT-x secondary VM-execution 
+             * controls. The CPU ignores this bit when the control isn't set. Hence, the assertion 
+             * below is commented out.
+             */
+            /* Assert(!(pGstWalkAll->u.Ept.Pde.u & EPT_E_USER_EXECUTE)); */
+            Assert(!pVCpu->CTX_SUFF(pVM)->cpum.ro.GuestFeatures.fVmxModeBasedExecuteEpt);
             bool const fNoExecute = !(pGstWalkAll->u.Ept.Pde.u & EPT_E_EXECUTE);
             if (pGstWalkAll->u.Ept.Pde.u & EPT_E_WRITE)