Changeset 102087 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Nov 13, 2023 4:17:15 PM (16 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

160198

Message:

FE/Qt: bugref:10513: UIAdvancedSettingsDialog: Make sure previously chosen page persists through experience mode change; That is necessary because mode change involves widget filtering thus invalidating vertical scroll-bar position which needs to be recalculated again.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings

Files:

• UIAdvancedSettingsDialog.cpp (modified) (3 diffs)
• UIAdvancedSettingsDialog.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.cpp

@@ -597 +597 @@
     , m_fSerializationClean(false)
     , m_fClosed(false)
+    , m_iPageId(0)
     , m_pStatusBar(0)
     , m_pProcessBar(0)
@@ -641 +642 @@
 #endif
 
-    /* Let's calculate scroll-bar shift: */
-    int iShift = 0;
+    /* Cache current page ID for reusing: */
+    m_iPageId = cId;
+
+    /* Let's calculate required scroll-bar position: */
+    int iPosition = 0;
     /* We'll have to take upper content's margin into account: */
     int iL, iT, iR, iB;
     m_pScrollViewport->layout()->getContentsMargins(&iL, &iT, &iR, &iB);
-    iShift -= iT;
+    iPosition -= iT;
     /* And actual page position according to parent: */
-    const QPoint pnt = m_frames.value(cId)->pos();
-    iShift += pnt.y();
+    const QPoint pnt = m_frames.value(m_iPageId)->pos();
+    iPosition += pnt.y();
     /* Make sure corresponding page is visible: */
-    m_pScrollArea->requestVerticalScrollBarPosition(iShift);
+    m_pScrollArea->requestVerticalScrollBarPosition(iPosition);
 
 #ifndef VBOX_WS_MAC
@@ -1110 +1114 @@
                           m_pEditorFilter->text(),
                           m_flags);
+
+    /* Make sure current page chosen again: */
+    /// @todo fix this WORKAROUND properly!
+    // Why the heck simple call to
+    // QCoreApplication::sendPostedEvents(0, QEvent::LayoutRequest);
+    // isn't enough and we still need some time to let system
+    // process the layouts and vertical scroll-bar position?
+    QTimer::singleShot(50, this, SLOT(sltCategoryChangedRepeat()));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.h

@@ -100 +100 @@
     /** Handles category change to @a cId. */
     virtual void sltCategoryChanged(int cId);
+    /** Repeats handling for category change to cached @a m_iPageId. */
+    virtual void sltCategoryChangedRepeat() { sltCategoryChanged(m_iPageId); }
 
     /** Handles serializartion start. */
@@ -241 +243 @@
     bool  m_fClosed;
 
+    /** Holds the current page ID. */
+    int  m_iPageId;
+
     /** Holds the dialog optional flags. */
     QMap<QString, QVariant>  m_flags;