Changeset 102110 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Nov 15, 2023 3:54:09 PM (16 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

160231

Message:

FE/Qt: bugref:10513: VBox Manager: Update Machine tools menu right before it it shown, not on current-item change as this cache can be invalidated in the meantime.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIVirtualBoxManagerWidget.cpp (modified) (3 diffs)
• UIVirtualBoxManagerWidget.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManagerWidget.cpp

@@ -542 +542 @@
     {
         case UIToolClass_Global: pMenu = m_pMenuToolsGlobal; break;
-        case UIToolClass_Machine: pMenu = m_pMenuToolsMachine; break;
+        case UIToolClass_Machine: pMenu = m_pMenuToolsMachine; updateToolsMenuMachine(); break;
         default: break;
     }
@@ -1117 +1117 @@
 }
 
-void UIVirtualBoxManagerWidget::recacheCurrentItemInformation(bool fDontRaiseErrorPane /* = false */)
+void UIVirtualBoxManagerWidget::updateToolsMenuMachine()
 {
     /* Get current item: */
@@ -1136 +1136 @@
     foreach (const UIToolType &enmRestrictedType, retrictedTypes)
         m_pPaneToolsMachine->closeTool(enmRestrictedType);
+}
+
+void UIVirtualBoxManagerWidget::recacheCurrentItemInformation(bool fDontRaiseErrorPane /* = false */)
+{
+    /* Get current item: */
+    UIVirtualMachineItem *pItem = currentItem();
+    const bool fCurrentItemIsOk = pItem && pItem->accessible();
 
     /* Propagate current item anyway: */

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManagerWidget.h

@@ -341 +341 @@
     /** @name Tools / Common stuff.
       * @{ */
+        /** Updates Machine tools menu. */
+        void updateToolsMenuMachine();
+
         /** Recaches current item information.
           * @param  fDontRaiseErrorPane  Brings whether we should not raise error-pane. */