Changeset 102115 in vbox for trunk/src/VBox/GuestHost/SharedClipboard

Timestamp:

Nov 15, 2023 6:55:50 PM (15 months ago)

Author:

vboxsync

Message:

Shared Clipboard: Better error case handling in ShClTransferHttpServerRegisterTransfer(). bugref:9437

File:

• trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers-http.cpp (modified) (1 diff)

trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers-http.cpp

@@ -933 +933 @@
             pszPath = NULL;
 
-            AssertRCReturn(rc, rc);
-
-            pSrvTx->pTransfer = pTransfer;
-            pSrvTx->hObj      = NIL_SHCLOBJHANDLE;
-
-            RTListAppend(&pSrv->lstTransfers, &pSrvTx->Node);
-            pSrv->cTransfers++;
-
-            shclTransferHttpServerSetStatusLocked(pSrv, SHCLHTTPSERVERSTATUS_TRANSFER_REGISTERED);
-
-            LogFunc(("pTransfer=%p, idTransfer=%RU16, szPath=%s -> %RU32 transfers\n",
-                     pSrvTx->pTransfer, pSrvTx->pTransfer->State.uID, pSrvTx->szPathVirtual, pSrv->cTransfers));
-
-            LogRel2(("Shared Clipboard: Registered HTTP transfer %RU16, now %RU32 HTTP transfers total\n",
-                     pTransfer->State.uID, pSrv->cTransfers));
+            if (RT_SUCCESS(rc))
+            {
+                pSrvTx->pTransfer = pTransfer;
+                pSrvTx->hObj      = NIL_SHCLOBJHANDLE;
+
+                RTListAppend(&pSrv->lstTransfers, &pSrvTx->Node);
+                pSrv->cTransfers++;
+
+                shclTransferHttpServerSetStatusLocked(pSrv, SHCLHTTPSERVERSTATUS_TRANSFER_REGISTERED);
+
+                LogFunc(("pTransfer=%p, idTransfer=%RU16, szPath=%s -> %RU32 transfers\n",
+                         pSrvTx->pTransfer, pSrvTx->pTransfer->State.uID, pSrvTx->szPathVirtual, pSrv->cTransfers));
+
+                LogRel2(("Shared Clipboard: Registered HTTP transfer %RU16, now %RU32 HTTP transfers total\n",
+                         pTransfer->State.uID, pSrv->cTransfers));
+            }
         }