Changeset 102160 in vbox

Timestamp:

Nov 20, 2023 5:24:27 PM (12 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10513: UIAdvancedSettingsDialog: Make sure both x86 and ARM platform types defined when appropriate; Previously we were passing through only ARM platform type, keeping the value underfined for x86 since it was always default; Now we need to be a bit more determined.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings

Files:

• UIAdvancedSettingsDialog.cpp (modified) (1 diff)
• UIAdvancedSettingsDialogSpecific.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.cpp

@@ -959 +959 @@
         /* Create validator: */
         UISettingsPageValidator *pValidator = new UISettingsPageValidator(this, pSettingsPage);
-        connect(pValidator, &UISettingsPageValidator::sigValidityChanged, this, &UIAdvancedSettingsDialog::sltHandleValidityChange);
+        connect(pValidator, &UISettingsPageValidator::sigValidityChanged,
+                this, &UIAdvancedSettingsDialog::sltHandleValidityChange);
         pSettingsPage->setValidator(pValidator);
         m_pWarningPane->registerValidator(pValidator);

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialogSpecific.cpp

@@ -783 +783 @@
             switch (enmArch)
             {
-                /* For x86 we no need the flag at all, removing if present: */
-                case KPlatformArchitecture_x86: optFlags.remove("arch"); break;
-                /* For rest of platforms we need the flag: */
-                default: optFlags["arch"] = QVariant::fromValue(enmArch); break;
+                /* For x86/ARM we'll set the flag: */
+                case KPlatformArchitecture_x86:
+                case KPlatformArchitecture_ARM:
+                    optFlags["arch"] = QVariant::fromValue(enmArch);
+                    break;
+                /* For rest of platforms (+None) we'll remove it: */
+                default:
+                    optFlags.remove("arch");
+                    break;
             }
             setOptionalFlags(optFlags);