Changeset 102249 in vbox for trunk/src/libs/xpcom18a4/ipc/ipcd

Timestamp:

Nov 22, 2023 11:29:30 AM (14 months ago)

Author:

vboxsync

Message:

libs/xpcom/ipc: Get Convert IPC logging to use IPRT Log() macros directly, bugref:10545

Location:

trunk/src/libs/xpcom18a4/ipc/ipcd

Files:

• client/src/ipcdclient.cpp (modified) (15 diffs)
• daemon/src/ipcCommandModule.cpp (modified) (20 diffs)
• daemon/src/ipcd.cpp (modified) (1 diff)
• extensions/dconnect/src/ipcDConnectService.cpp (modified) (56 diffs)
• extensions/lock/src/ipcLockService.cpp (modified) (6 diffs)
• shared/src/ipcConfig.cpp (modified) (3 diffs)
• shared/src/ipcLog.cpp (deleted)
• shared/src/ipcLog.h (deleted)

trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcdclient.cpp

@@ -35 +35 @@
  *
  * ***** END LICENSE BLOCK ***** */
-
+#define LOG_GROUP LOG_GROUP_IPC
 #include "ipcdclient.h"
 #include "ipcConnection.h"
@@ -41 +41 @@
 #include "ipcMessageQ.h"
 #include "ipcMessageUtils.h"
-#include "ipcLog.h"
 #include "ipcm.h"
 
@@ -62 +61 @@
 #include <iprt/process.h>
 #include <iprt/string.h>
+
+#include <VBox/log.h>
 
 /* ------------------------------------------------------------------------- */
@@ -280 +281 @@
       NS_ASSERTION(aTarget.Equals(IPCM_TARGET) || msg->Target().Equals(IPCM_TARGET),
                    "unexpected target");
-      LOG(("dropping IPCM message: type=%x\n", IPCM_GetType(msg)));
+      Log(("dropping IPCM message: type=%x\n", IPCM_GetType(msg)));
     }
     tempQ.DeleteFirst();
@@ -447 +448 @@
     mon.Wait(timeEnd - t);
 
-    LOG(("woke up from sleep [pendingQempty=%d connected=%d shutdown=%d isIPCMTarget=%d]\n",
+    Log(("woke up from sleep [pendingQempty=%d connected=%d shutdown=%d isIPCMTarget=%d]\n",
           td->pendingQ.IsEmpty(), gClientState->connected,
           gClientState->shutdown, isIPCMTarget));
@@ -694 +695 @@
     nsresult rv = MakeIPCMRequest(new ipcmMessageClientDelTarget(aTarget));
     if (NS_FAILED(rv))
-      LOG(("failed to delete target: rv=%x\n", rv));
+      Log(("failed to delete target: rv=%x\n", rv));
   }
 }
@@ -720 +721 @@
     if (NS_FAILED(rv))
     {
-      LOG(("failed to add target: rv=%x\n", rv));
+      Log(("failed to add target: rv=%x\n", rv));
       RemoveTarget(aTarget, PR_FALSE);
       return rv;
@@ -768 +769 @@
   else
   {
-    LOG(("unexpected response from CLIENT_HELLO message: type=%x!\n",
+    Log(("unexpected response from CLIENT_HELLO message: type=%x!\n",
         IPCM_GetType(msg)));
     rv = NS_ERROR_UNEXPECTED;
@@ -781 +782 @@
 {
   NS_ENSURE_TRUE(!gClientState, NS_ERROR_ALREADY_INITIALIZED);
-
-  IPC_InitLog(">>>");
 
   gClientState = ipcClientState::Create();
@@ -805 +804 @@
   NS_ENSURE_TRUE(gClientState, NS_ERROR_NOT_INITIALIZED);
 
-  LOG(("IPC_Shutdown: connected=%d\n",gClientState->connected));
+  Log(("IPC_Shutdown: connected=%d\n",gClientState->connected));
 
   if (gClientState->connected)
@@ -990 +989 @@
             status->ClientState() == IPCM_CLIENT_STATE_DOWN)
         {
-          LOG(("sender (%d) we're waiting a message from (%d) has died\n",
+          Log(("sender (%d) we're waiting a message from (%d) has died\n",
                status->ClientID(), data->senderID));
 
@@ -1024 +1023 @@
                  status->ClientState() == IPCM_CLIENT_STATE_UP)
         {
-          LOG(("sender (%d) we're waiting a message from (%d) has come up\n",
+          Log(("sender (%d) we're waiting a message from (%d) has come up\n",
                status->ClientID(), data->senderID));
           if (data->senderID == IPC_SENDER_ANY)
@@ -1195 +1194 @@
   else
   {
-    LOG(("unexpected IPCM response: type=%x\n", IPCM_GetType(msg)));
+    Log(("unexpected IPCM response: type=%x\n", IPCM_GetType(msg)));
     rv = NS_ERROR_UNEXPECTED;
   }
@@ -1321 +1320 @@
   td->pendingQ.Append(msg);
 
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
+#ifdef LOG_ENABLED
   {
     char *targetStr = target.ToString();
-    LOG(("placed message on pending queue for target %s and notifying all...\n", targetStr));
+    Log(("placed message on pending queue for target %s and notifying all...\n", targetStr));
     nsMemory::Free(targetStr);
   }
@@ -1355 +1353 @@
 /* ------------------------------------------------------------------------- */
 
-#ifdef IPC_LOGGING
-#include "prprf.h"
-#include <ctype.h>
-#endif
-
 // called on a background thread
 void
 IPC_OnMessageAvailable(ipcMessage *msg)
 {
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
+#ifdef LOG_ENABLED
   {
     char *targetStr = msg->Target().ToString();
-    LOG(("got message for target: %s\n", targetStr));
+    Log(("got message for target: %s\n", targetStr));
     nsMemory::Free(targetStr);
 

trunk/src/libs/xpcom18a4/ipc/ipcd/daemon/src/ipcCommandModule.cpp

@@ -35 +35 @@
  *
  * ***** END LICENSE BLOCK ***** */
-
+#define LOG_GROUP LOG_GROUP_IPC
 #include <stdlib.h>
 #include <string.h>
-#include "ipcLog.h"
 #include "ipcCommandModule.h"
 #include "ipcClient.h"
@@ -46 +45 @@
 #include "ipcm.h"
 
+#include <VBox/log.h>
+
 struct ipcCommandModule
 {
@@ -104 +105 @@
     OnPing(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got PING\n"));
+        Log(("got PING\n"));
 
         IPC_SendMsg(client, new ipcmMessageResult(IPCM_GetRequestIndex(rawMsg), IPCM_OK));
@@ -112 +113 @@
     OnClientHello(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got CLIENT_HELLO\n"));
+        Log(("got CLIENT_HELLO\n"));
 
         IPC_SendMsg(client, new ipcmMessageClientID(IPCM_GetRequestIndex(rawMsg), client->ID()));
@@ -129 +130 @@
     OnClientAddName(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got CLIENT_ADD_NAME\n"));
+        Log(("got CLIENT_ADD_NAME\n"));
 
         PRInt32 status = IPCM_OK;
@@ -139 +140 @@
             ipcClient *result = IPC_GetClientByName(msg->Name());
             if (result) {
-                LOG(("  client with such name already exists (ID = %d)\n", result->ID()));
+                Log(("  client with such name already exists (ID = %d)\n", result->ID()));
                 status = IPCM_ERROR_ALREADY_EXISTS;
             }
@@ -154 +155 @@
     OnClientDelName(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got CLIENT_DEL_NAME\n"));
+        Log(("got CLIENT_DEL_NAME\n"));
 
         PRInt32 status = IPCM_OK;
@@ -163 +164 @@
         if (name) {
             if (!client->DelName(name)) {
-                LOG(("  client doesn't have name '%s'\n", name));
+                Log(("  client doesn't have name '%s'\n", name));
                 status = IPCM_ERROR_NO_SUCH_DATA;
             }
@@ -176 +177 @@
     OnClientAddTarget(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got CLIENT_ADD_TARGET\n"));
+        Log(("got CLIENT_ADD_TARGET\n"));
 
         PRInt32 status = IPCM_OK;
@@ -183 +184 @@
         ipcMessageCast<ipcmMessageClientAddTarget> msg(rawMsg);
         if (client->HasTarget(msg->Target())) {
-            LOG(("  target already defined for client\n"));
+            Log(("  target already defined for client\n"));
             status = IPCM_ERROR_ALREADY_EXISTS;
         }
@@ -195 +196 @@
     OnClientDelTarget(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got CLIENT_DEL_TARGET\n"));
+        Log(("got CLIENT_DEL_TARGET\n"));
 
         PRInt32 status = IPCM_OK;
@@ -202 +203 @@
         ipcMessageCast<ipcmMessageClientDelTarget> msg(rawMsg);
         if (!client->DelTarget(msg->Target())) {
-            LOG(("  client doesn't have the given target\n"));
+            Log(("  client doesn't have the given target\n"));
             status = IPCM_ERROR_NO_SUCH_DATA;
         }
@@ -212 +213 @@
     OnQueryClientByName(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got QUERY_CLIENT_BY_NAME\n"));
+        Log(("got QUERY_CLIENT_BY_NAME\n"));
 
         PRUint32 requestIndex = IPCM_GetRequestIndex(rawMsg);
@@ -220 +221 @@
         ipcClient *result = IPC_GetClientByName(msg->Name());
         if (result) {
-            LOG(("  client exists w/ ID = %u\n", result->ID()));
+            Log(("  client exists w/ ID = %u\n", result->ID()));
             IPC_SendMsg(client, new ipcmMessageClientID(requestIndex, result->ID()));
         }
         else {
-            LOG(("  client does not exist\n"));
+            Log(("  client does not exist\n"));
             IPC_SendMsg(client, new ipcmMessageResult(requestIndex, IPCM_ERROR_NO_CLIENT));
         }
@@ -233 +234 @@
     OnQueryClientInfo(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got QUERY_CLIENT_INFO\n"));
+        Log(("got QUERY_CLIENT_INFO\n"));
 
         ipcMessageCast<ipcmMessageQueryClientInfo> msg(rawMsg);
@@ -250 +251 @@
         }
         else {
-            LOG(("  client does not exist\n"));
+            Log(("  client does not exist\n"));
             IPC_SendMsg(client, new ipcmMessageError(IPCM_ERROR_NO_CLIENT, msg->RequestIndex()));
         }
@@ -259 +260 @@
     OnForward(ipcClient *client, const ipcMessage *rawMsg)
     {
-        LOG(("got FORWARD\n"));
+        Log(("got FORWARD\n"));
 
         ipcMessageCast<ipcmMessageForward> msg(rawMsg);
@@ -265 +266 @@
         ipcClient *dest = IPC_GetClientByID(msg->ClientID());
         if (!dest) {
-            LOG(("  destination client not found!\n"));
+            Log(("  destination client not found!\n"));
             IPC_SendMsg(client, new ipcmMessageResult(IPCM_GetRequestIndex(rawMsg), IPCM_ERROR_NO_CLIENT));
             return;
@@ -297 +298 @@
 
     int type = IPCM_GetType(rawMsg);
-    LOG(("IPCM_HandleMsg [type=%x]\n", type));
+    Log(("IPCM_HandleMsg [type=%x]\n", type));
 
     if (!(type & IPCM_MSG_CLASS_REQ)) {
-        LOG(("not a request -- ignoring message\n"));
+        Log(("not a request -- ignoring message\n"));
         return;
     }
@@ -307 +308 @@
     type--;
     if (type < 0 || type >= (int) (sizeof(handlers)/sizeof(handlers[0]))) {
-        LOG(("unknown request -- ignoring message\n"));
+        Log(("unknown request -- ignoring message\n"));
         return;
     }

trunk/src/libs/xpcom18a4/ipc/ipcd/daemon/src/ipcd.cpp

@@ -35 +35 @@
  *
  * ***** END LICENSE BLOCK ***** */
-
+#define LOG_GROUP LOG_GROUP_IPC
 #include "ipcConfig.h"
-#include "ipcLog.h"
 #include "ipcMessage.h"
 #include "ipcClient.h"

trunk/src/libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp

@@ -36 +36 @@
  *
  * ***** END LICENSE BLOCK ***** */
-
+#define LOG_GROUP LOG_GROUP_IPC
 #include "ipcDConnectService.h"
 #include "ipcMessageWriter.h"
 #include "ipcMessageReader.h"
-#include "ipcLog.h"
 
 #include "nsIServiceManagerUtils.h"
@@ -61 +60 @@
 # include <iprt/time.h>
 # include <iprt/thread.h>
+
+# include <VBox/log.h>
 #endif /* VBOX */
 
@@ -452 +453 @@
     case nsXPTType::T_PWSTRING_SIZE_IS:
     default:
-      LOG(("unexpected parameter type: %d\n", t.TagPart()));
+      Log(("unexpected parameter type: %d\n", t.TagPart()));
       return NS_ERROR_UNEXPECTED;
   }
@@ -609 +610 @@
     case nsXPTType::T_PWSTRING_SIZE_IS:
     default:
-      LOG(("unexpected parameter type\n"));
+      Log(("unexpected parameter type\n"));
       return NS_ERROR_UNEXPECTED;
   }
@@ -646 +647 @@
 
       default:
-        LOG(("unhandled dipper: type=%d\n", t.TagPart()));
+        Log(("unhandled dipper: type=%d\n", t.TagPart()));
         return NS_ERROR_UNEXPECTED;
     }
@@ -855 +856 @@
     case nsXPTType::T_PWSTRING_SIZE_IS:
     default:
-      LOG(("unexpected parameter type\n"));
+      Log(("unexpected parameter type\n"));
       return NS_ERROR_UNEXPECTED;
   }
@@ -903 +904 @@
     if (pi.GetType().TagPart() != nsXPTType::T_U32)
     {
-      LOG(("unexpected size_is() parameter type: $d\n",
+      Log(("unexpected size_is() parameter type: $d\n",
            pi.GetType().TagPart()));
       return NS_ERROR_UNEXPECTED;
@@ -911 +912 @@
     if (pi.GetType().TagPart() != nsXPTType::T_U32)
     {
-      LOG(("unexpected length_is() parameter type: $d\n",
+      Log(("unexpected length_is() parameter type: $d\n",
            pi.GetType().TagPart()));
       return NS_ERROR_UNEXPECTED;
@@ -943 +944 @@
        elemType.IsReference()))
   {
-    LOG(("arrays of pointers and references to arithmetic types are "
+    Log(("arrays of pointers and references to arithmetic types are "
          "not yet supported\n"));
     return NS_ERROR_NOT_IMPLEMENTED;
@@ -950 +951 @@
   if (elemType.IsArray())
   {
-    LOG(("multidimensional arrays are not yet supported\n"));
+    Log(("multidimensional arrays are not yet supported\n"));
     return NS_ERROR_NOT_IMPLEMENTED;
   }
@@ -994 +995 @@
       break;
     default:
-      LOG(("unexpected parameter type: %d\n", type.TagPart()));
+      Log(("unexpected parameter type: %d\n", type.TagPart()));
       return NS_ERROR_UNEXPECTED;
   }
@@ -1101 +1102 @@
   if (prefix != 1)
   {
-    LOG(("unexpected array prefix: %u\n", prefix));
+    Log(("unexpected array prefix: %u\n", prefix));
     return NS_ERROR_UNEXPECTED;
   }
@@ -1255 +1256 @@
         break;
       default:
-        LOG(("unexpected parameter type: %d\n", elemType.TagPart()));
+        Log(("unexpected parameter type: %d\n", elemType.TagPart()));
         return;
     }
@@ -1387 +1388 @@
     if (aSenderID == IPC_SENDER_ANY && aTarget.Equals(nsID()) && !aData && !aDataLen)
     {
-        LOG(("DConnectMsgSelector::OnMessageAvailable: poll liveness for mPeer=%d\n",
+        Log(("DConnectMsgSelector::OnMessageAvailable: poll liveness for mPeer=%d\n",
              mPeer));
         ClientDownMap::iterator it = g_ClientDownMap.find(mPeer);
@@ -1432 +1433 @@
   {
     const DConnectOp *op = (const DConnectOp *) aData;
-    LOG((
+    Log((
       "DConnectCompletion::OnMessageAvailable: "
       "senderID=%d, opcode_major=%d, index=%d (waiting for %d)\n",
@@ -2236 +2237 @@
 DConnectStub::~DConnectStub()
 {
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
-  {
-    const char *name = NULL;
-    mIInfo->GetNameShared(&name);
-    LOG(("{%p} DConnectStub::<dtor>(): peer=%d instance=0x%Lx {%s}\n",
-         this, mPeerID, mInstance, name));
-  }
+#ifdef LOG_ENABLED
+  const char *name = NULL;
+  mIInfo->GetNameShared(&name);
+  Log(("{%p} DConnectStub::<dtor>(): peer=%d instance=0x%Lx {%s}\n",
+       this, mPeerID, mInstance, name));
 #endif
 
@@ -2280 +2278 @@
 
 
-    #ifdef IPC_LOGGING
-    if (IPC_LOG_ENABLED())
-    {
-      const char *name;
-      mIInfo->GetNameShared(&name);
-      LOG(("{%p} DConnectStub::Release(): peer=%d instance=0x%Lx {%s}, new count=%d\n",
-          this, mPeerID, mInstance, name, count));
-    }
-    #endif
+#ifdef LOG_ENABLED
+    const char *name;
+    mIInfo->GetNameShared(&name);
+    Log(("{%p} DConnectStub::Release(): peer=%d instance=0x%Lx {%s}, new count=%d\n",
+        this, mPeerID, mInstance, name, count));
+#endif
 
     // mRefCntLevels may already be empty here (due to the "stabilize" trick below)
@@ -2441 +2436 @@
   // else, we need to query the peer object by making an IPC call
 
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
+#ifdef LOG_ENABLED
   {
     const char *name;
@@ -2451 +2445 @@
     if (iinfoQ) {
         iinfoQ->GetNameShared(&nameQ);
-        LOG(("calling QueryInterface {%s} on peer object "
+        Log(("calling QueryInterface {%s} on peer object "
              "(stub=%p, instance=0x%Lx {%s})\n",
              nameQ, this, mInstance, name));
@@ -2494 +2488 @@
                          nsXPTCMiniVariant *aParams)
 {
-  LOG(("DConnectStub::CallMethod [methodIndex=%hu]\n", aMethodIndex));
+  Log(("DConnectStub::CallMethod [methodIndex=%hu]\n", aMethodIndex));
 
   nsresult rv;
@@ -2528 +2522 @@
   PRUint8 i, paramCount = aInfo->GetParamCount();
 
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
+#ifdef LOG_ENABLED
   {
     const char *name;
@@ -2535 +2528 @@
     GetInterfaceInfo(getter_AddRefs(iinfo));
     iinfo->GetNameShared(&name);
-    LOG(("  instance=0x%Lx {%s}\n", mInstance, name));
-    LOG(("  name=%s\n", aInfo->GetName()));
-    LOG(("  param-count=%u\n", (PRUint32) paramCount));
+    Log(("  instance=0x%Lx {%s}\n", mInstance, name));
+    Log(("  name=%s\n", aInfo->GetName()));
+    Log(("  param-count=%u\n", (PRUint32) paramCount));
   }
 #endif
@@ -2553 +2546 @@
   invoke.method_index = aMethodIndex;
 
-  LOG(("  request-index=%d\n", (PRUint32) invoke.request_index));
+  Log(("  request-index=%d\n", (PRUint32) invoke.request_index));
 
   writer.PutBytes(&invoke, sizeof(invoke));
@@ -2629 +2622 @@
                        writer.GetBuffer(),
                        writer.GetSize());
-  LOG(("DConnectStub::CallMethod: IPC_SendMessage()=%08X\n", rv));
+  Log(("DConnectStub::CallMethod: IPC_SendMessage()=%08X\n", rv));
   if (NS_FAILED(rv))
   {
@@ -2650 +2643 @@
                          &completion.GetSelector(), &completion,
                          DCON_WAIT_TIMEOUT);
-    LOG(("DConnectStub::CallMethod: IPC_WaitMessage()=%08X\n", rv));
+    Log(("DConnectStub::CallMethod: IPC_WaitMessage()=%08X\n", rv));
     if (NS_FAILED(rv))
     {
@@ -2723 +2716 @@
   if (completion.Reply()->flags & DCON_OP_FLAGS_REPLY_EXCEPTION)
   {
-    LOG(("got nsIException instance, will create a stub\n"));
+    Log(("got nsIException instance, will create a stub\n"));
 
     nsIException *xcpt = nsnull;
@@ -2767 +2760 @@
     const DConnectSetupReply *reply = (const DConnectSetupReply *) op;
 
-    LOG(("got SETUP_REPLY: status=%x instance=0x%Lx\n", reply->status, reply->instance));
+    Log(("got SETUP_REPLY: status=%x instance=0x%Lx\n", reply->status, reply->instance));
 
     mStatus = reply->status;
@@ -2792 +2785 @@
       ipcMessageReader reader(params, paramsLen);
 
-      LOG(("got nsIException instance, will create a stub\n"));
+      Log(("got nsIException instance, will create a stub\n"));
 
       nsresult rv;
@@ -2947 +2940 @@
 DConnectWorker::Run()
 {
-  LOG(("DConnect Worker thread started.\n"));
+  Log(("DConnect Worker thread started.\n"));
 
   mIsRunnable = PR_TRUE;
@@ -2978 +2971 @@
     else
     {
-      LOG(("DConnect Worker thread got request.\n"));
+      Log(("DConnect Worker thread got request.\n"));
 
       // remove the request from the queue
@@ -3002 +2995 @@
   mIsRunnable = PR_FALSE;
 
-  LOG(("DConnect Worker thread stopped.\n"));
+  Log(("DConnect Worker thread stopped.\n"));
   return NS_OK;
 }
@@ -3051 +3044 @@
   // disregarding the reference counter
 
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
-  {
-    const char *name;
-    aData->InterfaceInfo()->GetNameShared(&name);
-    LOG(("ipcDConnectService: WARNING: deleting unreleased "
-         "instance=%p iface=%p {%s}\n", aData, aData->RealInstance(), name));
-  }
+#ifdef LOG_ENABLED
+  const char *name;
+  aData->InterfaceInfo()->GetNameShared(&name);
+  Log(("ipcDConnectService: WARNING: deleting unreleased "
+       "instance=%p iface=%p {%s}\n", aData, aData->RealInstance(), name));
 #endif
 
@@ -3091 +3081 @@
   nsresult rv;
 
-  LOG(("ipcDConnectService::Init.\n"));
+  Log(("ipcDConnectService::Init.\n"));
 
   rv = IPC_DefineTarget(kDConnectTargetID, this);
@@ -3172 +3162 @@
   mInstance = this;
 
-  LOG(("ipcDConnectService::Init NS_OK.\n"));
+  Log(("ipcDConnectService::Init NS_OK.\n"));
   return NS_OK;
 }
@@ -3221 +3211 @@
   fprintf(stderr, "ipcDConnectService Stats\n");
   fprintf(stderr, " => number of worker threads: %d\n", mWorkers.Count());
-  LOG(("ipcDConnectService Stats\n"));
-  LOG((" => number of worker threads: %d\n", mWorkers.Count()));
+  Log(("ipcDConnectService Stats\n"));
+  Log((" => number of worker threads: %d\n", mWorkers.Count()));
 #endif
 
@@ -3230 +3220 @@
   // exited a working loop and abandon ones which have not
   // managed to do that when timeout occurred.
-  LOG(("Worker threads: %d\n", mWorkers.Count()));
+  Log(("Worker threads: %d\n", mWorkers.Count()));
   uint64_t tsStart = RTTimeMilliTS();
   while ((tsStart + VBOX_XPCOM_SHUTDOWN_TIMEOUT_MS ) > RTTimeMilliTS() && mWorkers.Count() > 0)
@@ -3242 +3232 @@
       if (worker->IsRunning() == PR_FALSE)
       {
-        LOG(("Worker %p joined.\n", worker));
+        Log(("Worker %p joined.\n", worker));
         worker->Join();
         delete worker;
@@ -3257 +3247 @@
   }
 
-  LOG(("There are %d thread(s) left.\n", mWorkers.Count()));
+  Log(("There are %d thread(s) left.\n", mWorkers.Count()));
 
   // If there are some running threads left, terminate the process.
@@ -3333 +3323 @@
 ipcDConnectService::StoreInstance(DConnectInstance *wrapper)
 {
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
-  {
-    const char *name;
-    wrapper->InterfaceInfo()->GetNameShared(&name);
-    LOG(("ipcDConnectService::StoreInstance(): instance=%p iface=%p {%s}\n",
-         wrapper, wrapper->RealInstance(), name));
-  }
+#ifdef LOG_ENABLED
+  const char *name;
+  wrapper->InterfaceInfo()->GetNameShared(&name);
+  Log(("ipcDConnectService::StoreInstance(): instance=%p iface=%p {%s}\n",
+       wrapper, wrapper->RealInstance(), name));
 #endif
 
@@ -3361 +3348 @@
     RTSemFastMutexRequest(mLock);
 
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
-  {
-    const char *name;
-    wrapper->InterfaceInfo()->GetNameShared(&name);
-    LOG(("ipcDConnectService::DeleteInstance(): instance=%p iface=%p {%s}\n",
-         wrapper, wrapper->RealInstance(), name));
-  }
+#ifdef LOG_ENABLED
+  const char *name;
+  wrapper->InterfaceInfo()->GetNameShared(&name);
+  Log(("ipcDConnectService::DeleteInstance(): instance=%p iface=%p {%s}\n",
+       wrapper, wrapper->RealInstance(), name));
 #endif
 
@@ -3406 +3390 @@
 ipcDConnectService::StoreStub(DConnectStub *stub)
 {
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
-  {
-    const char *name;
-    nsCOMPtr<nsIInterfaceInfo> iinfo;
-    stub->GetInterfaceInfo(getter_AddRefs(iinfo));
-    iinfo->GetNameShared(&name);
-    LOG(("ipcDConnectService::StoreStub(): stub=%p instance=0x%Lx {%s}\n",
-         stub, stub->Instance(), name));
-  }
+#ifdef LOG_ENABLED
+  const char *name;
+  nsCOMPtr<nsIInterfaceInfo> iinfo;
+  stub->GetInterfaceInfo(getter_AddRefs(iinfo));
+  iinfo->GetNameShared(&name);
+  Log(("ipcDConnectService::StoreStub(): stub=%p instance=0x%Lx {%s}\n",
+       stub, stub->Instance(), name));
 #endif
 
@@ -3425 +3406 @@
 ipcDConnectService::DeleteStub(DConnectStub *stub)
 {
-#ifdef IPC_LOGGING
-  if (IPC_LOG_ENABLED())
-  {
-    const char *name;
-    nsCOMPtr<nsIInterfaceInfo> iinfo;
-    stub->GetInterfaceInfo(getter_AddRefs(iinfo));
-    iinfo->GetNameShared(&name);
-    LOG(("ipcDConnectService::DeleteStub(): stub=%p instance=0x%Lx {%s}\n",
-         stub, stub->Instance(), name));
-  }
+#ifdef LOG_ENABLED
+  const char *name;
+  nsCOMPtr<nsIInterfaceInfo> iinfo;
+  stub->GetInterfaceInfo(getter_AddRefs(iinfo));
+  iinfo->GetNameShared(&name);
+  Log(("ipcDConnectService::DeleteStub(): stub=%p instance=0x%Lx {%s}\n",
+       stub, stub->Instance(), name));
 #endif
 
@@ -3547 +3525 @@
   const DConnectOp *op = (const DConnectOp *) aData;
 
-  LOG (("ipcDConnectService::OnMessageAvailable: "
+  Log (("ipcDConnectService::OnMessageAvailable: "
         "senderID=%d, opcode_major=%d, index=%d\n",
         aSenderID, op->opcode_major, op->request_index));
@@ -3623 +3601 @@
     nsrefcnt countIPC = aData->ReleaseIPC(PR_TRUE /* locked */);
 
-    LOG(("ipcDConnectService::PruneInstanceMapForPeer: "
+    Log(("ipcDConnectService::PruneInstanceMapForPeer: "
          "instance=%p: %d IPC refs to release\n",
          aData, countIPC + 1));
@@ -3655 +3633 @@
                                         PRUint32 aClientState)
 {
-  LOG(("ipcDConnectService::OnClientStateChange: aClientID=%d, aClientState=%d\n",
+  Log(("ipcDConnectService::OnClientStateChange: aClientID=%d, aClientState=%d\n",
        aClientID, aClientState));
 
@@ -3668 +3646 @@
     else
     {
-      LOG(("ipcDConnectService::OnClientStateChange: "
+      Log(("ipcDConnectService::OnClientStateChange: "
            "pruning all instances created for peer %d...\n", aClientID));
 
@@ -3681 +3659 @@
       }
 
-      LOG(("ipcDConnectService::OnClientStateChange: "
+      Log(("ipcDConnectService::OnClientStateChange: "
            "%d lost instances\n", wrappers.Count()));
 
@@ -3893 +3871 @@
         if (NS_SUCCEEDED(rv2))
         {
-          LOG(("got nsIException instance, will serialize\n"));
+          Log(("got nsIException instance, will serialize\n"));
           got_exception = PR_TRUE;
         }
@@ -3934 +3912 @@
   if (NS_FAILED(rv))
   {
-    LOG(("unable to send SETUP_REPLY: rv=%x\n", rv));
+    Log(("unable to send SETUP_REPLY: rv=%x\n", rv));
     ReleaseWrappers(wrappers, peer);
   }
@@ -3942 +3920 @@
 ipcDConnectService::OnRelease(PRUint32 peer, const DConnectRelease *release)
 {
-  LOG(("ipcDConnectService::OnRelease [peer=%u instance=0x%Lx]\n",
+  Log(("ipcDConnectService::OnRelease [peer=%u instance=0x%Lx]\n",
        peer, release->instance));
 
@@ -3969 +3947 @@
     // client gets processed here (because of true multithreading). Just log
     // a debug warning
-    LOG(("ipcDConnectService::OnRelease: WARNING: "
+    Log(("ipcDConnectService::OnRelease: WARNING: "
          "instance wrapper %p for peer %d not found", wrapper, peer));
   }
@@ -3977 +3955 @@
 ipcDConnectService::OnInvoke(PRUint32 peer, const DConnectInvoke *invoke, PRUint32 opLen)
 {
-  LOG(("ipcDConnectService::OnInvoke [peer=%u instance=0x%Lx method=%u]\n",
+  Log(("ipcDConnectService::OnInvoke [peer=%u instance=0x%Lx method=%u]\n",
       peer, invoke->instance, invoke->method_index));
 
@@ -4010 +3988 @@
   paramCount = methodInfo->GetParamCount();
 
-  LOG(("  iface=%p\n", wrapper->RealInstance()));
-  LOG(("  name=%s\n", methodInfo->GetName()));
-  LOG(("  param-count=%u\n", (PRUint32) paramCount));
-  LOG(("  request-index=%d\n", (PRUint32) invoke->request_index));
+  Log(("  iface=%p\n", wrapper->RealInstance()));
+  Log(("  name=%s\n", methodInfo->GetName()));
+  Log(("  param-count=%u\n", (PRUint32) paramCount));
+  Log(("  request-index=%d\n", (PRUint32) invoke->request_index));
 
   params = new nsXPTCVariant[paramCount];
@@ -4114 +4092 @@
         if (NS_SUCCEEDED(rv2))
         {
-          LOG(("got nsIException instance, will serialize\n"));
+          Log(("got nsIException instance, will serialize\n"));
           got_exception = PR_TRUE;
         }
@@ -4125 +4103 @@
 
 end:
-  LOG(("sending INVOKE_REPLY: rv=%x\n", rv));
+  Log(("sending INVOKE_REPLY: rv=%x\n", rv));
 
   // balance CheckInstanceAndAddRef()
@@ -4215 +4193 @@
   if (NS_FAILED(rv))
   {
-    LOG(("unable to send INVOKE_REPLY: rv=%x\n", rv));
+    Log(("unable to send INVOKE_REPLY: rv=%x\n", rv));
     ReleaseWrappers(wrappers, peer);
   }

trunk/src/libs/xpcom18a4/ipc/ipcd/extensions/lock/src/ipcLockService.cpp

@@ -37 +37 @@
  * ***** END LICENSE BLOCK ***** */
 
+#define LOG_GROUP LOG_GROUP_IPC
 #include <stdlib.h>
 #include "nsDependentString.h"
@@ -43 +44 @@
 #include "ipcLockService.h"
 #include "ipcLockProtocol.h"
-#include "ipcLog.h"
 
 #include <iprt/errcore.h>
+#include <VBox/log.h>
+
 
 static const nsID kLockTargetID = IPC_LOCK_TARGETID;
@@ -80 +82 @@
 ipcLockService::AcquireLock(const char *lockName, PRBool waitIfBusy)
 {
-    LOG(("ipcLockService::AcquireLock [lock=%s wait=%u]\n", lockName, waitIfBusy));
+    LogFlowFunc(("ipcLockService::AcquireLock [lock=%s wait=%u]\n", lockName, waitIfBusy));
 
     ipcLockMsg msg;
@@ -123 +125 @@
 ipcLockService::ReleaseLock(const char *lockName)
 {
-    LOG(("ipcLockService::ReleaseLock [lock=%s]\n", lockName));
+    LogFlowFunc(("ipcLockService::ReleaseLock [lock=%s]\n", lockName));
 
     ipcLockMsg msg;
@@ -152 +154 @@
     IPC_UnflattenLockMsg(data, dataLen, &msg);
 
-    LOG(("ipcLockService::OnMessageAvailable [lock=%s opcode=%u]\n", msg.key, msg.opcode));
+    LogFlowFunc(("ipcLockService::OnMessageAvailable [lock=%s opcode=%u]\n", msg.key, msg.opcode));
 
     ipcPendingLock *pendingLock = (ipcPendingLock *) RTTlsGet(mTPIndex);
@@ -164 +166 @@
     }
 
-    LOG(("message does not match; waiting for another...\n"));
+    LogFlowFunc(("message does not match; waiting for another...\n"));
 
     // else, we got a message that another thread is waiting to receive.

trunk/src/libs/xpcom18a4/ipc/ipcd/shared/src/ipcConfig.cpp

@@ -35 +35 @@
  *
  * ***** END LICENSE BLOCK ***** */
+#define LOG_GROUP LOG_GROUP_IPC
 
 #if defined(XP_WIN)
@@ -46 +47 @@
 #endif
 #include "ipcConfig.h"
-#include "ipcLog.h"
 #include "plstr.h"
 
 #include <iprt/env.h>
+#include <VBox/log.h>
 
 #if defined(XP_OS2) && !defined(XP_OS2_NATIVEIPC)
@@ -89 +90 @@
             logName = RTEnvGet("USER");
             if (!logName || !logName[0]) {
-                LOG(("could not determine username from environment\n"));
+                Log(("could not determine username from environment\n"));
                 goto end;
             }