Changeset 102279 in vbox for trunk

Timestamp:

Nov 23, 2023 4:34:33 PM (15 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10513: UIAdvancedSettingsDialog: Forgot to properly init page ID in r160198; This can cause crash in certain cases since ID == 0 is wrong; Added a bit of protection in crashed place as well.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.cpp

@@ -614 +614 @@
     , m_fSerializationClean(false)
     , m_fClosed(false)
-    , m_iPageId(0)
+    , m_iPageId(MachineSettingsPageType_Invalid)
     , m_pStatusBar(0)
     , m_pProcessBar(0)
@@ -669 +669 @@
     iPosition -= iT;
     /* And actual page position according to parent: */
-    const QPoint pnt = m_frames.value(m_iPageId)->pos();
-    iPosition += pnt.y();
+    UISettingsPageFrame *pFrame = m_frames.value(m_iPageId, 0);
+    AssertPtr(pFrame);
+    if (pFrame)
+    {
+        const QPoint pnt = pFrame->pos();
+        iPosition += pnt.y();
+    }
     /* Make sure corresponding page is visible: */
     m_pScrollArea->requestVerticalScrollBarPosition(iPosition);
@@ -949 +954 @@
                                        int iParentId /* = -1 */)
 {
+    /* Init m_iPageId if we haven't yet: */
+    if (m_iPageId == MachineSettingsPageType_Invalid)
+        m_iPageId = cId;
+
     /* Add new selector item: */
     if (m_pSelector->addItem(strBigIcon, strMediumIcon, strSmallIcon,