Changeset 102455 in vbox

Timestamp:

Dec 4, 2023 3:53:11 PM (17 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

160598

Message:

Main: Removed some more BUGBUG entries and documented empty / non-implemented code areas where needed. bugref:10384

Location:

trunk/src/VBox/Main

Files:

• src-client/ConsoleImpl.cpp (modified) (2 diffs)
• src-server/FirmwareSettingsImpl.cpp (modified) (1 diff)
• src-server/MachineImpl.cpp (modified) (3 diffs)
• src-server/PlatformARMImpl.cpp (modified) (3 diffs)
• src-server/PlatformImpl.cpp (modified) (2 diffs)
• xml/Settings.cpp (modified) (5 diffs)

trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

@@ -5272 +5272 @@
     AssertComRC(hrc);
 
-    ChipsetType_T chipsetType = ChipsetType_PIIX3; /** @todo BUGBUG ASSUMES x86! */
+    ChipsetType_T chipsetType = ChipsetType_PIIX3;
     pPlatform->COMGETTER(ChipsetType)(&chipsetType);
     AssertComRC(hrc);
@@ -10709 +10709 @@
     AssertComRC(hrc);
 
-    ChipsetType_T chipsetType = ChipsetType_PIIX3; /** @todo BUGBUG ASSUMES x86! */
+    ChipsetType_T chipsetType = ChipsetType_PIIX3;
     pPlatform->COMGETTER(ChipsetType)(&chipsetType);
     AssertComRC(hrc);

trunk/src/VBox/Main/src-server/FirmwareSettingsImpl.cpp

@@ -685 +685 @@
     else
     {
-        m->bd->firmwareType   = FirmwareType_BIOS; /** @todo BUGBUG Handle ARM? */
+        m->bd->firmwareType   = FirmwareType_BIOS;
         m->bd->fIOAPICEnabled = true;
     }

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -236 +236 @@
 Machine::HWData::HWData()
 {
-    /* default values for a newly created machine */
+    /* default values for a newly created machine for x86. */
     mHWVersion.printf("%d", SchemaDefs::DefaultHardwareVersion);
     mMemorySize = 128;
@@ -259 +259 @@
     mDnDMode = DnDMode_Disabled;
 
-    mKeyboardHIDType = KeyboardHIDType_PS2Keyboard; /** @todo BUGBUG Assumes x86! */
-    mPointingHIDType = PointingHIDType_PS2Mouse; /** @todo BUGBUG Assumes x86! */
+    mKeyboardHIDType = KeyboardHIDType_PS2Keyboard;
+    mPointingHIDType = PointingHIDType_PS2Mouse;
     mParavirtProvider = ParavirtProvider_Default;
     mEmulatedUSBCardReaderEnabled = FALSE;
@@ -6311 +6311 @@
         if (FAILED(hrc)) return hrc;
 
-        ChipsetType_T aChipset = ChipsetType_PIIX3; /** @todo BUGBUG ASSUMES x86! */
+        ChipsetType_T aChipset = ChipsetType_PIIX3;
         hrc = mPlatform->COMGETTER(ChipsetType)(&aChipset);
         if (FAILED(hrc)) return hrc;

trunk/src/VBox/Main/src-server/PlatformARMImpl.cpp

@@ -241 +241 @@
     RT_NOREF(data);
 
-    /** @todo BUGBUG Implement this form ARM! */
+    /* Nothing here yet. */
     return S_OK;
 }
@@ -257 +257 @@
     RT_NOREF(data);
 
-    /** @todo BUGBUG Implement this for ARM! */
+    /* Nothing here yet. */
     return S_OK;
 }
@@ -265 +265 @@
     RT_NOREF(aOsType);
 
-    /** @todo BUGBUG Implement this for ARM! */
-    return S_OK;
-}
+    /* Nothing here yet. */
+    return S_OK;
+}

trunk/src/VBox/Main/src-server/PlatformImpl.cpp

@@ -243 +243 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    /** @todo BUGBUG Implement this! */
     RT_NOREF(aArchitecture);
 
+    /* Currently we don't allow changing the platform architecture after the object was created.
+     * Mostly makes no sense, as this would render the VMs non-bootable and confuses users. */
     return E_NOTIMPL;
 }
@@ -510 +511 @@
     /* Allocates architecture-dependent stuff. */
     HRESULT hrc = i_initArchitecture(m->bd->architectureType);
-    AssertComRCReturnRC(hrc);
-
-    switch (m->bd->architectureType)
-    {
-        case PlatformArchitecture_x86:
-            return mX86->i_loadSettings(data.x86);
-
-#ifdef VBOX_WITH_VIRT_ARMV8
-        case PlatformArchitecture_ARM:
-            return mARM->i_loadSettings(data.arm);
-#endif
-        case PlatformArchitecture_None:
-            RT_FALL_THROUGH();
-        default:
-            break;
+    if (SUCCEEDED(hrc))
+    {
+        switch (m->bd->architectureType)
+        {
+            case PlatformArchitecture_x86:
+                return mX86->i_loadSettings(data.x86);
+
+#ifdef VBOX_WITH_VIRT_ARMV8
+            case PlatformArchitecture_ARM:
+                return mARM->i_loadSettings(data.arm);
+#endif
+            case PlatformArchitecture_None:
+                RT_FALL_THROUGH();
+            default:
+                break;
+        }
     }
 

trunk/src/VBox/Main/xml/Settings.cpp

@@ -3968 +3968 @@
 #ifdef VBOX_WITH_VIRT_ARMV8
 PlatformARM::PlatformARM()
-    /** @todo BUGBUG Anything for ARM here? */
-{
-
+{
 }
 
@@ -3976 +3974 @@
 {
     RT_NOREF(h);
-    return true; /** @todo BUGBUG Anything for ARM here? */
+    return true;
 }
 #endif /* VBOX_WITH_VIRT_ARMV8 */
@@ -4121 +4119 @@
     fPageFusionEnabled(false)
 {
-    mapBootOrder[0] = DeviceType_Floppy; /** @todo BUGBUG Handle ARM. */
+    mapBootOrder[0] = DeviceType_Floppy;
     mapBootOrder[1] = DeviceType_DVD;
     mapBootOrder[2] = DeviceType_HardDisk;
@@ -5441 +5439 @@
         case PlatformArchitecture_ARM:
         {
-            /** @todo BUGBUG Implement loading ARM platform stuff here. */
+            /* Nothing here yet -- add ARM-specific stuff as soon as we have it. */
             break;
         }
@@ -7428 +7426 @@
     if (plat.architectureType == PlatformArchitecture_x86)
         buildPlatformX86XML(*pelmPlatformOrHardware, *pelmCPU, plat.x86);
-    /** @todo BUGBUG Put ARM stuff here. */
+    /** @todo Put ARM stuff here as soon as we have it. */
 }