Changeset 102522 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Dec 7, 2023 1:33:02 PM (16 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

160666

Message:

VMM/IEM: Fixed regression from r160580 where we'd be triggering #UD on arm executing lock-prefixed inc, dec, neg, not and some others. bugref:10371

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllInstOneByte.cpp.h (modified) (7 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstOneByte.cpp.h

@@ -5278 +5278 @@
             \
             IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 0); \
-            IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); \
+            IEMOP_HLP_DONE_DECODING(); /** @todo testcase: lock xchg */ \
             IEM_MC_MEM_MAP_U8_RW(pu8Mem, bUnmapInfo, pVCpu->iem.s.iEffSeg, GCPtrEffDst); \
             IEM_MC_FETCH_GREG_U8(uTmpReg, IEM_GET_MODRM_REG(pVCpu, bRm)); \
@@ -5381 +5381 @@
                         \
                         IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 0); \
-                        IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); \
+                        IEMOP_HLP_DONE_DECODING(); /** @todo testcase: lock xchg */ \
                         IEM_MC_MEM_MAP_U16_RW(pu16Mem, bUnmapInfo, pVCpu->iem.s.iEffSeg, GCPtrEffDst); \
                         IEM_MC_FETCH_GREG_U16(uTmpReg, IEM_GET_MODRM_REG(pVCpu, bRm)); \
@@ -5401 +5401 @@
                         \
                         IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 0); \
-                        IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); \
+                        IEMOP_HLP_DONE_DECODING(); \
                         IEM_MC_MEM_MAP_U32_RW(pu32Mem, bUnmapInfo, pVCpu->iem.s.iEffSeg, GCPtrEffDst); \
                         IEM_MC_FETCH_GREG_U32(uTmpReg, IEM_GET_MODRM_REG(pVCpu, bRm)); \
@@ -5421 +5421 @@
                         \
                         IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 0); \
-                        IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); \
+                        IEMOP_HLP_DONE_DECODING(); \
                         IEM_MC_MEM_MAP_U64_RW(pu64Mem, bUnmapInfo, pVCpu->iem.s.iEffSeg, GCPtrEffDst); \
                         IEM_MC_FETCH_GREG_U64(uTmpReg, IEM_GET_MODRM_REG(pVCpu, bRm)); \
@@ -13125 +13125 @@
                     \
                     IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 0); \
-                    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); \
+                    IEMOP_HLP_DONE_DECODING(); \
                     IEM_MC_MEM_MAP_U16_RW(pu16Dst, bUnmapInfo, pVCpu->iem.s.iEffSeg, GCPtrEffDst); \
                     IEM_MC_FETCH_EFLAGS(EFlags); \
@@ -13144 +13144 @@
                     \
                     IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 0); \
-                    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); \
+                    IEMOP_HLP_DONE_DECODING(); \
                     IEM_MC_MEM_MAP_U32_RW(pu32Dst, bUnmapInfo, pVCpu->iem.s.iEffSeg, GCPtrEffDst); \
                     IEM_MC_FETCH_EFLAGS(EFlags); \
@@ -13163 +13163 @@
                     \
                     IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 0); \
-                    IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX(); \
+                    IEMOP_HLP_DONE_DECODING(); \
                     IEM_MC_MEM_MAP_U64_RW(pu64Dst, bUnmapInfo, pVCpu->iem.s.iEffSeg, GCPtrEffDst); \
                     IEM_MC_FETCH_EFLAGS(EFlags); \