Changeset 102581 in vbox

Timestamp:

Dec 12, 2023 8:45:11 AM (15 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

160729

Message:

VMM/IEM: The IEM_MC*_PUSH_* MCs implictly frees the variable they're passed. The emitter code was already doing this, but the free call and python checks were missing. bugref:10371

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IEMAllN8vePython.py (modified) (1 diff)
• IEMAllN8veRecompiler.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllN8vePython.py

@@ -385 +385 @@
                             del dVars[sParam];
                         else:
-                            self.raiseProblem('Variable %s was used after implictly frees by %s!' % (sParam, oStmt.sName,));
+                            self.raiseProblem('Variable %s was used after implictly freed by %s!' % (sParam, oStmt.sName,));
+
+                elif oStmt.sName in ('IEM_MC_PUSH_U16', 'IEM_MC_PUSH_U32', 'IEM_MC_PUSH_U32_SREG', 'IEM_MC_PUSH_U64',
+                                     'IEM_MC_FLAT32_PUSH_U16', 'IEM_MC_FLAT32_PUSH_U32', 'IEM_MC_FLAT32_PUSH_U32_SREG',
+                                     'IEM_MC_FLAT64_PUSH_U16', 'IEM_MC_FLAT64_PUSH_U64',):
+                    #
+                    # The variable being pushed is implicitly freed.
+                    #
+                    for sParam in oStmt.asParams:
+                        oVarInfo = dVars.get(sParam);
+                        if oVarInfo:
+                            dFreedVars[sParam] = oVarInfo;
+                            del dVars[sParam];
+                        else:
+                            self.raiseProblem('Variable %s was used after implictly freed by %s!' % (sParam, oStmt.sName,));
                 else:
                     #

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -10027 +10027 @@
     /* Done setting up parameters, make the call. */
     off = iemNativeEmitCallImm(pReNative, off, pfnFunction);
+
+    /* The value variable is implictly flushed. */
+    iemNativeVarFreeLocal(pReNative, idxVarValue);
 
     iemNativeLabelDefine(pReNative, idxLabelTlbDone, off);