Changeset 102612 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Dec 15, 2023 12:36:51 PM (12 months ago)

Author:

vboxsync

Message:

Audio/WAS: Attempt to fix crashes when invalidating the cached audio interfaces of the device entry configurations. This is needed when the audio interface becomes invalid on a host device switch. Extended logging a bit. ​bugref:10503

File:

• trunk/src/VBox/Devices/Audio/DrvHostAudioWasApi.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Audio/DrvHostAudioWasApi.cpp

@@ -815 +815 @@
  * Invalidates device cache entry configurations.
  *
+ * This is needed in order to not run into deadlocks when trying to release a stale device interface
+ * via Release().
+ *
  * @param   pThis       The WASAPI host audio driver instance data.
  * @param   pDevEntry   The device entry to invalidate.
@@ -841 +844 @@
     PDRVHOSTAUDIOWASCACHEDEVCFG pDevCfg, pDevCfgNext;
     RTListForEachSafe(&pDevEntry->ConfigList, pDevCfg, pDevCfgNext, DRVHOSTAUDIOWASCACHEDEVCFG, ListEntry)
-    {
         drvHostAudioWasCacheDestroyDevConfig(pThis, pDevCfg);
-    }
 
     uint32_t cDevRefs = 0;
@@ -1262 +1263 @@
                 if (pIDevice != pDevEntry->pIDevice)
                 {
-                    Log2Func(("Cache hit for device '%ls': Stale interface (new: %p, old: %p)\n",
+                    LogRel2(("WasAPI: Cache hit for device '%ls': Stale interface (new: %p, old: %p)\n",
                               pDevEntry->wszDevId, pIDevice, pDevEntry->pIDevice));
 
@@ -1275 +1276 @@
                 }
 
+                LogRel2(("WasAPI: Cache hit for device '%ls' (%p)\n", pwszDevId, pIDevice));
+
                 CoTaskMemFree(pwszDevId);
-                Log8Func(("Cache hit for device '%ls': %p\n", pDevEntry->wszDevId, pDevEntry));
+                pwszDevId = NULL;
+
                 return drvHostAudioWasCacheLookupOrCreateConfig(pThis, pDevEntry, pCfgReq, fOnWorker, ppDevCfg);
             }
@@ -1282 +1286 @@
         RTCritSectLeave(&pThis->CritSectCache);
 
-        if (pDevEntry)
-            Log8Func(("Cache miss for device '%ls': %p\n", pDevEntry->wszDevId, pDevEntry));
+        LogRel2(("WasAPI: Cache miss for device '%ls' (%p)\n", pwszDevId, pIDevice));
 
         /*