Changeset 102656 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Dec 20, 2023 4:33:54 PM (15 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

160818

Message:

IEMAllAImpl.asm: Windows and SysV ABI does not guarantee that top bits of byte/word/dword arguments passed in 64-bit registers are cleared. We must clear them ourselves!

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllAImpl.asm (modified) (29 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllAImpl.asm

@@ -140 +140 @@
   %define A3_32     ecx
   %define A3_16     cx
+  %define A3_8      cl
  %endif
 
@@ -161 +162 @@
   %define A3_32     r9d
   %define A3_16     r9w
+  %define A3_8      r9b
  %endif
 
@@ -4020 +4022 @@
         IEMIMPL_MMX_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movq    mm1, [A1]
         movq    mm0, mm0                ; paranoia!
@@ -4052 +4055 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movdqu  xmm1, [A1]
         movdqu  xmm0, xmm1              ; paranoia!
@@ -4090 +4094 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         vmovdqu  ymm1, [A1]
         vmovdqu  ymm0, ymm1             ; paranoia!
@@ -4131 +4136 @@
         IEMIMPL_MMX_PROLOGUE
 
+        movzx   A1, A1_8                ; must clear top bits
         movq    mm0, [A0]
         lea     T1, [.imm0 xWrtRIP]
@@ -4172 +4178 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A1, A1_8                ; must clear top bits
         movdqu  xmm0, [A0]
         lea     T1, [.imm0 xWrtRIP]
@@ -5025 +5032 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movdqu  xmm0, [A0]
         movdqu  xmm1, [A1]
@@ -5064 +5072 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movdqu  xmm0, [A0]
         movdqu  xmm1, [A1]
@@ -5106 +5115 @@
         IEMIMPL_AVX_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm0, [A1]
         movdqu  xmm1, [A2]
@@ -5136 +5146 @@
         IEMIMPL_AVX_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         vmovdqu ymm0, [A1]
         vmovdqu ymm1, [A2]
@@ -5251 +5262 @@
         IEMIMPL_MMX_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movq    mm0, [A0]
         movq    mm1, A1
@@ -5294 +5306 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movdqu  xmm0, [A0]
         movdqu  xmm1, [A1]
@@ -5351 +5364 @@
         IEMIMPL_AVX_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm0, [A1]
         movdqu  xmm1, [A2]
@@ -5384 +5398 @@
         IEMIMPL_AVX_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         vmovdqu ymm0, [A1]
         vmovdqu ymm1, [A2]
@@ -5450 +5465 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm0, [A2 + IEMPCMPISTRXSRC.uSrc1]
         movdqu  xmm1, [A2 + IEMPCMPISTRXSRC.uSrc2]
@@ -5492 +5508 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm0, [A2 + IEMPCMPESTRXSRC.uSrc1]
         movdqu  xmm1, [A2 + IEMPCMPESTRXSRC.uSrc2]
@@ -5538 +5555 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm1, [A2 + IEMPCMPISTRXSRC.uSrc1]
         movdqu  xmm2, [A2 + IEMPCMPISTRXSRC.uSrc2]
@@ -5579 +5597 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm1, [A2 + IEMPCMPESTRXSRC.uSrc1]
         movdqu  xmm2, [A2 + IEMPCMPESTRXSRC.uSrc2]
@@ -5624 +5643 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movq    mm0,  [A0]
         lea     T1, [.imm0 xWrtRIP]
@@ -5653 +5673 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movdqu  xmm0, [A0]
         lea     T1, [.imm0 xWrtRIP]
@@ -5690 +5711 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm0, [A1]
         lea     T1, [.imm0 xWrtRIP]
@@ -5728 +5750 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movq    mm0,  A1
         lea     T1, [.imm0 xWrtRIP]
@@ -5757 +5780 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movdqu  xmm0, [A1]
         lea     T1, [.imm0 xWrtRIP]
@@ -5793 +5817 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movdqu  xmm0, [A1]
         lea     T1, [.imm0 xWrtRIP]
@@ -6375 +6400 @@
         SSE_LD_FXSTATE_MXCSR_ONLY A0
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm0, [A2 + IEMMEDIAF2XMMSRC.uSrc1]
         movdqu  xmm1, [A2 + IEMMEDIAF2XMMSRC.uSrc2]
@@ -6421 +6447 @@
         SSE_LD_FXSTATE_MXCSR_ONLY A0
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm0, [A2 + IEMMEDIAF2XMMSRC.uSrc1]
         movdqu  xmm1, [A2 + IEMMEDIAF2XMMSRC.uSrc2]
@@ -6472 +6499 @@
         SSE_LD_FXSTATE_MXCSR_ONLY A0
 
+        movzx   A3, A3_8                ; must clear top bits
         movdqu  xmm0, [A2 + IEMMEDIAF2XMMSRC.uSrc1]
         movdqu  xmm1, [A2 + IEMMEDIAF2XMMSRC.uSrc2]
@@ -6639 +6667 @@
         IEMIMPL_SSE_PROLOGUE
 
+        movzx   A2, A2_8                ; must clear top bits
         movdqu  xmm0, [A0]
         movdqu  xmm1, [A1]