Changeset 102678 in vbox for trunk

Timestamp:

Dec 21, 2023 2:08:52 PM (14 months ago)

Author:

vboxsync

Message:

Audio/WAS: Also check the audio interface of an audio device when checking the cache for a race, before adding it to the cache. bugref:10503

File:

• trunk/src/VBox/Devices/Audio/DrvHostAudioWasApi.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DrvHostAudioWasApi.cpp

@@ -1291 +1291 @@
             {
                 if (   pDevEntry2->cwcDevId == cwcDevId
+                    /* Note: We have to compare the device interface here as well, as a cached device entry might
+                     * have a stale audio interface for the same device. In such a case a new device entry will be created below. */
+                    && pDevEntry2->pIDevice == pIDevice
                     && pDevEntry2->enmDir   == pCfgReq->enmDir
                     && RTUtf16Cmp(pDevEntry2->wszDevId, pDevEntry->wszDevId) == 0)
@@ -1298 +1301 @@
                     pDevEntry = NULL;
 
-                    Log8Func(("Lost race adding device '%ls': %p\n", pDevEntry2->wszDevId, pDevEntry2));
+                    LogRel2(("WasAPI: Lost race adding device '%ls': %p\n", pDevEntry2->wszDevId, pDevEntry2));
                     return drvHostAudioWasCacheLookupOrCreateConfig(pThis, pDevEntry2, pCfgReq, fOnWorker, ppDevCfg);
                 }
@@ -1304 +1307 @@
             RTListPrepend(&pThis->CacheHead, &pDevEntry->ListEntry);
 
-            Log8Func(("Added device '%ls' to cache: %p\n", pDevEntry->wszDevId, pDevEntry));
+            LogRel2(("WasAPI: Added device '%ls' to cache: %p\n", pDevEntry->wszDevId, pDevEntry));
             return drvHostAudioWasCacheLookupOrCreateConfig(pThis, pDevEntry, pCfgReq, fOnWorker, ppDevCfg);
         }