Changeset 102684 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Dec 21, 2023 9:36:01 PM (15 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

160851

Message:

VMM/IEM: Fixed another bug in related to ah,ch,dh,bh storing (AMD64 host). bugref:10371

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IEMAllN8veRecompiler.cpp (modified) (4 diffs)
• IEMAllThrdRecompiler.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -4023 +4023 @@
  */
 DECL_HIDDEN_THROW(uint32_t)
-iemNativeRegMoveAndFreeAndFlushAtCall(PIEMRECOMPILERSTATE pReNative, uint32_t off, uint8_t cArgs, uint32_t fKeepVars = 0)
+iemNativeRegMoveAndFreeAndFlushAtCall(PIEMRECOMPILERSTATE pReNative, uint32_t off, uint8_t cArgs, uint32_t fKeepVars /*= 0*/)
 {
     Assert(cArgs <= IEMNATIVE_CALL_MAX_ARG_COUNT);
@@ -4786 +4786 @@
  * Emits a call to a threaded worker function.
  */
-static uint32_t iemNativeEmitThreadedCall(PIEMRECOMPILERSTATE pReNative, uint32_t off, PCIEMTHRDEDCALLENTRY pCallEntry)
+DECL_HIDDEN_THROW(uint32_t)
+iemNativeEmitThreadedCall(PIEMRECOMPILERSTATE pReNative, uint32_t off, PCIEMTHRDEDCALLENTRY pCallEntry)
 {
     iemNativeRegFlushGuestShadows(pReNative, UINT64_MAX); /** @todo optimize this */
@@ -8230 +8231 @@
     else if (idxGstTmpReg < 4 && idxVarReg < 4)
     {
-        /** @todo test this.   */
         uint8_t * const pbCodeBuf = iemNativeInstrBufEnsure(pReNative, off, 2+1);
         pbCodeBuf[off++] = 0x8a;
@@ -8248 +8248 @@
         if (idxGstTmpReg >= 8 || idxVarReg >= 8)
             pbCodeBuf[off++] = (idxGstTmpReg >= 8 ? X86_OP_REX_R : 0) | (idxVarReg >= 8 ? X86_OP_REX_B : 0);
-        else if (idxGstTmpReg >= 4)
+        else if (idxGstTmpReg >= 4 || idxVarReg >= 4)
             pbCodeBuf[off++] = X86_OP_REX;
         pbCodeBuf[off++] = 0x8a;

trunk/src/VBox/VMM/VMMAll/IEMAllThrdRecompiler.cpp

@@ -2364 +2364 @@
 
 #if defined(LOG_ENABLED) && 0 /* for debugging */
-            iemThreadedCompileEmitNop(pTb);
+            //iemThreadedCompileEmitNop(pTb);
             iemThreadedCompileEmitLogCpuState(pTb);
 #endif