Changeset 102703 in vbox

Timestamp:

Dec 26, 2023 12:39:08 PM (11 months ago)

Author:

vboxsync

Message:

VMM/IEM: Extended IEMTB_KEY_MASK to include the CPL so IEMTLBE_F_PT_NO_USER can be determined at compile time in the native recompiler. bugref:10371

File:

• trunk/src/VBox/VMM/include/IEMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -790 +790 @@
 
 /** Mask of the IEMTB_F_XXX flags that are part of the TB lookup key.
- * @note We skip the CPL as we don't currently generate ring-specific code,
- *       that's all handled in CIMPL functions.
- *
- *       For the same reasons, we skip all of IEM_F_X86_CTX_MASK, with the
- *       exception of SMM (which we don't implement). */
-#define IEMTB_F_KEY_MASK                (  (UINT32_MAX & ~(IEM_F_X86_CTX_MASK | IEM_F_X86_CPL_MASK | IEMTB_F_TYPE_MASK)) \
-                                         | IEM_F_X86_CTX_SMM)
+ *
+ * @note We skip all of IEM_F_X86_CTX_MASK, with the exception of SMM (which we
+ *       don't implement), because we don't currently generate any context
+ *       specific code - that's all handled in CIMPL functions.
+ *
+ *       For the threaded recompiler we don't generate any CPL specific code
+ *       either, but the native recompiler does for memory access (saves getting
+ *       the CPL from fExec and turning it into IEMTLBE_F_PT_NO_USER).
+ *       Since most OSes will not share code between rings, this shouldn't
+ *       have any real effect on TB/memory/recompiling load.
+ */
+#define IEMTB_F_KEY_MASK                ((UINT32_MAX & ~(IEM_F_X86_CTX_MASK | IEMTB_F_TYPE_MASK)) | IEM_F_X86_CTX_SMM)
 /** @} */