Changeset 102773 in vbox

Timestamp:

Jan 5, 2024 12:56:26 PM (11 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10501. Dealing with cloud vm state changes a bit better.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/activity/vmactivity/UIVMActivityMonitor.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/activity/vmactivity/UIVMActivityMonitor.cpp

@@ -757 +757 @@
             const QQueue<QString> *labels = m_pMetric->labels();
             int iDataIndex = qMin(labels->size() - 1, iTimeIndex - (m_iMaximumQueueSize - maxDataSize()));
-            strAxisText = UIVMActivityMonitorCloud::formatCloudTimeStamp(labels->at(iDataIndex));
+            if (iDataIndex >= 0)
+                strAxisText = UIVMActivityMonitorCloud::formatCloudTimeStamp(labels->at(iDataIndex));
         }
         else
@@ -1950 +1951 @@
     resetDiskIOInfoLabel();
     resetRAMInfoLabel();
+
+    if (m_comMachine.isOk())
+    {
+        m_ReadListProgressTask = new UIProgressTaskReadCloudMachineMetricList(this, m_comMachine);
+        if (m_ReadListProgressTask)
+            connect(m_ReadListProgressTask, &UIProgressTaskReadCloudMachineMetricList::sigMetricListReceived,
+                    this, &UIVMActivityMonitorCloud::sltMetricNameListingComplete);
+    }
+    /* Start the timer: */
+    start();
 }
 
@@ -1994 +2005 @@
     if (!m_comMachine.isOk())
         return;
-
-    m_ReadListProgressTask = new UIProgressTaskReadCloudMachineMetricList(this, comMachine);
-    if (m_ReadListProgressTask)
-    {
-        connect(m_ReadListProgressTask, &UIProgressTaskReadCloudMachineMetricList::sigMetricListReceived,
-                this, &UIVMActivityMonitorCloud::sltMetricNameListingComplete);
-        m_ReadListProgressTask->start();
-    }
+    setEnabled(m_comMachine.GetState() == KCloudMachineState_Running);
 }
 
@@ -2072 +2076 @@
 void UIVMActivityMonitorCloud::obtainDataAndUpdate()
 {
+    /* No need to refresh cached values of the ICloudMachine since it has been already done
+     * by the VM list related class. Just fetch the machine attribute here:  */
+    if (!m_comMachine.isOk() || m_comMachine.GetState() != KCloudMachineState_Running)
+    {
+        setEnabled(false);
+        return;
+    }
+    if (!isEnabled())
+        setEnabled(true);
+    if (m_ReadListProgressTask && !m_ReadListProgressTask->isRunning())
+        m_ReadListProgressTask->start();
     foreach (const KMetricType &enmMetricType, m_availableMetricTypes)
     {
@@ -2342 +2357 @@
 QString UIVMActivityMonitorCloud::formatCloudTimeStamp(const QString &strInput)
 {
+    if (strInput.isEmpty())
+        return QString();
     QDateTime dateTime = QDateTime::fromString(strInput, Qt::RFC2822Date);