Changeset 102879 in vbox

Timestamp:

Jan 15, 2024 3:28:34 PM (14 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161099

Message:

VMM/IEM: Skip PC validation and such if we don't jump on a conditional branch (when compiling). Disabled setting two unused IEMCPU members. bugref:10371

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllThrdPython.py (modified) (3 diffs)
• VMMAll/IEMAllThrdTables.h (modified) (1 diff)
• include/IEMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllThrdPython.py

@@ -1418 +1418 @@
         variation and any subsequent checks that may be necessary after that.
 
-        The sCallVarNm is for emitting
+        The sCallVarNm is the name of the variable with the threaded function
+        to call.  This is for the case where all the variations have the same
+        parameters and only the threaded function number differs.
         """
         aoStmts = [
@@ -1472 +1474 @@
             elif sFlag.startswith('IEM_CIMPL_F_BRANCH_'):
                 asTbBranchedFlags.append(sFlag);
-        if asTbBranchedFlags:
+        if (    asTbBranchedFlags
+            and (   'IEM_CIMPL_F_BRANCH_CONDITIONAL' not in asTbBranchedFlags
+                 or self.sVariation not in self.kdVariationsWithConditionalNoJmp)):
             aoStmts.append(iai.McCppGeneric('iemThreadedSetBranched(pVCpu, %s);'
                                             % ((' | '.join(asTbBranchedFlags)).replace('IEM_CIMPL_F_BRANCH', 'IEMBRANCHED_F'),),
@@ -1740 +1744 @@
         # Special case for only default variation:
         if len(self.aoVariations) == 1  and  self.aoVariations[0].sVariation == ThreadedFunctionVariation.ksVariation_Default:
+            assert not sBranch;
             return self.aoVariations[0].emitThreadedCallStmts(0);
 

trunk/src/VBox/VMM/VMMAll/IEMAllThrdTables.h

@@ -351 +351 @@
 {
     pVCpu->iem.s.fTbBranched          = fTbBranched;
-    pVCpu->iem.s.GCPhysTbBranchSrcBuf = pVCpu->iem.s.GCPhysInstrBuf;
-    pVCpu->iem.s.GCVirtTbBranchSrcBuf = pVCpu->iem.s.uInstrBufPc;
+    //pVCpu->iem.s.GCPhysTbBranchSrcBuf = pVCpu->iem.s.GCPhysInstrBuf;
+    //pVCpu->iem.s.GCVirtTbBranchSrcBuf = pVCpu->iem.s.uInstrBufPc;
 }
 

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -1701 +1701 @@
      * whether a branch instruction jumps to a new page or stays within the
      * current one. */
-    RTGCPHYS                GCPhysTbBranchSrcBuf;
+    RTGCPHYS                GCPhysTbBranchSrcBufUnused;
     /** Copy of IEMCPU::uInstrBufPc after decoding a branch instruction.  */
-    uint64_t                GCVirtTbBranchSrcBuf;
+    uint64_t                GCVirtTbBranchSrcBufUnused;
     /** Pointer to the ring-3 TB allocator for this EMT. */
     R3PTRTYPE(PIEMTBALLOCATOR) pTbAllocatorR3;