Changeset 102886 in vbox for trunk/src

Timestamp:

Jan 16, 2024 8:59:26 AM (13 months ago)

Author:

vboxsync

Message:

Runtime/tstRTSg: Ensure that u64First <= u64Last when passed to RTRandAdvU64Ex() as it will return very large values otherwise breaking the testcase as the offset is not in the range to be expected, fixes spurious testcase failes [better fix]

File:

• trunk/src/VBox/Runtime/testcase/tstRTSg.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/testcase/tstRTSg.cpp

@@ -208 +208 @@
 
         /* Use RTSgBufGetNextSegment with random starting point. */
-        for (unsigned iRun = 0; iRun < _1K; iRun++)
+        for (unsigned iRun = 0; iRun < RT_MIN(_1K, cbSgBuf1); iRun++)
         {
             RTSgBufReset(pSgBuf1);
@@ -214 +214 @@
             if (iRun > 1)
             {
-                size_t const cbInitial = (size_t)RTRandAdvU64Ex(hRnd, RT_MIN(iRun, cbSgBuf1), cbSgBuf1);
+                size_t const cbInitial = (size_t)RTRandAdvU64Ex(hRnd, iRun, cbSgBuf1);
                 size_t cbAdvanced = RTSgBufAdvance(pSgBuf1, cbInitial);
                 RTTESTI_CHECK_MSG(cbAdvanced == cbInitial, ("iBufVar=%u iRun=%u cbAdvanced=%zu, cbInitial=%zu\n", iBufVar, iRun, cbAdvanced, cbInitial));
@@ -246 +246 @@
         {
             uint8_t const *pbSrc = (uint8_t const *)pSgBuf1->paSegs[0].pvSeg;
-            for (unsigned iRun = 0; iRun < _1K; iRun++)
+            for (unsigned iRun = 0; iRun < RT_MIN(_1K, cbSgBuf1); iRun++)
             {
                 RTSgBufReset(pSgBuf1);
@@ -253 +253 @@
                 if (iRun > 1)
                 {
-                    cbInitial = (size_t)RTRandAdvU64Ex(hRnd, RT_MIN(iRun, cbSgBuf1), cbSgBuf1);
+                    cbInitial = (size_t)RTRandAdvU64Ex(hRnd, iRun, cbSgBuf1);
                     size_t cbAdvanced = RTSgBufAdvance(pSgBuf1, cbInitial);
                     RTTESTI_CHECK_MSG(cbAdvanced == cbInitial, ("cbAdvanced=%zu, cbInitial=%zu\n",