Changeset 102934 in vbox

Timestamp:

Jan 17, 2024 4:56:24 PM (13 months ago)

Author:

vboxsync

Message:

VBoxManage/Guest Control: Don't re-assign fWaitForStdOut / fWaitForStdErr with the result from gctlRunSetupHandle(), as the function will return a boolean success status. This will overwrite the original flag value and thus adding unwanted flags to the API.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -1352 +1352 @@
         {
             aWaitFlags.push_back(ProcessWaitForFlag_Terminate);
-            fWaitForStdOut = gctlRunSetupHandle(fWaitForStdOut, RTHANDLESTD_OUTPUT, "stdout", enmStdOutTransform, &hVfsStdOut);
-            if (fWaitForStdOut)
+            if (   fWaitForStdOut
+                && gctlRunSetupHandle(fWaitForStdOut, RTHANDLESTD_OUTPUT, "stdout", enmStdOutTransform, &hVfsStdOut))
             {
                 aCreateFlags.push_back(ProcessCreateFlag_WaitForStdOut);
                 aWaitFlags.push_back(ProcessWaitForFlag_StdOut);
             }
-            fWaitForStdErr = gctlRunSetupHandle(fWaitForStdErr, RTHANDLESTD_ERROR, "stderr", enmStdErrTransform, &hVfsStdErr);
-            if (fWaitForStdErr)
+            if (   fWaitForStdErr
+                && gctlRunSetupHandle(fWaitForStdErr, RTHANDLESTD_ERROR, "stderr", enmStdErrTransform, &hVfsStdErr))
             {
                 aCreateFlags.push_back(ProcessCreateFlag_WaitForStdErr);